- Engine-commits - oVirt List Archives

Change in samples-portals[master]: added Gemfile
by shavivi＠redhat.com 13 Feb '13

13 Feb '13

Shahar Havivi has submitted this change and it was merged. Change subject: added Gemfile ...................................................................... added Gemfile Change-Id: I43407ff479d1f6ce605f8e1c4ebff17a688e4f97 Signed-off-by: Ohad Levy <ohadlevy(a)gmail.com> Signed-off-by: Shahar Havivi <shaharh(a)gmail.com> --- A ruby/Gemfile A ruby/Gemfile.lock M ruby/README M ruby/webhandler.rb 4 files changed, 45 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43407ff479d1f6ce605f8e1c4ebff17a688e4f97 Gerrit-PatchSet: 3 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Ohad Levy <ohadlevy(a)redhat.com> Gerrit-Reviewer: Ohad Levy <ohadlevy(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: attempt revert when failing to add template
by amureini＠redhat.com 13 Feb '13

13 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: attempt revert when failing to add template ...................................................................... core: attempt revert when failing to add template When failing to add a template, delete the added template disks from the db and attempt to delete the possibly added images from the storage to avoid storage leak. Change-Id: Ia0f40397f5fb9f7e1a3535796c07f5bed7bd5ac1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=883921 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java 2 files changed, 18 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0f40397f5fb9f7e1a3535796c07f5bed7bd5ac1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup AddVmPoolWithVmsCommand#getJobMessagePropertie...
by masayag＠redhat.com 13 Feb '13

13 Feb '13

Moti Asayag has submitted this change and it was merged. Change subject: core: cleanup AddVmPoolWithVmsCommand#getJobMessageProperties ...................................................................... core: cleanup AddVmPoolWithVmsCommand#getJobMessageProperties - fix indentation - replace simple if statements with ternary if - replace "" with StringUtils.Empty Change-Id: I1513f901b7c5ef2b3d215ff119e0f69240c9411a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java 1 file changed, 7 insertions(+), 12 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1513f901b7c5ef2b3d215ff119e0f69240c9411a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: moved repeated null value check.
by tnisan＠redhat.com 13 Feb '13

13 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: moved repeated null value check. ...................................................................... core: moved repeated null value check. The null value check of the relevant disk image repeated itself and left a chance for an NPE - now it's done within the called method. Change-Id: I3e4958c9dc108dc6d44e25a5074439e6ec018c12 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e4958c9dc108dc6d44e25a5074439e6ec018c12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: show event -id accept strings instead of numeric values...
by mpastern＠redhat.com 13 Feb '13

13 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: show event -id accept strings instead of numeric values(#886786) ...................................................................... cli: show event -id accept strings instead of numeric values(#886786) Show event -id does not accept numeric values. This patch does and explicit cast into string for ids. Change-Id: Ie31f1f6cb9e5bbc9146088bd820cf80ebf41d757 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=886786 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/11982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie31f1f6cb9e5bbc9146088bd820cf80ebf41d757 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: TimeoutBase: Prevent updating mutable Date
by amureini＠redhat.com 13 Feb '13

13 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: TimeoutBase: Prevent updating mutable Date ...................................................................... core: TimeoutBase: Prevent updating mutable Date TimeoutBase contains a java.util.Date member, mEndTime. The value of this member can be passed into (by setEndTime(Date)) and out of (by getEndTime()) the class. Since java.util.Date is a mutable class, the end time of the TimeoutBase may be manipulated, maliciously or mistakenly, by someone holding a reference to that object. This patch removes this vulnerability by replacing this member by a simple primitive long, representing the unix time (System.currTimeMillis()), since the Date semantics (e.g., DST) isn't used anyway. Change-Id: Icd77e518369fa25bfe684d249d12e0f8e2bb1a0f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBaseTest.java 3 files changed, 12 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd77e518369fa25bfe684d249d12e0f8e2bb1a0f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: validation for "Use Host CPU" setting
by lhornyak＠redhat.com 13 Feb '13

13 Feb '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: webadmin: validation for "Use Host CPU" setting ...................................................................... webadmin: validation for "Use Host CPU" setting To enable CPU Host, one of the two no-migrate flags for a VM (run on selected host, or allow migration only upon admin request) must be enabled. If CPU Host was disabled along with the no-migrate flag in the same save action, the new CPU Host value was not propagated to the VM object which caused a validation error. This patch propagates the CPU Host value to the VM object, allowing the CPU Host flag and no-migrate flag to be disabled in the same edit. Change-Id: I786a725f6ff20e64d2d094b4c8c183c907978229 Bug-Url: https://bugzilla.redhat.com/905843 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I786a725f6ff20e64d2d094b4c8c183c907978229 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : Add Role with wrong permit id leads to 500 error(#...
by mpastern＠redhat.com 13 Feb '13

13 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Add Role with wrong permit id leads to 500 error(#908392) ...................................................................... restapi : Add Role with wrong permit id leads to 500 error(#908392) Add Role with wrong permit id leads to internal server error. This patch returns a proper error message when the permit id is invalid. Change-Id: I9adfda37e67d24f96933aa4eb8f79a8fdb416d62 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908392 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendRolesResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java 2 files changed, 30 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/11931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9adfda37e67d24f96933aa4eb8f79a8fdb416d62 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing harmfull code from persitance of task to DB
by mkublin＠redhat.com 13 Feb '13

13 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing harmfull code from persitance of task to DB ...................................................................... engine: Removing harmfull code from persitance of task to DB The following code which is removed is useless, because of json serializer will not serialize parentParameters because of it is transient, but during setting them to null we can create a race which will destroy a correct value, in case if command triggered couple parallel tasks Change-Id: Ib64fd00c207eaab51585dca5634cfb15f3b83820 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib64fd00c207eaab51585dca5634cfb15f3b83820 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added infrastructure for providing a canDoactions in...
by mkublin＠redhat.com 13 Feb '13

13 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Added infrastructure for providing a canDoactions in case of locks ...................................................................... engine: Added infrastructure for providing a canDoactions in case of locks The following patch is introducing an infrastracture for providing a more convinient messages in case of using lock util. What is done: from now it is possible to pass appropriate message for every acquired lock. What is not done: I did not change a generic message, so it still will be VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED, but I provide an easy way to change it Change-Id: I87698da36ddb6e7556e98612d299da68f2eb53dc Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LockMessagesMatchUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ForceRemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lock/InMemoryLockManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/EngineLock.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/LockManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 48 files changed, 359 insertions(+), 229 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87698da36ddb6e7556e98612d299da68f2eb53dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0