- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fix message in importing template dialog
by alkaplan＠redhat.com 12 Feb '13

12 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fix message in importing template dialog ...................................................................... webadmin: fix message in importing template dialog This patch modify the message presented in the dialog that is being shown when importing template, such that it won't say that the import status is shown in the events tab of the specific destination storage domain, as it's not true and it's not trivial to implement because there can be multiple destination storage domains (can be different for each disk) Change-Id: I6565428cb6235f2423f155b39e5634c7e5faf28a Bug-Url: https://bugzilla.redhat.com/886436 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6565428cb6235f2423f155b39e5634c7e5faf28a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Logging configuration for dal tests
by amureini＠redhat.com 12 Feb '13

12 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Logging configuration for dal tests ...................................................................... core: Logging configuration for dal tests A simple initial log4j configuration file for the dal tests. This configuration solves most of the "noise" that's printed to the screen during these tests. Change-Id: I1862bd1aa4a936fceaf79f5419e8b4ae079cd601 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/modules/dal/src/test/resources/log4j.xml 1 file changed, 79 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1862bd1aa4a936fceaf79f5419e8b4ae079cd601 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: 'No No Alerts' shown in 0 alerts + cleanup
by gchaplik＠redhat.com 12 Feb '13

12 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: 'No No Alerts' shown in 0 alerts + cleanup ...................................................................... webadmin: 'No No Alerts' shown in 0 alerts + cleanup AlertListModel updates wrongfully its title. did a little bit of clean-up, since the fix there is no longer need for some of the items, and the rest items are very old. Change-Id: I0b4b4502e949343c10ae3cc3abef337b4c8378df Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/AlertListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 3 files changed, 6 insertions(+), 217 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b4b4502e949343c10ae3cc3abef337b4c8378df Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix build break in VdsStaticDAODbFacadeImpl
by gchaplik＠redhat.com 12 Feb '13

12 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix build break in VdsStaticDAODbFacadeImpl ...................................................................... core: Fix build break in VdsStaticDAODbFacadeImpl Patch I56a7b0d3237029e91e7b0cb4bbff18b64e729d9e introduced a call to a wrong field (wrong capatilization in the property name). This patch fixes the build break. Change-Id: Ice2de210d62fb3474133cb45fed75aa22e6ea53c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/11970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice2de210d62fb3474133cb45fed75aa22e6ea53c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix typo in ExistingPoolNameLengthValidationTest
by derez＠redhat.com 12 Feb '13

12 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix typo in ExistingPoolNameLengthValidationTest ...................................................................... webadmin: fix typo in ExistingPoolNameLengthValidationTest The method getPoolName_noVmsAlloved was renamed to getPoolName_noVmsAllowed Change-Id: Ie693aadb492502966dcfcaedbba29388b5978994 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/ExistingPoolNameLengthValidationTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie693aadb492502966dcfcaedbba29388b5978994 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in samples-uiplugins[master]: Shell-In-A-Box plugin: refactoring and renaming
by derez＠redhat.com 12 Feb '13

12 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: Shell-In-A-Box plugin: refactoring and renaming ...................................................................... Shell-In-A-Box plugin: refactoring and renaming * Using 'hostname' property instead of 'name'. * Refactoring 'getShellInABoxUrl' method signature to get the selected host. * Renaming all occurrences of 'Shell Box' to 'Shell In A Box'. * Removing 'isAccessible' method. Change-Id: Id24155f0480e0af5497c2b74eee203dfdf60e3f8 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- D shellbox-plugin/shellbox-files/start.html D shellbox-plugin/shellbox.json R shellinabox-plugin/README A shellinabox-plugin/shellinabox-files/start.html A shellinabox-plugin/shellinabox.json 5 files changed, 53 insertions(+), 57 deletions(-) Approvals: Daniel Erez: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id24155f0480e0af5497c2b74eee203dfdf60e3f8 Gerrit-PatchSet: 1 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: UI-Plugins - VM IP address mapping
by derez＠redhat.com 12 Feb '13

12 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: UI-Plugins - VM IP address mapping ...................................................................... webadmin: UI-Plugins - VM IP address mapping Add mapping to VM IP address, EntityObject: Map 'getVmIp' to 'ipaddress' property (IP Address column). Change-Id: I24b1208031d454d1774a43ddb0cccd7a85f23d2e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24b1208031d454d1774a43ddb0cccd7a85f23d2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: UI-Plugins - fix host name mapping
by derez＠redhat.com 12 Feb '13

12 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: UI-Plugins - fix host name mapping ...................................................................... webadmin: UI-Plugins - fix host name mapping EntityObject: * Map 'getvds_name' to 'name' property (Name column). * Map 'gethost_name' to 'hostname' property (Hostname/IP column). Change-Id: Id947436ccdf2a5654ca6852f6e57af143dad8b21 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id947436ccdf2a5654ca6852f6e57af143dad8b21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : version values for hosts are wrong for libvirt
by yzaslavs＠redhat.com 12 Feb '13

12 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: restapi : version values for hosts are wrong for libvirt ...................................................................... restapi : version values for hosts are wrong for libvirt When a new host is added to engine and the status is either installing for rebooting the libvirt version is unknown and is reported as -1. This patch supresses the libvirt version from /api/hosts if the version is unknown. Change-Id: I0c0525b6bb8c90d2ce4e10ac4f5c26f1a1b1e6b0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=904935 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c0525b6bb8c90d2ce4e10ac4f5c26f1a1b1e6b0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:[Power Management]: Unable to edit power...
by emesika＠redhat.com 12 Feb '13

12 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core:[Power Management]: Unable to edit power... ...................................................................... core:[Power Management]: Unable to edit power... [Power Management]: Unable to edit power management fields, engine mistakenly thinks that host is operational. Fixing a typo in the vmSatatic getPmSEcondaryUser name (was getPmSEcondaryuser) This typo caused the validation to fail when the PM secondary User field was changed. Change-Id: If4b1bc4f84bab665e045505d7e31e983db4b7bc6 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908351 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 5 files changed, 7 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4b1bc4f84bab665e045505d7e31e983db4b7bc6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0