- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Singleton row mapper for Bookmarks
by amureini＠redhat.com 12 Feb '13

12 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for Bookmarks ...................................................................... core: Singleton row mapper for Bookmarks Added a singleton row mapper for BookmarkDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I3eccfb32acd4c2e335a385b9440e22c118ec68d5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDAODbFacadeImpl.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eccfb32acd4c2e335a385b9440e22c118ec68d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: notifier - add aditional validation
by dfediuck＠redhat.com 12 Feb '13

12 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: tools: notifier - add aditional validation ...................................................................... tools: notifier - add aditional validation Check for valid email (simple @ validation) Check for valid port number (1-65536) Check for true or false in HTML_MESSAGE_FORMAT Change-Id: Id97cb5bd1903991717e653cf2ca4ca16f362f8e6 Bug-Url: https://bugzilla.redhat.com/883417 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Noam Slomianko: Verified -- To view, visit http://gerrit.ovirt.org/11549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id97cb5bd1903991717e653cf2ca4ca16f362f8e6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: notifier - add validation to mail type properties
by dfediuck＠redhat.com 12 Feb '13

12 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: tools: notifier - add validation to mail type properties ...................................................................... tools: notifier - add validation to mail type properties Creating smtp requests with FROM/USER properties set to values not in the format user@domain will fail, so we now enforce it the the bash script *?@?* means that there must be a @ with at least one char on each side Change-Id: I652d6b7aa9ca34192d6892174bf57b11335cb98a Bug-Url: https://bugzilla.redhat.com/885436 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I652d6b7aa9ca34192d6892174bf57b11335cb98a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: engine-notifier accept special chars
by dfediuck＠redhat.com 12 Feb '13

12 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: tools: engine-notifier accept special chars ...................................................................... tools: engine-notifier accept special chars Due to the way configuration was loaded in the bash script special characters would create some unwanted behaviors. Now the configuration file is read and the variables are added using "declare" statement It is expected that the config file is of the form key=value Change-Id: I5e6419a225bd02edaf1db38a2025dee74761ddf2 Bug-Url: https://bugzilla.redhat.com/883301 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e6419a225bd02edaf1db38a2025dee74761ddf2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix problem with changing host cluster
by tnisan＠redhat.com 12 Feb '13

12 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix problem with changing host cluster ...................................................................... core: Fix problem with changing host cluster The VDS entity vds_group_id property was changed to vdsGroupId, in the canDo action of ChangeVDSCluster the field change validation was hard coded to the old property name thus failing on host cluster change even if the host is in maintenance state, changed the check to use the new field name Change-Id: Ia5789c931e69bc2ed5f7840d8503dcf843a102ed Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5789c931e69bc2ed5f7840d8503dcf843a102ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change storage dialog styles to fit to size with F...
by derez＠redhat.com 12 Feb '13

12 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Change storage dialog styles to fit to size with French local ...................................................................... webadmin: Change storage dialog styles to fit to size with French local When using webadmin localized to French the storage dialog exceeded it's size and an inner scroll bar appeared, styles were adjusted to make the elements fit the size in French locale Change-Id: Ia4b77224d4a9a4ab9f3da8428dbf743da48b53ac Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4b77224d4a9a4ab9f3da8428dbf743da48b53ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Add task cleaner utility to ovirt-engine-setup rp...
by juan.hernandez＠redhat.com 12 Feb '13

12 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Add task cleaner utility to ovirt-engine-setup rpm ...................................................................... packaging: Add task cleaner utility to ovirt-engine-setup rpm Add the task cleaner utility to ovirt-engine-setup rpm. In this way, the utility will always be avaialble for engine-upgrade. Change-Id: I854768c529965043bebee4a3c2e43dc674418216 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M Makefile M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/spec/ovirt-engine.spec.in 4 files changed, 11 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I854768c529965043bebee4a3c2e43dc674418216 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Non admin user have access to /hosts url (#909692)
by yzaslavs＠redhat.com 12 Feb '13

12 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: restapi : Non admin user have access to /hosts url (#909692) ...................................................................... restapi : Non admin user have access to /hosts url (#909692) Non admin users should not be able to see hosts using /api/hosts Change-Id: I496a9560d462156944c3aa23b61d2b6d587d1700 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=909692 Signed-off-by: Ravi Nori <rnori(a)redhat.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsByVdsIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsByVdsIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 4 files changed, 6 insertions(+), 10 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I496a9560d462156944c3aa23b61d2b6d587d1700 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disable revomal of plugged vnic on a running vm
by alkaplan＠redhat.com 12 Feb '13

12 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Disable revomal of plugged vnic on a running vm ...................................................................... webadmin: Disable revomal of plugged vnic on a running vm On Networks->Virtual Machines the remove action should be disabled if the vm is running and the vnic is plugged. Also, it should be disabled in all the vm states that are not UP or DOWN. Virtual Machines->Network interfaces already works correctly. Also a little code fix- there is no need to check the HotPlugEnabled property when deciding if the user can remove the vnic. It is enough to make sure the vnic is unplugged. If HotPlug is not enabled the vnic is always plugged. Change-Id: I795096615e8ef5118cceb56155aa6806af736ebb Bug-Url: https://bugzilla.redhat.com/910021 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 2 files changed, 14 insertions(+), 15 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I795096615e8ef5118cceb56155aa6806af736ebb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix message in importing VM dialog
by alkaplan＠redhat.com 12 Feb '13

12 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fix message in importing VM dialog ...................................................................... webadmin: fix message in importing VM dialog This patch modify the message presented in the dialog that is being shown when importing VM, such that it won't say that the import status is shown in the events tab of the specific destination storage domain, as it's not true and it's not trivial to implement because there can be multiple destination storage domains (can be different for each disk) Change-Id: I5f000933abd0802bb6cbc715cffd30d9fde42e41 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f000933abd0802bb6cbc715cffd30d9fde42e41 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0