- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: changed override-firewall in firewall-manager
by juan.hernandez＠redhat.com 12 Feb '13

12 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: changed override-firewall in firewall-manager ...................................................................... packaging: changed override-firewall in firewall-manager In engine-setup, changed the option override-firewall that the user may expect to be boolean into firewall-manager that accept "None", "Firewalld" or "IPtables" as values. Updated the output messages explaining the meaning of None as firewall manager. Change-Id: Ib5d92079a7caa301de248e90740e77fa5577b068 Bug-Url: https://bugzilla.redhat.com/901987 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/output_messages.py 2 files changed, 14 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5d92079a7caa301de248e90740e77fa5577b068 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: RemoveVmInterface CanDoAction Message
by masayag＠redhat.com 12 Feb '13

12 Feb '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: RemoveVmInterface CanDoAction Message ...................................................................... engine: RemoveVmInterface CanDoAction Message This patch adds a message for when user tries to remove a VmNetworkInterface that is plugged to a running VM. Change-Id: I0976cedbbd25301293d70cddfc99c36b7cf95923 Bug-Url: https://bugzilla.redhat.com/906405 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 12 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified Alona Kaplan: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0976cedbbd25301293d70cddfc99c36b7cf95923 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: added storage domain status to 3.2 views
by ydary＠redhat.com 12 Feb '13

12 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: history: added storage domain status to 3.2 views ...................................................................... history: added storage domain status to 3.2 views Change-Id: Ib25d5d8baf093dc6393c502eca862cec41e887a4 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/create_views_3_0.sql M data-warehouse/historydbscripts_postgres/create_views_3_1.sql M data-warehouse/historydbscripts_postgres/create_views_3_2.sql 3 files changed, 42 insertions(+), 30 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib25d5d8baf093dc6393c502eca862cec41e887a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Warning about last domain deletion should be prior to...
by yzaslavs＠redhat.com 12 Feb '13

12 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Warning about last domain deletion should be prior to confirmation ...................................................................... tools: Warning about last domain deletion should be prior to confirmation The following patch moves the warning print aobut last domain erasure prior to the confirmation question. In case of forceDelete option is used - this warning is not presented. Bug-Url: https://bugzilla.redhat.com/905370 Change-Id: Id91bd35ad832a4c8b8947c0e86bc0679cef3fa7b Signed-off-by: Yair Zaslavsky<yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id91bd35ad832a4c8b8947c0e86bc0679cef3fa7b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixing a broken view
by emesika＠redhat.com 11 Feb '13

11 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing a broken view ...................................................................... core: fixing a broken view this patch fixes a broken view resulted from changes of the following commit : 5ca1ec0337d921f1057321da2688ad2a014b8ff A comma separator was missing between view fields. Change-Id: Id022f7f82b69e2af98713b2767a4dc1edf096a8e Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id022f7f82b69e2af98713b2767a4dc1edf096a8e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, restapi, webadmin: Added description field to storage do...
by tnisan＠redhat.com 11 Feb '13

11 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core,restapi,webadmin: Added description field to storage domain ...................................................................... core,restapi,webadmin: Added description field to storage domain Added a description field to the storage domain entity, changes also made to the webadmin and REST to reflect this change Change-Id: I86bcd7c52e5d9cad7c3cb30561718203537ab459 Bug-Url: https://bugzilla.redhat.com/614859 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/storages_sp.sql A backend/manager/dbscripts/upgrade/03_02_0430_add_storage_static_description_column.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByImageIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 24 files changed, 167 insertions(+), 38 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86bcd7c52e5d9cad7c3cb30561718203537ab459 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: free space indication for storage domains
by derez＠redhat.com 11 Feb '13

11 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: free space indication for storage domains ...................................................................... webadmin: free space indication for storage domains Added free space indication in storage domains in select-boxes. Affected dialogs: * New disk * Copy/Move Disk * New VM -> Resource Allocation tab * Make template * Import VM Change-Id: I64cf597289534bb12019b09d1d84ad9e64f5b34e Bug-Url: https://bugzilla.redhat.com/760666 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/StorageDomainFreeSpaceRenderer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 5 files changed, 34 insertions(+), 28 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64cf597289534bb12019b09d1d84ad9e64f5b34e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: VMs main-tab - create snapshot action
by derez＠redhat.com 11 Feb '13

11 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: VMs main-tab - create snapshot action ...................................................................... webadmin: VMs main-tab - create snapshot action Adding 'Create Snapshot' action on VMs main-tab (into action-panel and as a context-menu button). Change-Id: I555695fd0239d966268bc245bd7e7574d6a34f30 Bug-Url: https://bugzilla.redhat.com/909930 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 10 files changed, 273 insertions(+), 81 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I555695fd0239d966268bc245bd7e7574d6a34f30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: upgrade issue
by yzaslavs＠redhat.com 11 Feb '13

11 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: upgrade issue ...................................................................... core: upgrade issue Patch addresses the following problem taskcleaner needs dbfunctions and dbcustomfunctions taskcleaner and dbfunctions*.sh are in dbscripts rpm, which is locked, and downloaded only AFTER we clean the tasks during upgrade. The ONLY viable option is to separate taskcleaner and its SP installing from dbscripts, and move it into the setup rpm, in that way, it will be always available. In order to do so, we need to do the following: 1. Make taskcleaner a standalone script (e.g, remove the dependency on dbfunctions) 2. Move it outside of dbscripts folder (to tools/dbutils) 3. Alter the rpm spec file to include the standalone taskcleaner in rhevm-setup rpm, and deploy it outside of dbscripts. (will be done in a separate patch) Change-Id: I82e9ccd3f621f1b524d4f7ed587fe9f266ffa8de Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=909097 --- R backend/manager/tools/dbutils/taskcleaner.sh R backend/manager/tools/dbutils/taskcleaner_sp.sql 2 files changed, 11 insertions(+), 6 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82e9ccd3f621f1b524d4f7ed587fe9f266ffa8de Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : attach storage domain should attempt to activate
by tnisan＠redhat.com 11 Feb '13

11 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core : attach storage domain should attempt to activate ...................................................................... core : attach storage domain should attempt to activate When attaching storage domain to pool, attempt to activate it after attaching. Change-Id: I4e6f21b350520aef47be0ba282a3074a3b3c5119 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e6f21b350520aef47be0ba282a3074a3b3c5119 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0