- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fix import gluster hosts popup layout
by gchaplik＠redhat.com 11 Feb '13

11 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix import gluster hosts popup layout ...................................................................... webadmin: Fix import gluster hosts popup layout When the hostname is too big, the table width goes outside of the popup. This is fixed now. Change-Id: I2d069b3227d2a504d339105d658890bd742924f7 Bug-Url: https://bugzilla.redhat.com/881856 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/MultipleHostsPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d069b3227d2a504d339105d658890bd742924f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Hide host virt details in gluster mode
by gchaplik＠redhat.com 11 Feb '13

11 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Hide host virt details in gluster mode ...................................................................... webadmin: Hide host virt details in gluster mode When the application is running in gluster only mode, Virtulization related details of the host will be hidden. Change-Id: I94612b97ce8709ece57f191b57e5e185ee3e7d32 Bug-Url: https://bugzilla.redhat.com/907326 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94612b97ce8709ece57f191b57e5e185ee3e7d32 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Hide Storage tab in gluster cluster
by gchaplik＠redhat.com 11 Feb '13

11 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Hide Storage tab in gluster cluster ...................................................................... webadmin: Hide Storage tab in gluster cluster When a gluster only cluster is selected in the System tree the Storage tab will be hidden. Change-Id: Iae50b6a4769bd66261f4ac22f685bdc2a72cf2f6 Bug-Url: https://bugzilla.redhat.com/882095 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae50b6a4769bd66261f4ac22f685bdc2a72cf2f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix remove bricks error message
by gchaplik＠redhat.com 11 Feb '13

11 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix remove bricks error message ...................................................................... webadmin: Fix remove bricks error message Changed the hash name to not to append the default remove message template. Fixed the typos. Bug-Url: https://bugzilla.redhat.com/905873 Bug-Url: https://bugzilla.redhat.com/905881 Change-Id: Ie4923746fbc9487eab47b7b1b3d995637641e777 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4923746fbc9487eab47b7b1b3d995637641e777 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Changed DateFormatCompat class in uioverrides to D...
by tnisan＠redhat.com 10 Feb '13

10 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Changed DateFormatCompat class in uioverrides to DateFormat ...................................................................... webadmin: Changed DateFormatCompat class in uioverrides to DateFormat Changed the DateFormatCompat class in uioverride to java.text.DateFormat this class takes the date format types in DateFormat anyway and the equivalent class DateFormatCompat in the compat module was removed so no point in keeping the old class name Change-Id: I345a36a2512f8240e739a6c190aaa5f0cf020940 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- R frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/text/DateFormat.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/searchbackend/DateUtils.java 2 files changed, 9 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I345a36a2512f8240e739a6c190aaa5f0cf020940 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove user_sessions table
by amureini＠redhat.com 10 Feb '13

10 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove user_sessions table ...................................................................... core: Remove user_sessions table The user_sessions table is part of the old login/logout mechanism, which is no longer in use. Before this patch, the table still existed, as well as code that queries it and deletes from it, but no occurrences of inserting or updating it, which means it was effectively useless. This patch drops it from the database, and removes any remnants of code that still reference it, including the session_count column of the users table (and the corresponding members of the DbUser class). Change-Id: I46952752950dcfeb4f917d532b80f15df7ff19c6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0420_remove_user_session.sql M backend/manager/dbscripts/user_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/session/SessionDataContainerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/user_sessions.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/user_sessions_id.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 12 files changed, 18 insertions(+), 647 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46952752950dcfeb4f917d532b80f15df7ff19c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix typos in method names, log and comments
by tnisan＠redhat.com 10 Feb '13

10 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix typos in method names,log and comments ...................................................................... core: Fix typos in method names,log and comments Fix typos in method names (and the places which use those methods), comments and log statements in several commands. Change-Id: I2dce88f1ef0ab7ce3b57dce14142e08ce838c70d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java 13 files changed, 26 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dce88f1ef0ab7ce3b57dce14142e08ce838c70d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding exclusive lock (by name) to ImportVmCommand
by yzaslavs＠redhat.com 10 Feb '13

10 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adding exclusive lock (by name) to ImportVmCommand ...................................................................... core: Adding exclusive lock (by name) to ImportVmCommand In order to solve the above bug, an exclusive lock by name is acquired. The lock is removed after a vm is added to the DB. Change-Id: I298f7f277a2000537f0edcdd0fcfd8aedd8037d1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=907132 signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I298f7f277a2000537f0edcdd0fcfd8aedd8037d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed the ResXResourceReader class
by tnisan＠redhat.com 10 Feb '13

10 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed the ResXResourceReader class ...................................................................... core: Removed the ResXResourceReader class Removed the class ResXResourceReader from the compat module, this class was used to load the audit log messages from the properties file, it was used only in AuditLogDirector, the logic in the class was improved and moved to a method inside AuditLogDirector Change-Id: If60caa71d0b66d79279409ca534a419b89dcba75 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/ResXResourceReader.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 2 files changed, 626 insertions(+), 650 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If60caa71d0b66d79279409ca534a419b89dcba75 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove DateFormatCompat class and its usages
by tnisan＠redhat.com 10 Feb '13

10 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove DateFormatCompat class and its usages ...................................................................... core: Remove DateFormatCompat class and its usages Change-Id: Ibd6bd390367af4ac4946b036d670844e50c91f37 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateFormatCompat.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java 2 files changed, 4 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd6bd390367af4ac4946b036d670844e50c91f37 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0