- Engine-commits - oVirt List Archives

Change in ovirt-engine[engine_3.2]: gluster: Modify calls to fnSplitterUuid
by sanjal＠redhat.com 10 Feb '13

10 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Modify calls to fnSplitterUuid ...................................................................... gluster: Modify calls to fnSplitterUuid Patch http://gerrit.ovirt.org/9825 changed the definition of the SP fnSplitterUuid in such a way that the older calls to this SP, that looked like: select ID from fnSplitterUuid(v_ids) no longer work, and now need to be changed to something like: select * from fnSplitterUuid(v_ids) While this change was done in most of the *_sp.sql scripts, it was missed out in gluster_volumes_sp.sql Changing it now in gluster_volumes_sp.sql Change-Id: I824aedc908cfc0a67ea2fa5ea57dd14eecb865ce Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=901531 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/dbscripts/gluster_volumes_sp.sql 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I824aedc908cfc0a67ea2fa5ea57dd14eecb865ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use storage helper to fetch (related to BZ882825)
by mlipchuk＠redhat.com 10 Feb '13

10 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage helper to fetch (related to BZ882825) ...................................................................... core: Use storage helper to fetch (related to BZ882825) Added engine support for connecting LUN with multiple connections of different storage types. Change-Id: Ida526dd9e08bc9881e65a529cb1b00aee0786af1 Related-to: https://bugzilla.redhat.com/882825 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHelperBaseTest.java 3 files changed, 126 insertions(+), 8 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida526dd9e08bc9881e65a529cb1b00aee0786af1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix edit cluster policy for new cluster
by alkaplan＠redhat.com 10 Feb '13

10 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fix edit cluster policy for new cluster ...................................................................... webadmin: Fix edit cluster policy for new cluster When Creating a new cluster the cluster policy data was not saved because of different view initialization process. Added a bounding between the clusterPolicyModel in the view and ClusterModel (which was missing in the 'New Cluster' flow). Change-Id: I305a71e888e72e35cd40dd1055b6ad22d6111678 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I305a71e888e72e35cd40dd1055b6ad22d6111678 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: change VdsRefreshTimeout to 3 seconds
by emesika＠redhat.com 10 Feb '13

10 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core: change VdsRefreshTimeout to 3 seconds ...................................................................... core: change VdsRefreshTimeout to 3 seconds The current value of 2 seconds is a bit low. The UI refreshes every 5 seconds. It was agreed to increase this value in order to reduce CPU load. Change-Id: Id84c8b8bbc939559ff8be4f86b8adbe1ed6f450c Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908745 --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id84c8b8bbc939559ff8be4f86b8adbe1ed6f450c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change PM delay for Start/Stop operations
by emesika＠redhat.com 10 Feb '13

10 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Change PM delay for Start/Stop operations ...................................................................... core: Change PM delay for Start/Stop operations currently when a Start/Stop operation is invoked, the default number of retries is 3 while the delay between retries is 60 sec. That means that if when we initially check the status after a Start/Stop operation it does not reach on/off status we will have to wait 60 seconds to sample the status again A shorter delay of 10 seconds while keeping the total default waiting time untouched (means modifying default number of retries to 18 will improve user experience in PM operations Default config values were changed to: FenceStartStatusDelayBetweenRetriesInSec=10 FenceStartStatusRetries=18 FenceStopStatusDelayBetweenRetriesInSec=10 FenceStopStatusRetries=18 Since those values are not exposed to engine-config, we can simply override the installed value. Change-Id: I876d98013e2c3874680660940f78b8f14778fa92 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908778 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I876d98013e2c3874680660940f78b8f14778fa92 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replace NetworkDaoDbFacadeImpl.getByName()
by mkolesni＠redhat.com 10 Feb '13

10 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Replace NetworkDaoDbFacadeImpl.getByName() ...................................................................... engine: Replace NetworkDaoDbFacadeImpl.getByName() Old call was using an archaic API, replace by the standard way to run JDBCTemplate queries. Change-Id: I18ced945229f34ce6a042ae6f46970e6b2b0f395 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java 1 file changed, 3 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18ced945229f34ce6a042ae6f46970e6b2b0f395 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: engine: Add management network validation
by mkolesni＠redhat.com 10 Feb '13

10 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add management network validation ...................................................................... engine: Add management network validation This check will make sure that if we're attaching or editing a management network's attachment on a cluster, then the attachment will be properly validated (i.e. the network must be required). Change-Id: I1e035f009796f989072601cc67a51fd8bbd6947b Bug-Url: https://bugzilla.redhat.com/875488 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java 2 files changed, 22 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e035f009796f989072601cc67a51fd8bbd6947b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add validator for NetworkCluster
by mkolesni＠redhat.com 10 Feb '13

10 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add validator for NetworkCluster ...................................................................... engine: Add validator for NetworkCluster This validator will hold checks that are necessary to perform on this entity, such as making sure the management network attachment is valid. Change-Id: Iba58dfbd9950176ba26790ff6a50244d554fd9b3 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 74 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba58dfbd9950176ba26790ff6a50244d554fd9b3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added management network check
by mkolesni＠redhat.com 10 Feb '13

10 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Added management network check ...................................................................... engine: Added management network check Added a method for determining if a network is a management network. Change-Id: I27844da800326e338ec193b4ffd1fb2ee6aef034 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommandTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java 3 files changed, 57 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27844da800326e338ec193b4ffd1fb2ee6aef034 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix ValidationResult
by mkolesni＠redhat.com 10 Feb '13

10 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Fix ValidationResult ...................................................................... engine: Fix ValidationResult 1. Changed equals not to use instanceof since the class is final. 2. Added variable replacements to the TSEHC (toString/equals/hashCode) methods since it's part of the object's identity. Change-Id: I6faefd9926c241055fc4957ce3c639308ef5833f Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java 3 files changed, 24 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11834 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6faefd9926c241055fc4957ce3c639308ef5833f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0