- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: [RFE] Display of both the console user and the guest u...
by ofrenkel＠redhat.com 26 Dec '12

26 Dec '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: [RFE] Display of both the console user and the guest user ...................................................................... core: [RFE] Display of both the console user and the guest user In 3.0 we displayed the guest logged-in user in the engine. In 3.1 we display the console user instead. This patch makes the engine to display both of these values. - removed guest_user_id column from vm_dynamic table (it is not used) and corresponding field in entities (VM, VmDynamic) - added new column console_cur_user_name and a corresponding field in the entities (VM, VmDynamic) - NOTE: the semantics of existing guest_cur_user_name of VmDynamic is changed to its original state (as in 3.0 - the value is reported by GA), the console user name will be tracked in the console_cur_user_name, which makes more sense - removed VmLogoffCommand which has not been used - added new command UpdateVmConsoleDataCommand Vm console data - vdsbroker package - changed behavior so that guest logged-in user information is not discarded Change-Id: Icd5b178402b32435ceb79120ea1e411f0cc83606 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879586 --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_02_0150_add_console_cur_user_name.sql A backend/manager/dbscripts/upgrade/03_02_0160_drop_guest_user_id_column.sql M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmConsoleDataCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogoffCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmConsoleDataParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/UpdateVmDynamicDataVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 20 files changed, 132 insertions(+), 132 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd5b178402b32435ceb79120ea1e411f0cc83606 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove "all" filter from Network Host sub tab
by alkaplan＠redhat.com 26 Dec '12

26 Dec '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: remove "all" filter from Network Host sub tab ...................................................................... webadmin: remove "all" filter from Network Host sub tab The all radio button in the Network Host sub tab is useless. If the user wants to see all the hosts in the cluster he can go to hosts main tab. This patch removes "all" radio button from the view. Change-Id: I1cfb2f570c5c485da8f9d78f57e2484534934e11 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostFilter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java 4 files changed, 4 insertions(+), 15 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cfb2f570c5c485da8f9d78f57e2484534934e11 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add filters to NetworkVm sub tab- running, not run...
by alkaplan＠redhat.com 26 Dec '12

26 Dec '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add filters to NetworkVm sub tab- running, not running. ...................................................................... webadmin: Add filters to NetworkVm sub tab- running, not running. In this patch a radio button group is added to filter the vms. - running- all the running vm's the network is attached to one of their vnics. - not running- all the not running vm's the networks is attached to one of their vnics. Change-Id: Icb728293bfa1b6d8b50933ffc971de30ce2a5af9 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmFilter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java 4 files changed, 182 insertions(+), 77 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb728293bfa1b6d8b50933ffc971de30ce2a5af9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: grant admin@internal powerUserRole on SYSTEM
by ofrenkel＠redhat.com 26 Dec '12

26 Dec '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: grant admin@internal powerUserRole on SYSTEM ...................................................................... core: grant admin@internal powerUserRole on SYSTEM This fix will let admin@internal use the user portal as power-user. Super users don't have rights to use the user portal and there is no change in that behaviour. Change-Id: Ib0b51c03b27ad8f9ab0c34c43503b035267ad540 Bug-Url: https://bugzilla.redhat.com/887282 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0150_add_admin_internal_user_role_system.sql 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0b51c03b27ad8f9ab0c34c43503b035267ad540 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: rewrote nic's addresses functions in python 2.4 synta...
by bazulay＠redhat.com 26 Dec '12

26 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: agent: rewrote nic's addresses functions in python 2.4 syntax. ...................................................................... agent: rewrote nic's addresses functions in python 2.4 syntax. Change-Id: I17c6fb0dc2ac818677155444442f4a004f8463ec Signed-off-by: Gal Hammer <ghammer(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Barak Azulay: Looks good to me, approved Gal Hammer: Verified -- To view, visit http://gerrit.ovirt.org/10378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17c6fb0dc2ac818677155444442f4a004f8463ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix NPE when adding vm with no cpu mode
by mpastern＠redhat.com 26 Dec '12

26 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix NPE when adding vm with no cpu mode ...................................................................... restapi: fix NPE when adding vm with no cpu mode A check whether the lately added attribute 'cpu mode' is defined (set) in a request before trying to map it to enum value was missing, thus creating a NPE. Change-Id: I94b2269a952e4dedcd08ee4b22940aeca020fb4c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94b2269a952e4dedcd08ee4b22940aeca020fb4c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing compensation of RemoveStoragePool
by yzaslavs＠redhat.com 25 Dec '12

25 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing compensation of RemoveStoragePool ...................................................................... core: Fixing compensation of RemoveStoragePool The following patch takes advantage of the on delete cascacade defined for storage_pool_iso_map table on storage_pools and removes the explicity call to remove the stoage pool iso map entry. Bug-Url: https://bugzilla.redhat.com/889209 Change-Id: I09d8322c87bd4981c232fa8217532a541e24cc63 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09d8322c87bd4981c232fa8217532a541e24cc63 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: updated change-log for version 1.0.7
by bazulay＠redhat.com 25 Dec '12

25 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: updated change-log for version 1.0.7 ...................................................................... updated change-log for version 1.0.7 Change-Id: I8439b85ca0b479455dc7b03ff25ceccd04594f60 Signed-off-by: Gal Hammer <ghammer(a)redhat.com> --- M configure.ac M ovirt-guest-agent.spec 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Barak Azulay: Looks good to me, approved Gal Hammer: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8439b85ca0b479455dc7b03ff25ceccd04594f60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup in VdsDeploy
by yzaslavs＠redhat.com 25 Dec '12

25 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: cleanup in VdsDeploy ...................................................................... core: cleanup in VdsDeploy Remove unused variable and code in VdsDeploy Change-Id: I09d8322c88bd4982c232fa8217532a541e24cc64 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09d8322c88bd4982c232fa8217532a541e24cc64 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webamin: hide cpuPin section according to config values
by gchaplik＠redhat.com 25 Dec '12

25 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webamin: hide cpuPin section according to config values ...................................................................... webamin: hide cpuPin section according to config values According to cpuPinningEnabled flag, and CpuPinMigrationEnabled flag in case of migration. Change-Id: Ifae4242379136d6dc580d1ee6c78757ff1e7e022 Bug-Url: https://bugzilla.redhat.com/867039 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 29 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifae4242379136d6dc580d1ee6c78757ff1e7e022 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0