- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine, webadmin: Add specific query parameters
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine, webadmin: Add specific query parameters ...................................................................... engine, webadmin: Add specific query parameters Added specific parameters for GetVmsAndNetworkInterfacesByNetworkId query. These parameters are needed to add support for filtering the result by VMs that are 'running' and not 'running'. Query call was modified to use these parameters and in the next patches the filtering will be added. Change-Id: Iddf5de505092dfc3081f8b6b52fc3b4f74c09412 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsAndNetworkInterfacesByNetworkIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmsAndNetworkInterfacesByNetworkIdQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsAndNetworkInterfacesByNetworkIdParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java 4 files changed, 33 insertions(+), 9 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddf5de505092dfc3081f8b6b52fc3b4f74c09412 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: Fixed support for reporting devices with only ipv6.
by bazulay＠redhat.com 24 Dec '12

24 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: Fixed support for reporting devices with only ipv6. ...................................................................... Fixed support for reporting devices with only ipv6. ethtool.get_active_devices does not consider as up the devices that have only an IPv6 address set. Also, it throws an IOError exception when doing get_ipaddr of a device that is up but does not have an IPv4 address set. Thus, doing the filtering by using the device flags and getting the IPv4 address in a similar way as how we get the IPv6 one, not only fixes the issue but increases the consistency of the code. Change-Id: I92010740da24bb30c7316c268c704d9067b28aae Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92010740da24bb30c7316c268c704d9067b28aae Gerrit-PatchSet: 5 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: Fix pep8 errors in the linux guest agent.
by bazulay＠redhat.com 24 Dec '12

24 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: Fix pep8 errors in the linux guest agent. ...................................................................... Fix pep8 errors in the linux guest agent. Cleanup of the code to bring it up to standards of the rest of ovirt. Change-Id: I7e8e12bdf42ef86d88a0d4d38750f2e1bc739e22 Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 54 insertions(+), 41 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e8e12bdf42ef86d88a0d4d38750f2e1bc739e22 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup RunVmCommand#statelessVmTreatment
by rgolan＠redhat.com 24 Dec '12

24 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: core: cleanup RunVmCommand#statelessVmTreatment ...................................................................... core: cleanup RunVmCommand#statelessVmTreatment - Remove unnecessary local field 'p' - Rename 'tmpVar' field to 'createAllSnapshotsFromVmParameters', so that the name will be more meaningful Change-Id: I967b4af546e14a00ac74764458b3cb2c3d946beb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 9 insertions(+), 10 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I967b4af546e14a00ac74764458b3cb2c3d946beb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: introduce InternalMigrateVmParameters
by rgolan＠redhat.com 24 Dec '12

24 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: core: introduce InternalMigrateVmParameters ...................................................................... core: introduce InternalMigrateVmParameters Introduce InternalMigrateVmParameters class that should be used when calling internal migrate command. It replaces MigrateVmParameters that was previously used, and was confusing as it let the caller set 'force migration' flag which isn't in use in internal migration operation. Change-Id: I6054e71c99ac8dfc2f281d835048af597a9742c0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmParameters.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java 3 files changed, 32 insertions(+), 10 deletions(-) Approvals: Roy Golan: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/10319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6054e71c99ac8dfc2f281d835048af597a9742c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Refactor InternalMigrateVmCommand#canMigrateVm
by rgolan＠redhat.com 24 Dec '12

24 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: core: Refactor InternalMigrateVmCommand#canMigrateVm ...................................................................... core: Refactor InternalMigrateVmCommand#canMigrateVm Change InternalMigrateVmCommand#canMigrateVm method such that: 1. The check whether the vm is migratable is being done before calling super.canMigrateVm. That way, the checks in MigrateVmCommand#canMigrateVm won't be made if the vm is not migratable, as they are irrelevant in that case. 2. Add a proper error in case InternalMigrateVmCommand fails because the VM is not migratable. Change-Id: Ida10d53ccd5321d3ccc510bd2111fa013dcdcdbe Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 19 insertions(+), 10 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida10d53ccd5321d3ccc510bd2111fa013dcdcdbe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: #839205 Display Host Hooks
by oliel＠redhat.com 24 Dec '12

24 Dec '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: #839205 Display Host Hooks ...................................................................... restapi: #839205 Display Host Hooks https://bugzilla.redhat.com/839205 Change-Id: I38a3d38cc52d5ec77f55fe7db4d5e47b09568ca7 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostHookResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostHooksResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 10 files changed, 366 insertions(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38a3d38cc52d5ec77f55fe7db4d5e47b09568ca7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: error when adding disks without specifying storage dom...
by mlipchuk＠redhat.com 24 Dec '12

24 Dec '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: error when adding disks without specifying storage domain ...................................................................... core: error when adding disks without specifying storage domain When adding a disk and no storage domain id is passed by the parameters, there is an attempt to get the storage domain id from the first vm disk - if this disk is a LUN disk, it won't have storage domain id and we won't be able to add the new image disk. Change-Id: Icc3fce53eaeca31b7b479019ba195b60e248c88e Bug-Url: https://bugzilla.redhat.com/876109 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 22 insertions(+), 9 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc3fce53eaeca31b7b479019ba195b60e248c88e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: history: changed minimal etl version to 3.2.0
by yzaslavs＠redhat.com 24 Dec '12

24 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: history: changed minimal etl version to 3.2.0 ...................................................................... history: changed minimal etl version to 3.2.0 Change-Id: Ic2e0ff9e34b77950c939e5fd380bc4d480b058f6 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2e0ff9e34b77950c939e5fd380bc4d480b058f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add event for MAC pool initialization error
by yzaslavs＠redhat.com 24 Dec '12

24 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Add event for MAC pool initialization error ...................................................................... core: Add event for MAC pool initialization error This patch performs two issues: a. Fixing inconsistency in handling MacPoolManager.freeMac (in some cases - the exception is caught and ignored, in some cases - not - this is behavior is incorrect). b. Introducing event to mark failure in mac pool initialization (similar to the event log of mac address already in use) Bug-Url: https://bugzilla.redhat.com/885441 Change-Id: Ibaa3d9eb23016b4866e5cfa39f919378e09fdf2d signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 16 insertions(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibaa3d9eb23016b4866e5cfa39f919378e09fdf2d Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0