- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add UserVmManager to VM PowerUsers on upgrade (#883365...
by oourfali＠redhat.com 18 Dec '12

18 Dec '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add UserVmManager to VM PowerUsers on upgrade (#883365) ...................................................................... core: Add UserVmManager to VM PowerUsers on upgrade (#883365) https://bugzilla.redhat.com/883365 Recently the PowerUser was changed to be a creator role. Thus, users with PowerUser on a VM can't run it, which doesn't make much sense. This upgrade script fixes that issue by adding a UserVmManager permission on such VMs to the user which had direct PowerUser on them. Change-Id: Id0d51bc27e9f6d5318744a73fbd1ed870cccf85d Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0080_add_user_vm_manager_to_vm_power_users.sql 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/10183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0d51bc27e9f6d5318744a73fbd1ed870cccf85d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: fix upgrade number due to duplicate
by amureini＠redhat.com 18 Dec '12

18 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: fix upgrade number due to duplicate ...................................................................... fix upgrade number due to duplicate Change-Id: I39f1831f919fb80fcc4e269aff4ea78715a6262e Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- R backend/manager/dbscripts/upgrade/03_02_0070_ha_vm_event_notifications.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39f1831f919fb80fcc4e269aff4ea78715a6262e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Upgrade PowerMock to 1.5
by mpastern＠redhat.com 18 Dec '12

18 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: core: Upgrade PowerMock to 1.5 ...................................................................... core: Upgrade PowerMock to 1.5 Upgraded PowerMock to 1.5 in order to support a future move to Java 7. This change is required since PowerMock 1.4.10 uses javassit 3.15.0-GA, which does not handle Java 7's byte-code properly. PowerMock 1.5 upgrades the dependency to javassit 3.17.1-GA, which can handle the new bytcode instructions. Change-Id: Ia3799efcc82e04b0a2aad7b2735f32ace7e10bb0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3799efcc82e04b0a2aad7b2735f32ace7e10bb0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core+ui: add HA events to notification service
by oourfali＠redhat.com 18 Dec '12

18 Dec '12

Oved Ourfali has submitted this change and it was merged. Change subject: core+ui: add HA events to notification service ...................................................................... core+ui: add HA events to notification service Previous patch introduced two new events to the HA VM. This patch adds them to the notification service. Change-Id: I0d378cd041bb7b47085acfadb706ff745228a161 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0060_ha_vm_event_notifications.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 12 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d378cd041bb7b47085acfadb706ff745228a161 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Changed "Host" to "Server"
by ofrenkel＠redhat.com 18 Dec '12

18 Dec '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Changed "Host" to "Server" ...................................................................... engine: Changed "Host" to "Server" Changed existing "Host" to "Server" in Add Gluster Server related sources, since server is more appropriate in gluster context. Updated the event_map table value Host to Server by introducing upgrade script. Change-Id: Ia37048f232b40387f6871050926df6815280fe1e Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0060_change_host_to_server_event_map.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/AddGlusterServerVDSParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHostAddVDSParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AddGlusterServerVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHostAddVDSCommand.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 15 files changed, 69 insertions(+), 64 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/9821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia37048f232b40387f6871050926df6815280fe1e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: correlation ID should not be localized
by ecohen＠redhat.com 17 Dec '12

17 Dec '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: correlation ID should not be localized ...................................................................... webadmin: correlation ID should not be localized When using non-English localization, 'Configure Local Storage' throws VALIDATION_INVALID_CORRELATION_ID error. Therefore, disabled correlationId non-mandatory localization. Change-Id: If09925567472fb546b62942c1c51d36b49a62289 Bug-Url: https://bugzilla.redhat.com/886824 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 1 insertion(+), 6 deletions(-) Approvals: Ayal Baron: Looks good to me, but someone else must approve Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If09925567472fb546b62942c1c51d36b49a62289 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: doc: minor cleanups
by Alon Bar-Lev 17 Dec '12

17 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: minor cleanups ...................................................................... doc: minor cleanups Change-Id: Ic623c9d644287c1ca1cbe8260f78b35f80e04f87 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M README M README.environment 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic623c9d644287c1ca1cbe8260f78b35f80e04f87 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [es_ES] heading "Virtual size" is truncated in Spa...
by derez＠redhat.com 17 Dec '12

17 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379) ...................................................................... webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379) https://bugzilla.redhat.com/871379 Increased the size of the "Virtual Size" column to fit all locales. Change-Id: I8a00c8f1ad60c0f551664630bb2f375cc224aa21 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a00c8f1ad60c0f551664630bb2f375cc224aa21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: engine-manage-domains should not write passwd to log
by yzaslavs＠redhat.com 17 Dec '12

17 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: engine-manage-domains should not write passwd to log ...................................................................... tools: engine-manage-domains should not write passwd to log Running "engine-manage-domains -action=validate" records password in log in clear text. Change-Id: Iff044f9c331dad9cc3b923c955dcad41fabdf48d Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff044f9c331dad9cc3b923c955dcad41fabdf48d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Add permissions sub collections to Networks
by masayag＠redhat.com 17 Dec '12

17 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Add permissions sub collections to Networks ...................................................................... restapi: Add permissions sub collections to Networks The patch adds the permissions sub collections to Network resource. Change-Id: Ib2d2fab5f0e546fe92c9f5add7fc2a83b2c1d159 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/NetworkResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResource.java 5 files changed, 67 insertions(+), 12 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/10033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2d2fab5f0e546fe92c9f5add7fc2a83b2c1d159 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0