- Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[master]: cli: support fetching new sdk proxy
by mpastern＠redhat.com 17 Dec '12

17 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: support fetching new sdk proxy ...................................................................... cli: support fetching new sdk proxy Change-Id: I9dd0e827fd1347be5a2299abae8eeadb930c1a48 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/connect.py M src/ovirtcli/command/console.py M src/ovirtcli/command/info.py M src/ovirtcli/context.py 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dd0e827fd1347be5a2299abae8eeadb930c1a48 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: Wrong name of section in .rhevmshell causes to tracebac...
by mpastern＠redhat.com 17 Dec '12

17 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Wrong name of section in .rhevmshell causes to traceback #880641 ...................................................................... cli: Wrong name of section in .rhevmshell causes to traceback #880641 https://bugzilla.redhat.com/show_bug.cgi?id=880641 Change-Id: Ie29d9d5e26e7a69097dd199bee0192971cc8324d Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/settings.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie29d9d5e26e7a69097dd199bee0192971cc8324d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: allow connection to guest with non resp agent
by tjelinek＠redhat.com 17 Dec '12

17 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: allow connection to guest with non resp agent ...................................................................... userportal: allow connection to guest with non resp agent Change the way we treat non responding agent error received from VDSM when trying to connect to guest using spice. Instead of showing an error dialog and canceling the spice connection, we now present a confirmation dialog (saying that the user will have reduced capabilities due to the fact the agent is non-responsibe) - if the user choose to cancel, the spice console won't opened, and if the user choose to continue, spice console will be opened without SSO. FrontendEventsHandlerImpl was changed such that it won't show error dialog in case the returned error is 'nonresp' (non responding guest agent) from logon command. In addition, the confirmation dialog described above for the spice console connection operation was added. Change-Id: I4eaf009f5ff99946dbb421459ccdec9c536aea58 Bug-Url: https://bugzilla.redhat.com/871083 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceToGuestWithNonRespAgentModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/basic/UserPortalBasicListProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java 11 files changed, 120 insertions(+), 27 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/10030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4eaf009f5ff99946dbb421459ccdec9c536aea58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Adding VmGuestInfoInterface
by masayag＠redhat.com 17 Dec '12

17 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Adding VmGuestInfoInterface ...................................................................... engine: Adding VmGuestInfoInterface As part of the Reporting Internal Vnic Information feature, this patch adds a new table, Dao and entity called vm_guest_agent_interface, VmGuestAgentInterfaceDao and VmGuestAgentInterface respectively. Each row in this table is related to a specific VM, and will be presented through REST API under that VM. Also, it will be associated with Vm Interfaces according to Mac address. Change-Id: I0d25018f94c2b4d29c01be85a222460335603569 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql A backend/manager/dbscripts/upgrade/03_02_0050_add_vm_guest_agent_interfaces_table.sql A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmGuestAgentInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 10 files changed, 433 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d25018f94c2b4d29c01be85a222460335603569 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add quota validator to Edit-Disk
by gchaplik＠redhat.com 17 Dec '12

17 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Add quota validator to Edit-Disk ...................................................................... engine: Add quota validator to Edit-Disk Trying to add disk was failing with no visible reason when no quota was selected. Added a validator to the Edit-Disk view. fixed permission issue when empty quota is selected Change-Id: Ic8f750f50a6ff201c55da325bfd4b3c5c9468822 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8f750f50a6ff201c55da325bfd4b3c5c9468822 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Introduced locking on gluster clusters
by ofrenkel＠redhat.com 17 Dec '12

17 Dec '12

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: Introduced locking on gluster clusters ...................................................................... gluster: Introduced locking on gluster clusters GlusterManager can potentially interfere with BLL commands that execute a gluster command and then update DB with appropriate changes. Hence it is required that all such gluster BLL commands acquire a lock before performing their logic, and release it in the end. To enable this, added the @LockIdNameAttribute annotation on all gluster commands that require the locking, and overrode the method getExclusiveLocks() in GlusterCommandBase and GlusterVolumeCommandBase to make sure that the lock is acquired on the id of the gluster cluster on which the action is being performed. Also modified the GlusterManager to acquire and release locks at appropriate places when syncing information with GlusterFS. Introduced a new LockingGroup GLUSTER for all gluster related locking. Change-Id: I57b3bd0b9e384ff130c4083147ac228a81185a2d Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterServerCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java 14 files changed, 131 insertions(+), 18 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57b3bd0b9e384ff130c4083147ac228a81185a2d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: backup.sh script should allow (#866963)
by emesika＠redhat.com 17 Dec '12

17 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: core: backup.sh script should allow (#866963) ...................................................................... core: backup.sh script should allow (#866963) backup.sh script should allow providing a backup file name/full path Adding a -f flag to the backup.sh script that enables to override the auto generated file name with a custom file name. Change-Id: I41e06dcb1f430e0c010d7bfaaf208f9a0ccd0aeb Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=866963 --- M backend/manager/dbscripts/backup.sh 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41e06dcb1f430e0c010d7bfaaf208f9a0ccd0aeb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix getQuotaConsumptionParameters redundant calls
by gchaplik＠redhat.com 17 Dec '12

17 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix getQuotaConsumptionParameters redundant calls ...................................................................... core: Fix getQuotaConsumptionParameters redundant calls The getQuotaConsumptionParameters method was called 3 time during the command lifetime. A field holding the consumptionParameters was added and the value is saved after the first call. Change-Id: Ic64c7bd3352df49f61902bf4f749c7475e402bcc Bug-Url: https://bugzilla.redhat.com/882810 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 17 insertions(+), 14 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic64c7bd3352df49f61902bf4f749c7475e402bcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix empty quota in audit mode - NPE
by gchaplik＠redhat.com 17 Dec '12

17 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix empty quota in audit mode - NPE ...................................................................... core: Fix empty quota in audit mode - NPE When Quota is empty in audit mode the QuotaManager reaches NPE. a mechanism for removing empty quota parameters from the consumption parameters list was added. Change-Id: Ie855ed5d5a259fa44b60cde25de75ae223239d0e Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie855ed5d5a259fa44b60cde25de75ae223239d0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add empty quota validator to update-VM
by gchaplik＠redhat.com 17 Dec '12

17 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Add empty quota validator to update-VM ...................................................................... webadmin: Add empty quota validator to update-VM UpdateVmPopUpView was missing validation for empty quota. validation was added. Change-Id: I2981ab55a30e2417d545cfe3bb63f777b2aa2798 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NotEmptyQuotaValidation.java 2 files changed, 33 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2981ab55a30e2417d545cfe3bb63f777b2aa2798 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0