- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Use "Power Off" instead of "Stop" VM action (#8696...
by achub＠redhat.com 17 Dec '12

17 Dec '12

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Use "Power Off" instead of "Stop" VM action (#869634) ...................................................................... webadmin: Use "Power Off" instead of "Stop" VM action (#869634) Change-Id: I06b60e5fa3159ff74c857418cd058b39916a32dd Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06b60e5fa3159ff74c857418cd058b39916a32dd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: NullPointerException detected when selecting hosts
by tjelinek＠redhat.com 17 Dec '12

17 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: NullPointerException detected when selecting hosts ...................................................................... webadmin: NullPointerException detected when selecting hosts libvirtVersion attribute causes NullPointerException Change-Id: I7398439d3c7dfe59750213fe94c06899b9d2cacd Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7398439d3c7dfe59750213fe94c06899b9d2cacd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Refactor MigrateVmCommand#getAuditLogTypeValue
by ofrenkel＠redhat.com 17 Dec '12

17 Dec '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Refactor MigrateVmCommand#getAuditLogTypeValue ...................................................................... core: Refactor MigrateVmCommand#getAuditLogTypeValue - Remove the usage of local field "startMessage" that was used only once - Move the comment which explains the logic of this method outside of the method to improve its readability Change-Id: Ic6f16b4dcf51de74898291b52d18a9d0eddac1c4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6f16b4dcf51de74898291b52d18a9d0eddac1c4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix IndexOutOfBoundsException in plug FC disk
by mlipchuk＠redhat.com 17 Dec '12

17 Dec '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix IndexOutOfBoundsException in plug FC disk ...................................................................... core: Fix IndexOutOfBoundsException in plug FC disk Attach/Detach and plug disk throws an indexOutOfBoundsException. The reason for that is that the FC LUN which the disk is related to does not contains any connections in it, as opposed to ISCSI lun which must have connections related to it. The proposed fix is to use FCP storage type if the LUN does not contain any connections in it. Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687 Bug-Url: https://bugzilla.redhat.com/882825 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java 2 files changed, 61 insertions(+), 4 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>

1 0

Change in ovirt-engine[master]: webadmin: "No message" is displayed in Japanese environment
by tjelinek＠redhat.com 17 Dec '12

17 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: "No message" is displayed in Japanese environment ...................................................................... webadmin: "No message" is displayed in Japanese environment New/Edit VM dialog -> fill a japanese chars into the description field. An error dialog with message "No message" will be displayed. The problem was, that the ErrorTranslator expected, that when a message is in form: "$AAA b" is a variable $AAA with value "b". Than it expected that the ${AAA} in other messages can be replaced by "b". The problem was, that the decision, if the specific message is a variable declaration or a message was decided in a following way: - if the string starts with "$" character, than it is a variable declaration - it is a message otherwise The problem with this is, that when a message looks like "${AAA} b" than it is considered to be a variable declaration, even it is a message with reference to the declaration. Fixed by enriching this decision if somethin is a variable declaratition to the following: - if the string starts with "$" but it is does not start with something like "${some string}" it is a variable - it is a message otherwise Change-Id: I04b32be4cf4c05873bcf9643dd5b9acb3695a54a Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/ErrorTranslatorTest.java 2 files changed, 47 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04b32be4cf4c05873bcf9643dd5b9acb3695a54a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: auto complete suggests "from_event_id" while it shouldn...
by mpastern＠redhat.com 17 Dec '12

17 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: auto complete suggests "from_event_id" while it shouldnt #886792 ...................................................................... cli: auto complete suggests "from_event_id" while it shouldnt #886792 https://bugzilla.redhat.com/show_bug.cgi?id=886792 Change-Id: I76fa563cb5a1d35b71eec01670b03239ddb92379 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/utils/autocompletionhelper.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76fa563cb5a1d35b71eec01670b03239ddb92379 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: filter out _Base__context prop in txt formating
by mpastern＠redhat.com 17 Dec '12

17 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: filter out _Base__context prop in txt formating ...................................................................... cli: filter out _Base__context prop in txt formating _Base__context prop belongs to sdk internals Change-Id: Idc8765c4bcaa1f4787b65e90f8d866ae60564d56 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/format/text.py 1 file changed, 1 insertion(+), 70 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc8765c4bcaa1f4787b65e90f8d866ae60564d56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: negative numbers wrapped as strings #880216
by mpastern＠redhat.com 17 Dec '12

17 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: negative numbers wrapped as strings #880216 ...................................................................... cli: negative numbers wrapped as strings #880216 https://bugzilla.redhat.com/show_bug.cgi?id=880216 Change-Id: Ib5ff2aa8a22a0a6059e717214c88f686943e0533 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/parser.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5ff2aa8a22a0a6059e717214c88f686943e0533 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: missing acknowledgement for remove commands #886941
by mpastern＠redhat.com 17 Dec '12

17 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: missing acknowledgement for remove commands #886941 ...................................................................... cli: missing acknowledgement for remove commands #886941 https://bugzilla.redhat.com/show_bug.cgi?id=886941 Change-Id: Ib612a6bb69fb9319131cddc02a84c715a4786286 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/messages.py M src/ovirtcli/command/remove.py 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib612a6bb69fb9319131cddc02a84c715a4786286 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: update prompt status upon "Connection failure" #880559
by mpastern＠redhat.com 17 Dec '12

17 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: update prompt status upon "Connection failure" #880559 ...................................................................... cli: update prompt status upon "Connection failure" #880559 https://bugzilla.redhat.com/show_bug.cgi?id=880559 Change-Id: I18c7ec8c986315e30fd4ae0e8e7598cef960fa05 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/context.py M src/cli/messages.py M src/ovirtcli/command/connect.py M src/ovirtcli/context.py M src/ovirtcli/shell/engineshell.py 5 files changed, 40 insertions(+), 28 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18c7ec8c986315e30fd4ae0e8e7598cef960fa05 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0