- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove unmanaged devices on down VM event
by rgolan＠redhat.com 12 Dec '12

12 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: core: remove unmanaged devices on down VM event ...................................................................... core: remove unmanaged devices on down VM event unmanaged devices where being removed only by direct stop/shutdown commands. This patch will move this treatment to be fired by the eventListener onProcressStopVm so even when a guest VM is shuting down by its OS function, without th engine, unmanaged devices will be removed Change-Id: I6593b9cb36fecc87f9b9af574d61300d55d6ad62 Bug-Url: https://bugzilla.redhat.com/846696 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java 3 files changed, 54 insertions(+), 47 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6593b9cb36fecc87f9b9af574d61300d55d6ad62 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: common: config: remove unused config entries
by emesika＠redhat.com 12 Dec '12

12 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: common: config: remove unused config entries ...................................................................... common: config: remove unused config entries - AsyncPollingCyclesBeforeCallbackCleanup - AsyncPollingCyclesBeforeRefreshSuspend - AutoPostbackDelay - AutoRemoteInterface - CertificatePassword - DebugSearchLogging - DefaultDataBaseName - ENMailEnableSsl - ENMailHost - ENMailPassword - ENMailPort - ENMailUser - ExportVmDefaultPath - ImageCheckFailureMessageTimout - IncludeDesktop - MaxCorrelationIdLength - MaxResultsPageSize - MaxVmDiskSize - MigrationMinPort - MigrationPortRange - MinVmDiskSize - OvfDirectoryPath - PSAsyncActionTimeOutInMinutes - PowerClientAutoMigrateCheckOnRDP - PowerClientUserPortalVdcManagedSpiceState - RemoteBackend - RemoteInterface - RemoteUri - RemoteUserBackend - SQLI18NPrefix - SearchesRefreshRateInSeconds - SlowStorageResponseMessageTimout - UseVdsBrokerInProc - VdsFenceOptions Change-Id: I84433d5005b9285198fbbcd7f1b932cdf87bc356 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties M packaging/fedora/setup/engine-config-install.properties M packaging/fedora/setup/engine-setup.py 6 files changed, 7 insertions(+), 127 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84433d5005b9285198fbbcd7f1b932cdf87bc356 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: common: config: add used parameters missing from ConfigValue...
by emesika＠redhat.com 12 Dec '12

12 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: common: config: add used parameters missing from ConfigValues ...................................................................... common: config: add used parameters missing from ConfigValues - ENGINEEARLib - MinimalETLVersion Change-Id: If629baa70adeb5481197e048266aed039769fb6c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If629baa70adeb5481197e048266aed039769fb6c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: common: config: remove parameters not in ConfigValues
by emesika＠redhat.com 12 Dec '12

12 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: common: config: remove parameters not in ConfigValues ...................................................................... common: config: remove parameters not in ConfigValues - CAEngineKey - SQLServerI18NPrefix - ScriptsPath - CbcCheckOnVdsChange Change-Id: I8eb02234cf27aa4f560c9a3719fa534223efc4fe Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/fedora/setup/engine-setup.py 2 files changed, 4 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8eb02234cf27aa4f560c9a3719fa534223efc4fe Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: common: config: move development values to config_devel.sql
by emesika＠redhat.com 12 Dec '12

12 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: common: config: move development values to config_devel.sql ...................................................................... common: config: move development values to config_devel.sql There is no room for development values within the defaults of the product. Development values must exists within the database because some of the database creation scripts assumes defaults within database, so even if these were defaults, they are candidate from removal from database. - CABaseDirectory - CertAlias - CertificateFileName - ENGINEEARLib - SysPrep* - keystorePass - keystoreUrl Change-Id: Iefa56503618488510d9751ebe0e313ad15069db3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/config_devel.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/fedora/setup/engine-setup.py 3 files changed, 27 insertions(+), 22 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefa56503618488510d9751ebe0e313ad15069db3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: common: config: remove deprecated entries
by emesika＠redhat.com 12 Dec '12

12 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: common: config: remove deprecated entries ...................................................................... common: config: remove deprecated entries - SelectCommandTimeout - LogXmlRpcData - BootstrapInstallerFileName - CBCCertificateScriptName - CBCCloseCertificateScriptName - VirtualMachineDomainName - AutoMode - DefaultWorkgroup - CertificateFingerPrint - LicenseCertificateFingerPrint - VdcBootStrapUrl - AutoSuspendTimeInMinutes - RDPLoginWithFQN - PowerClientGUI - PowerClientAllowUsingAsIRS - RenewGuestIpOnVdsSubnetChangeOnParseError - RenewGuestIpOnVdsSubnetChange - ENMailDomain - ENMailIsBodyHtml - ENMailUseDefaultCredentials - RedirectServletReportsPageError - SQLServerPagingSyntax - SQLServerPagingType - SQLServerSearchTemplate - LogDBCommands - PublicURLPort - SQLServerLikeSyntax - CustomPublicConfig_AppsWebSite - BootstrapNodeIDCommand Change-Id: I7e618c78acbee8f77cf310cfdb35e485568ed766 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/config_devel.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M packaging/fedora/setup/engine-config-install.properties 5 files changed, 34 insertions(+), 173 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e618c78acbee8f77cf310cfdb35e485568ed766 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix unit tests that use java assertions
by mpastern＠redhat.com 12 Dec '12

12 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix unit tests that use java assertions ...................................................................... restapi: fix unit tests that use java assertions Replaced java assertions with junit assertions Change-Id: Iffe7d5a845e886d2961c28f1eed5c32bb924e067 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/utils/test/UsbResourceUtilsTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/utils/UsbMapperUtilsTest.java 2 files changed, 20 insertions(+), 13 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffe7d5a845e886d2961c28f1eed5c32bb924e067 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing UpdateSpmHostNameVDSCommand class
by mkublin＠redhat.com 12 Dec '12

12 Dec '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing UpdateSpmHostNameVDSCommand class ...................................................................... engine: Removing UpdateSpmHostNameVDSCommand class The following command contains a potential bug and also the functionality of update host_name is removed, so need for special command Change-Id: I3485ff235be53e4365c8732f88c0c053f4718fb6 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpdateSpmHostNameVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UpdateSpmHostNameVDSCommand.java 5 files changed, 4 insertions(+), 83 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3485ff235be53e4365c8732f88c0c053f4718fb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: add rhel specific packaging behaviour
by Alon Bar-Lev 11 Dec '12

11 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: add rhel specific packaging behaviour ...................................................................... packaging: add rhel specific packaging behaviour Change-Id: I8e550409611fac2e2f16645fdc2370db011dd49b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-host-deploy.spec.in 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e550409611fac2e2f16645fdc2370db011dd49b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packaging: update spec revision
by Alon Bar-Lev 11 Dec '12

11 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: update spec revision ...................................................................... packaging: update spec revision Change-Id: I0ae951691360547e3f63f61d1b7834d885363ddc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ae951691360547e3f63f61d1b7834d885363ddc Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0