- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: ImportVm test cleanup: createVm return
by amureini＠redhat.com 12 Dec '12

12 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm test cleanup: createVm return ...................................................................... core: ImportVm test cleanup: createVm return Inline the return statement in createVm(), for better readability. Change-Id: Ieec82913fbb116544293d2aeabbd86d00d08374c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieec82913fbb116544293d2aeabbd86d00d08374c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm cleanup: iterate maps values()
by amureini＠redhat.com 12 Dec '12

12 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm cleanup: iterate maps values() ...................................................................... core: ImportVm cleanup: iterate maps values() Iterate of VM's disks map values() instead of iterating over the keySet() and using get() to retrieve the value when the key is not interesting. The main purpose for this change is the added readability, and the (slight) performance gain is just a bonus. Change-Id: I687810d5619603aab135a7d5d8e8fcef11685e9a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 9 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I687810d5619603aab135a7d5d8e8fcef11685e9a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Modify excepted exception to match impl
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Modify excepted exception to match impl ...................................................................... engine: Modify excepted exception to match impl The patch modifies the expected exception to the correct package so test could pass successfully. Change-Id: I016ced1da2d86e27497149fac82fea832ce01a1e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkDAOHibernateImplTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I016ced1da2d86e27497149fac82fea832ce01a1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Modify Network Assign to Cluster Command permissions
by mkolesni＠redhat.com 12 Dec '12

12 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Modify Network Assign to Cluster Command permissions ...................................................................... engine: Modify Network Assign to Cluster Command permissions The patch modifies the required permissions for performing Network assignment, update or removing a network from a Cluster. These operations require a permission on the Network or a permission on the Cluster when updating the network on the cluster. Change-Id: Iff1edaeaf323a7a5b7c407e06d2ff9e3dae3430a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkOnClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 4 files changed, 106 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/9540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff1edaeaf323a7a5b7c407e06d2ff9e3dae3430a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Extracts permission check algorithm
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extracts permission check algorithm ...................................................................... engine: Extracts permission check algorithm The patch extracts the permission check algorithm so it could be override by commands that require a specific behavior. Change-Id: I32e60540308c6bf6495b472608e307dc695edd11 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 37 insertions(+), 27 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32e60540308c6bf6495b472608e307dc695edd11 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Use proper dao api to detect used network
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use proper dao api to detect used network ...................................................................... engine: Use proper dao api to detect used network The patch simplifies the code of RemoveNetworkCommand by removing redundant code and using a proper method of the NetworkDao in order to detect if a specific network is used by a cluster instead of iterating all the cluster's networks. Change-Id: I95419986b99c23a741d28929532619f4c56da5a4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveNetworkCommand.java 1 file changed, 6 insertions(+), 17 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95419986b99c23a741d28929532619f4c56da5a4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Cleanup network commands
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Cleanup network commands ...................................................................... engine: Cleanup network commands Avoid static access to DbFacade instance. Change-Id: Idc02f4024b3c33cee5260bb82b03c25236a3830a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateInterfaceCommand.java 4 files changed, 23 insertions(+), 41 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc02f4024b3c33cee5260bb82b03c25236a3830a Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Restrict viewable networks by the User
by mkolesni＠redhat.com 12 Dec '12

12 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Restrict viewable networks by the User ...................................................................... engine: Restrict viewable networks by the User The patch restricts the viewable network by the user for: 1. Networks the user has permissions on 2. Data Center which contains the network and the user has permission on. 3. The Network is attached to the VM's nic or Template's nic. 4. Data-Center or Cluster that contains the VM/Template Change-Id: I542e687da8f51dd83e66d813c769275736abc114 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/network_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 5 files changed, 97 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/9545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I542e687da8f51dd83e66d813c769275736abc114 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Require Permissions on Network
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Require Permissions on Network ...................................................................... engine: Require Permissions on Network Actions that using Networks will require specific permissions for the subjected network: Network's usage actions require users to have an action group CONFIGURE_VM_NETWORK/CONFIGURE_TEMPLATE_NETWORK for using the network. In order to configure PORT_MIRRORING the user must have PORT_MIRRORING action group on the network. The patch assumes the network name might be empty for creating a vNic which isn't connected to any network (as part of the Network Wiring feature). Change-Id: Ife019f6195b8a8c09e7dba989f37f150700dbaea Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateInterfaceCommand.java 4 files changed, 127 insertions(+), 12 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/9544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife019f6195b8a8c09e7dba989f37f150700dbaea Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: engine: Extend NetworkDao
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extend NetworkDao ...................................................................... engine: Extend NetworkDao The NetworkDao is extended with two methods for fetching the network entity by the following criteria: 1. By network name and storage pool id. 2. By network name and cluster id. The motivation is easing the process of fetching the network entity when is being queried either in scope of VM (find network which is attached to a VM) or in the scope of data center which previously was executed by getting the entire networks list for a DC/Cluster and filtering out the required network. Change-Id: If559aaf1ce824a0271874cf10cff1e42dd4647ba Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllNetworksQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAOHibernateImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkDAOTest.java 7 files changed, 237 insertions(+), 24 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/9543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If559aaf1ce824a0271874cf10cff1e42dd4647ba Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0