- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: CPU pinning validation cleanup
by lhornyak＠redhat.com 11 Dec '12

11 Dec '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: CPU pinning validation cleanup ...................................................................... core: CPU pinning validation cleanup isPinningAndMigrationValid renamed to validatePinningAndMigration Change-Id: I2b9788aa3505d9a6657d9eaa9c47af63852c02fa Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b9788aa3505d9a6657d9eaa9c47af63852c02fa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change VMDevice.toString() (#885984)
by amureini＠redhat.com 11 Dec '12

11 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: Change VMDevice.toString() (#885984) ...................................................................... core: Change VMDevice.toString() (#885984) In VMDevice.toString the device alias property was serialized as alias. Changed to deviceAlias just to be clear. Change-Id: I28720d0d843c9be4225437bd8f8b39c981fab1e5 Bug-Url: https://bugzilla.redhat.com/885984 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/9837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28720d0d843c9be4225437bd8f8b39c981fab1e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: move keystorePass to decrypted section
by juan.hernandez＠redhat.com 11 Dec '12

11 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: setup: move keystorePass to decrypted section ...................................................................... packaging: setup: move keystorePass to decrypted section The keystorePass need to be stored before encrypted fields can be stored, as it is the password for opening the key to encrypt the other fields required by engine-config. Change-Id: Ib9963db3e0218f855534c5c4534c6481beedf9f1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9963db3e0218f855534c5c4534c6481beedf9f1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup StorageDomainCommandBase
by lhornyak＠redhat.com 11 Dec '12

11 Dec '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup StorageDomainCommandBase ...................................................................... core: cleanup StorageDomainCommandBase - use failCanDoAction Change-Id: Iec6389f02859bc5cd3fd16857b76afb85894ba09 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec6389f02859bc5cd3fd16857b76afb85894ba09 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: NPEs and wrong persisted information when reusing LUNs
by amureini＠redhat.com 11 Dec '12

11 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: NPEs and wrong persisted information when reusing LUNs ...................................................................... core: NPEs and wrong persisted information when reusing LUNs Generally, the following issues caused that a created storage domain on pre-existing luns storage led to NPEs and wrong data shown to the user during execution of GetLunsByVgIdQuery. This patch fixes the following issues: 1. When removing a domain that used LUN storage and there's a disk used by that LUN - LUNs volume_group_id still contains the removed domain id which doesn't exist anymore. 2. When extending a domain to use an existing LUN, the domain id isn't set to that LUN which causes to NPE in GetLunsByVgIdQuery or wrong data provided to the user. 3. When creating a domain from an existing LUN, the domain id isn't set to this LUN which might causes to NPE in GetLunsByVgIdQuery or wrong data provided to the user. 4. When removing LUN disk which isn't used as storage domain (and therefore - not used anymore), the LUN remained in the DB. Change-Id: I38a0e3c68cb8bd80c2f78ee5aacfccc8c987a79e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875909 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/dbscripts/storages_san_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAOHibernateImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/LunDAOTest.java 12 files changed, 87 insertions(+), 26 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/9229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38a0e3c68cb8bd80c2f78ee5aacfccc8c987a79e Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImagesHandlerTest: fix typo in assertion
by mlipchuk＠redhat.com 10 Dec '12

10 Dec '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: ImagesHandlerTest: fix typo in assertion ...................................................................... core: ImagesHandlerTest: fix typo in assertion Fixed a typo in an assertion method difined->defined. Change-Id: I7ed1f93afd34a80f9f5843e75a7570fb75e1750f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ed1f93afd34a80f9f5843e75a7570fb75e1750f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Unit test ImagesHandler.getSuggestedAlias
by amureini＠redhat.com 10 Dec '12

10 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: Unit test ImagesHandler.getSuggestedAlias ...................................................................... core: Unit test ImagesHandler.getSuggestedAlias Added a test suite for ImagesHandler.getSuggestedAlias. Change-Id: Iaf2a1147c022f4cdb7c5658818667af4b51e6aac Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java 2 files changed, 46 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf2a1147c022f4cdb7c5658818667af4b51e6aac Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: javadoc ImagesHandler.getSuggestedDiskAlias
by amureini＠redhat.com 10 Dec '12

10 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: javadoc ImagesHandler.getSuggestedDiskAlias ...................................................................... core: javadoc ImagesHandler.getSuggestedDiskAlias Improved the documentation of ImagesHandler.getSuggestedDiskAlias, to make it slightly clearer. Change-Id: Ifb41697e19bf63e9897c96007ebda8cfcdbfb2af Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb41697e19bf63e9897c96007ebda8cfcdbfb2af Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-live[master]: root commit
by mgoldboi＠redhat.com 10 Dec '12

10 Dec '12

Moran Goldboim has submitted this change and it was merged. Change subject: root commit ...................................................................... root commit Change-Id: Ib7777fd28388bb9fafb84cfb7318548243914748 Signed-off-by: Moran Goldboim <mgoldboi(a)redhat.com> --- 0 files changed, 0 insertions(+), 0 deletions(-) Approvals: Moran Goldboim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7777fd28388bb9fafb84cfb7318548243914748 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: replaced hard-coded service name with a const
by oschreib＠redhat.com 10 Dec '12

10 Dec '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: replaced hard-coded service name with a const ...................................................................... packaging: replaced hard-coded service name with a const Change-Id: Ide45b6f39132b2cab9859828ff94e8788ee80189 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide45b6f39132b2cab9859828ff94e8788ee80189 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0