- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Privileged user cannot create VM via API (#876460)
by mpastern＠redhat.com 10 Dec '12

10 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Privileged user cannot create VM via API (#876460) ...................................................................... restapi: Privileged user cannot create VM via API (#876460) PowerUser can create VM from GUI but the operation fails from API. /api/vms to create a VM throws insufficient permissions error. Change-Id: I604883bc48dce3f326046d59534fb9134c1bbb29 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=876460 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/vds_groups_sp.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupByNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAOHibernateImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 13 files changed, 127 insertions(+), 7 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I604883bc48dce3f326046d59534fb9134c1bbb29 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Mapping of empty name in user object (#B861098)
by mpastern＠redhat.com 10 Dec '12

10 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Mapping of empty name in user object (#B861098) ...................................................................... restapi: Mapping of empty name in user object (#B861098) When retrieving list of users using /api/users, empty name tag is added to the xml returned when the user does not belong to a group. The group should be omitted from the groups list if it is empty. Change-Id: I1444e755797b101a216fd2e20537dd6e2aaefb33 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=861098 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1444e755797b101a216fd2e20537dd6e2aaefb33 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: API should expose hypervisor version (#829625)
by mpastern＠redhat.com 10 Dec '12

10 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: API should expose hypervisor version (#829625) ...................................................................... restapi: API should expose hypervisor version (#829625) Restapi should include the hypervisor version in /api/hosts and /api/hosts/xxx A new version and os element has been added to the xml to expose the vdsm and host os information. Change-Id: Id8d3d090ae4c0ba489f3c7484d5c232c55f3c059 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=829625 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 3 files changed, 82 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8d3d090ae4c0ba489f3c7484d5c232c55f3c059 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm cleanup: saveDiskImageDynamic
by amureini＠redhat.com 09 Dec '12

09 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm cleanup: saveDiskImageDynamic ...................................................................... core: ImportVm cleanup: saveDiskImageDynamic Extracted the saveDiskImageDynamic(DiskImage) method instead of multiple blocks of the same code. Change-Id: Iba9d746c239e627b0db403fa1e1028a775e0d2ab Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 13 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba9d746c239e627b0db403fa1e1028a775e0d2ab Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm cleanup: DAO accessors
by amureini＠redhat.com 09 Dec '12

09 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm cleanup: DAO accessors ...................................................................... core: ImportVm cleanup: DAO accessors Cleaned up DAO access in ImportVmCommand. Replaced all instances of DbFacade.getInstance().getXXXDao() with protected getXXXDao() methods, and moved available methods to their correct place in the hierarchy. Change-Id: I331be144f94df2b7527e9b36289347109d4b266d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 3 files changed, 37 insertions(+), 31 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I331be144f94df2b7527e9b36289347109d4b266d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm cleanup: fix modifiers
by amureini＠redhat.com 09 Dec '12

09 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm cleanup: fix modifiers ...................................................................... core: ImportVm cleanup: fix modifiers Applied static and final modifiers that were missing from the class' methods and members. Change-Id: Ia5c3d14c575e4045101a9345b09ce7d630e0933e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5c3d14c575e4045101a9345b09ce7d630e0933e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm cleanup: remove hasSnappableDisks
by amureini＠redhat.com 09 Dec '12

09 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm cleanup: remove hasSnappableDisks ...................................................................... core: ImportVm cleanup: remove hasSnappableDisks Removed the useless hasSnappableDisks(VM) from ImportVmCommand, and just used VM.getImages.isEmpty() instead. Change-Id: I7486e68268700bd0c55204dce6fb3f711425f931 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7486e68268700bd0c55204dce6fb3f711425f931 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm cleanup: parameter hiding
by amureini＠redhat.com 09 Dec '12

09 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm cleanup: parameter hiding ...................................................................... core: ImportVm cleanup: parameter hiding Renamed a parameter of an inline class implementation to avoid hiding a variable in enclosing function. Change-Id: I408b6ad3bd7407e7a17754a0748bfbc84cb50511 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I408b6ad3bd7407e7a17754a0748bfbc84cb50511 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: engine-config cleanup all 2.2 keys from db
by amureini＠redhat.com 09 Dec '12

09 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: engine: engine-config cleanup all 2.2 keys from db ...................................................................... engine: engine-config cleanup all 2.2 keys from db Remove deprecated config values for version 2.2 from engine-config Removed all version 2.2 keys from vdc_options and action_version_map tables and test classes Change-Id: I1fdfed4efa2c4d1f52189943fd1dd38ea0c3cbb0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=859045 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/action_version_map_sp.sql M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/insert_data.sql A backend/manager/dbscripts/upgrade/03_02_0010_delete_action_version_map.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 6 files changed, 37 insertions(+), 80 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fdfed4efa2c4d1f52189943fd1dd38ea0c3cbb0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: engine-config cleanup 2.2 UseRtl8139_pv
by amureini＠redhat.com 09 Dec '12

09 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: engine: engine-config cleanup 2.2 UseRtl8139_pv ...................................................................... engine: engine-config cleanup 2.2 UseRtl8139_pv Remove deprecated config values for version 2.2 from engine-config Removed UseRtl8139_pv key and the code surrounding the logic. Change-Id: Ib3deecd9c8cc3e19d8a19c43e8a619c5f3cd5b08 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=859045 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInterfaceType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java 6 files changed, 28 insertions(+), 51 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3deecd9c8cc3e19d8a19c43e8a619c5f3cd5b08 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0