- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: clone JP translation split to two line in new VM d...
by shavivi＠redhat.com 06 Dec '12

06 Dec '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: clone JP translation split to two line in new VM dialog ...................................................................... webadmin: clone JP translation split to two line in new VM dialog Change-Id: I773aa6dc0017988f061a2a302f09ff361cabb8dc Bug-Url: https://bugzilla.redhat.com/870153 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I773aa6dc0017988f061a2a302f09ff361cabb8dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: REST: fix VmMapper of protection deletion
by mpastern＠redhat.com 06 Dec '12

06 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: REST: fix VmMapper of protection deletion ...................................................................... REST: fix VmMapper of protection deletion fix wrong behaviour which also failed tests with NPE Change-Id: Ibb2c1402b23d415e11d9f04cf3559f3885bca83c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=871371 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Frank Kobzik: Verified Allon Mureinik: Looks good to me, but someone else must approve Roy Golan: Verified -- To view, visit http://gerrit.ovirt.org/9757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb2c1402b23d415e11d9f04cf3559f3885bca83c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: hardware: fix typo in amd virtualization detection
by Alon Bar-Lev 06 Dec '12

06 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: hardware: fix typo in amd virtualization detection ...................................................................... vdsm: hardware: fix typo in amd virtualization detection Change-Id: I2deb8f7ab0f306b15edc7b8238325ef6c359e809 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/hardware.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2deb8f7ab0f306b15edc7b8238325ef6c359e809 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Add a script that displays async ...(#868672)
by emesika＠redhat.com 05 Dec '12

05 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: core:Add a script that displays async ...(#868672) ...................................................................... core:Add a script that displays async ...(#868672) Adding a fn_db_get_async_tasks function to the database. Displays DC id , DC name, SPM Host id , SPM Host name and number of async tasks awaiting. Example: ovirt=# select * from fn_db_get_async_tasks(); -[ RECORD 1 ]-+------------------------------------- dc_id | 64600e6a-ef8b-11e1-838c-0fc062f03f3a dc_name | Default spm_host_id | b021eada-ef8b-11e1-8e97-579ccb995b3c spm_host_name | pluto-vdsa task_count | 2 The functions does the following steps to gather the required information: 1) create a record type with DC name, DC id, SPM host id, SPM host name, count 2) get all distinct DC ids from async_tasks table 3) Run a cursor for each result in 2) a) get DC name b) get SPM Host id & name if available c) get count of tasks return current record 4) return set of generated records regarding the required compensation information: use the following query: select command_type, entity type from business_entity_snapshot please note: command_type is a fully qualified name , consider to take only its suffix. entity type is a string identifying the entity (like vm_static etc.) Change-Id: Ia9f021279d761344c3d9fb3bedef80637d5a7855 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/868672 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/common_sp.sql 1 file changed, 59 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9f021279d761344c3d9fb3bedef80637d5a7855 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Power Management: restart operatio..(#865385)
by emesika＠redhat.com 05 Dec '12

05 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: core:Power Management: restart operatio..(#865385) ...................................................................... core:Power Management: restart operatio..(#865385) core:Power Management: restart operation fails occasionally Currently we are performing the following in the Restart command 1) send Stop command to the fence agent 2) wait for 'off' status by sampling the agent status command 3) send Start command to the fence agent 4) wait for 'on' status by sampling the agent status command There are some cases in which the Start command can fail but the engine will still try to get the 'on' status and give up after the configured retries. The reason is that the Start & Stop command are async and we only get success for the fence script invocation. In the case that the Agent & Host uses the same power supply the Start may fail, therefor we had decided that in any case that we fail to Start the Host after the configurable retries, we will send additional Start command to cover such a case. Change-Id: I1e6a515fb246d86778d359f26ce26eae8e52ebc5 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 45 insertions(+), 20 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e6a515fb246d86778d359f26ce26eae8e52ebc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix for cpuPinning
by dfediuck＠redhat.com 05 Dec '12

05 Dec '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: fix for cpuPinning ...................................................................... core: fix for cpuPinning vcpu number was matched only as single decimal limit, so if you have more than 10 vcpus, pinning vcpus numbered over 9 always produced a validation error Change-Id: I8d2f7a01baebdbfb86a6de01dd1017c2d56a6285 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java 2 files changed, 23 insertions(+), 2 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d2f7a01baebdbfb86a6de01dd1017c2d56a6285 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Fixing npe at notification service log
by yzaslavs＠redhat.com 05 Dec '12

05 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fixing npe at notification service log ...................................................................... tools: Fixing npe at notification service log Both MAIL_FORM and MAIL_USER are not mandatory to send a notification, but if a notification sending has failed the log message uses the from object (which is set either by using MAIL_FROM if exists at the configuration , or by MAIL_USER if MAIL_FROM doesn't exist in the configuration). The log is fixed to handle possible NPEs Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=880597 Change-Id: If25ef37b0d9ff79737e7dfe8283322acb81c1dcb signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If25ef37b0d9ff79737e7dfe8283322acb81c1dcb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup on notification service resource closing
by yzaslavs＠redhat.com 05 Dec '12

05 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Cleanup on notification service resource closing ...................................................................... core: Cleanup on notification service resource closing This patch introduces DbUtils for DB-related helper methods. It uses these methods to perform quiet resource closing at the NotificationService Bug-Id: https://bugzilla.redhat.com/882847 Change-Id: I54fb540ee52255f017933b000b9b509c4e156123 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/db/DbUtils.java M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java 3 files changed, 65 insertions(+), 74 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54fb540ee52255f017933b000b9b509c4e156123 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: DB connections improvement at notifier
by yzaslavs＠redhat.com 05 Dec '12

05 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: DB connections improvement at notifier ...................................................................... tools: DB connections improvement at notifier A performance issue (and maybe not the only one) exists at NotificationService: There is a loop over the result-set representing the event subscrirbers. As long as the result-set object is active the connection is held. in each iteration there is an attempt to send mail - this operation may take time. The patch seperates the DB extraction of subscribers from the logic that is done with each one of them. This patch also adds a close to a connection at the method updateAuditLogEventProcessed Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=882847 Change-Id: I54fb540ee52255f017933b000b9b509c2e056122 Signed-off-by: Yair Zaslasky <yzaslavs(a)redhat.com> --- M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java 1 file changed, 34 insertions(+), 25 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54fb540ee52255f017933b000b9b509c2e056122 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Packaging: remove CABaseDirectory from engine-config-install...
by juan.hernandez＠redhat.com 05 Dec '12

05 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: Packaging: remove CABaseDirectory from engine-config-install.properties ...................................................................... Packaging: remove CABaseDirectory from engine-config-install.properties The parameter CABaseDirectory in engine-config-install.properties is not being used anymore and can no longer by updated with engine-config tool and as such should be removed from the setup. Bug-URL : https://bugzilla.redhat.com/show_bug.cgi?id=882874 Change-Id: I7cae8e0f6c6769dae1eb086c0d89ec58988573c7 Signed-off-by: Ohad Basan <obasan(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cae8e0f6c6769dae1eb086c0d89ec58988573c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Martin Pavlik <xpavli44(a)gmail.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0