- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: fix LoginPopupView style in IE9
by derez＠redhat.com 05 Dec '12

05 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin,userportal: fix LoginPopupView style in IE9 ...................................................................... webadmin,userportal: fix LoginPopupView style in IE9 Editors labels must be manually hidden only for IE9 (IE8 behaves correctly). Change-Id: I1a8648db21b32c58cc63ed0d00735fcd4148f7ad Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a8648db21b32c58cc63ed0d00735fcd4148f7ad Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: update internal keys of manage-domains
by rgolan＠redhat.com 05 Dec '12

05 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: core: update internal keys of manage-domains ...................................................................... core: update internal keys of manage-domains due to latest commons-configuration update a key in property file must contain an equal sign otherwise its ignored. see also http://gerrit.ovirt.org/#/c/9504/ and https://bugzilla.redhat.com/879916 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=883846 Change-Id: I00266bfb81b7fe3bd0ad707dc2f8fa536b966f2c Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/conf/kerberos/engine-manage-domains 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00266bfb81b7fe3bd0ad707dc2f8fa536b966f2c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: bridge: support bridge over bond interface
by Alon Bar-Lev 05 Dec '12

05 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: support bridge over bond interface ...................................................................... vdsm: bridge: support bridge over bond interface Change-Id: Iace6ca78e494811f91b9df94b5312a0518cfcf78 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/bridge.py 2 files changed, 33 insertions(+), 19 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iace6ca78e494811f91b9df94b5312a0518cfcf78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use .pgpass from home in dev env
by juan.hernandez＠redhat.com 05 Dec '12

05 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use .pgpass from home in dev env ...................................................................... core: Use .pgpass from home in dev env We use the .pgpass file from /etc/ovirt-engine in production environments, but this doesn't exist or is not available in most development environments, so we should try to use the file from user's home directory. If we don't do that the create_db_devel.sh script keeps asking for the database password for ever. Change-Id: I87e36c169dcf3a0aa1914ed46ccea068231d6b6d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/dbcustomfunctions.sh 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87e36c169dcf3a0aa1914ed46ccea068231d6b6d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: revisit improving VDSM error handling
by rgolan＠redhat.com 05 Dec '12

05 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: engine: revisit improving VDSM error handling ...................................................................... engine: revisit improving VDSM error handling - fix a major issue caused by 1d3c67c9cf7846ab73e6411fb8aebff8a29f9cfb where VdsManager expects VdsNetworkException on network issue. - improved the identifying network error by catching all IOExceptions. this ease catching corner case protocol error. - refactor and clean VdsNetworkException and its tree to use a constructor with a Throwable - cleaned the unuseful "{ClassName}: " convention which is already implemented in Throwable toString(). Change-Id: I9df04879b15575842da1bd53c39c00a6623374e0 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/ApplicationException.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VDSExceptionBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VDSGenericException.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VDSNetworkException.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 5 files changed, 29 insertions(+), 29 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9df04879b15575842da1bd53c39c00a6623374e0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: RFE: allow to define deletion protection per vm
by mpastern＠redhat.com 05 Dec '12

05 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RFE: allow to define deletion protection per vm ...................................................................... restapi: RFE: allow to define deletion protection per vm This patch introduces protection from unwanted deletion of VMs/Templates. In restapi it affects - add/update operations on vm/template have boolean "delete_protected" flag Change-Id: Ife391e3ac09c45c9f35b34ff75de44d92bebee5d Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=871371 --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 6 files changed, 20 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife391e3ac09c45c9f35b34ff75de44d92bebee5d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Clean up of VdsManger
by mkublin＠redhat.com 05 Dec '12

05 Dec '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Clean up of VdsManger ...................................................................... engine: Clean up of VdsManger Simple clean up Change-Id: Ie22ffe067d929a1feacbb8f864b35c443b7f07e6 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie22ffe067d929a1feacbb8f864b35c443b7f07e6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing possible ConcurrentModificationException at R...
by mkublin＠redhat.com 05 Dec '12

05 Dec '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing possible ConcurrentModificationException at ResourceManager ...................................................................... engine: Fixing possible ConcurrentModificationException at ResourceManager 1. _vdsAndVmsList - is shared map and can be changed by different hosts, the exception can occurre during remove of different hosts 2. patch also contains some simple cleaning Change-Id: Id67567ccabb65c73499cbae7d0a179afe6d88244 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 1 file changed, 3 insertions(+), 18 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id67567ccabb65c73499cbae7d0a179afe6d88244 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Add group doesn't work (#882710)
by mpastern＠redhat.com 05 Dec '12

05 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Add group doesn't work (#882710) ...................................................................... restapi : Add group doesn't work (#882710) Adding a group using api requires authetication using the domain from which we are adding the group. This patch adds the ability to add groups from domains identified by the group name. Also lets the user add groups by id. Change-Id: I20927d4732af6a22702c65c0f32f072039cb82e9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=882710 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceBase.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java 3 files changed, 129 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20927d4732af6a22702c65c0f32f072039cb82e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: added win8 and win2012 to reported os version.
by bazulay＠redhat.com 05 Dec '12

05 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: agent: added win8 and win2012 to reported os version. ...................................................................... agent: added win8 and win2012 to reported os version. Change-Id: I80d2fdce98479f0d2ecf693c08bb84aff44c4465 Signed-off-by: Gal Hammer <ghammer(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80d2fdce98479f0d2ecf693c08bb84aff44c4465 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0