- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Added new column 'sshKeyFingerprint' in the vds_stat...
by yzaslavs＠redhat.com 13 Sep '12

13 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Added new column 'sshKeyFingerprint' in the vds_static table ...................................................................... engine: Added new column 'sshKeyFingerprint' in the vds_static table This fingerprint can be used to verify the server identity during add host. Done the following changes - Updated the stored procedures in vds_sp - Updated the DAO test cases - Introduced the new member sshKeyFingerprint in the VdsStatic and VDS entities - Modified view VDS to introduce this new field - Added entry for the new column in object_column_white_list Change-Id: I7abe03b62dc15bb135fa02e0a43b763abd8872af Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1380_add_ssh_key_fingerprint_column_to_vds_static.sql M backend/manager/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 11 files changed, 57 insertions(+), 14 deletions(-) Approvals: Dhandapani Gopal: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7abe03b62dc15bb135fa02e0a43b763abd8872af Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix message when detaching StorageDomain with floa...
by asaf＠redhat.com 12 Sep '12

12 Sep '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Fix message when detaching StorageDomain with floating disks(#848795) ...................................................................... webadmin: Fix message when detaching StorageDomain with floating disks(#848795) https://bugzilla.redhat.com/848795 Storage Domain may contain only floating disks which are not attached to a VM nor Template, The current message: "Error while executing action: Cannot detach Storage Domain while VMs/Templates reside on it." Is inappropriate for the situation described above, Changed message to: "Cannot detach a non empty Storage Domain, please remove all VMs / Templates / Disks and try again". Change-Id: Ied86df5375bf59f4878764297d395d4a5f29d7d9 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied86df5375bf59f4878764297d395d4a5f29d7d9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Stop progress on failed login
by vszocs＠redhat.com 12 Sep '12

12 Sep '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Stop progress on failed login ...................................................................... webadmin,userportal: Stop progress on failed login This patch hides the progress indicator on failed login. Change-Id: I3b80a32cc04be2e8327542f4b567acba712bfcef Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b80a32cc04be2e8327542f4b567acba712bfcef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused DB file swf_execute..(#855592)
by emesika＠redhat.com 12 Sep '12

12 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Remove unused DB file swf_execute..(#855592) ...................................................................... core: Remove unused DB file swf_execute..(#855592) core: Remove unused DB file swf_execute.sql from dbscripts https://bugzilla.redhat.com/855592 This patch removes an unused file. This file was used for MS SQL to Postgres conversion and is not needed any more. Change-Id: I10a9ee123279a7ffd0633672ad733b33657f1f2b Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- D backend/manager/dbscripts/swf_execute.sql 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10a9ee123279a7ffd0633672ad733b33657f1f2b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AsyncTaskParameters: clean up imports
by mlipchuk＠redhat.com 12 Sep '12

12 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: AsyncTaskParameters: clean up imports ...................................................................... core: AsyncTaskParameters: clean up imports Replaced * imports with FQCN imports. Change-Id: Ib0e9a988403044ae2e7cbbf20ea774af67831c1e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskParameters.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0e9a988403044ae2e7cbbf20ea774af67831c1e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed message for attach/detach disk to vm (#85119...
by asaf＠redhat.com 12 Sep '12

12 Sep '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: fixed message for attach/detach disk to vm (#851198) ...................................................................... webadmin: fixed message for attach/detach disk to vm (#851198) https://bugzilla.redhat.com/851198 Rephrase of attach / detach action message, fixed a typo in 'detach' word in all english language files. Change-Id: Iae923c89c71eccfc695cbb8e5dd417808c04d54b Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae923c89c71eccfc695cbb8e5dd417808c04d54b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: EntityAsyncTask: Remove unused empty methods
by mlipchuk＠redhat.com 12 Sep '12

12 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: EntityAsyncTask: Remove unused empty methods ...................................................................... core: EntityAsyncTask: Remove unused empty methods Removed several empty methods which are never extended or called outside this class. In short - dead code. Change-Id: Id53922f51e3da6eced0da40d0e00d98b2b8241ef Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java 1 file changed, 0 insertions(+), 23 deletions(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id53922f51e3da6eced0da40d0e00d98b2b8241ef Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: EntityAsncTask: Suppress synthetic-access
by mlipchuk＠redhat.com 12 Sep '12

12 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: EntityAsncTask: Suppress synthetic-access ...................................................................... core: EntityAsncTask: Suppress synthetic-access Suppress a synthetic-access warning of an intended private method to stop Eclipse IDE from reporting a warning on it. Change-Id: I533039931c2443c7cd23c59383669bc1a5569918 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I533039931c2443c7cd23c59383669bc1a5569918 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: EntityAsncTask: Replace FQCNs with imports
by mlipchuk＠redhat.com 12 Sep '12

12 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: EntityAsncTask: Replace FQCNs with imports ...................................................................... core: EntityAsncTask: Replace FQCNs with imports Replaced FQCN references in the code with imports for better readability. Change-Id: I634992fb6d8f9df54973b0bfadcf1d44b4bf825b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I634992fb6d8f9df54973b0bfadcf1d44b4bf825b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: EntityAsnycTaskManager: constants' modifiers
by mlipchuk＠redhat.com 12 Sep '12

12 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: EntityAsnycTaskManager: constants' modifiers ...................................................................... core: EntityAsnycTaskManager: constants' modifiers Make all the constants modifiers private static final, as per the correct Java standards. Change-Id: I25747f753f8b65ba808cec03ed273c2c7e4b43a7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25747f753f8b65ba808cec03ed273c2c7e4b43a7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0