- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Wipe checkbox is not set correctly in edit disk (#...
by tnisan＠redhat.com 10 Sep '12

10 Sep '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Wipe checkbox is not set correctly in edit disk (#852027) ...................................................................... webadmin: Wipe checkbox is not set correctly in edit disk (#852027) https://bugzilla.redhat.com/852027 When editing a disk, wipe after delete checkbox was not set correctly according to the actual state in the disk entity, this was caused because of a race in the changeable attribute Change-Id: Ie15a0a5707990fc6e6c317fcddf12bc30bb348ab Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie15a0a5707990fc6e6c317fcddf12bc30bb348ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, webadmin: Edit SD - applicable only from SPM (#846765)
by derez＠redhat.com 10 Sep '12

10 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core,webadmin: Edit SD - applicable only from SPM (#846765) ...................................................................... core,webadmin: Edit SD - applicable only from SPM (#846765) https://bugzilla.redhat.com/846765 * UI: Editing a storage domain - only SPM should be displayed. * ConnectAllHostsToLunCommand: 'ConnectVdsToLun' shouldn't bypass SPM. Change-Id: Ie5a87c07197e1297c30ef346caea3293304b4452 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 3 files changed, 21 insertions(+), 23 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5a87c07197e1297c30ef346caea3293304b4452 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Switched ineritance between Connect & Disconnet pool p...
by tnisan＠redhat.com 10 Sep '12

10 Sep '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Switched ineritance between Connect & Disconnet pool params (#846768) ...................................................................... core: Switched ineritance between Connect & Disconnet pool params (#846768) https://bugzilla.redhat.com/846768 Switched inheritance between connect storage pool VDS command params and disconnect storage pool VDS command params, disconnect was inheriting from connect which had more parameters than needed to disconnect which had to be filled with static values and appear in the log misleading, now connect inherits from disconnect thus no redundant parameters are used Change-Id: I01f0b389508b7b9b30169ba9a1fdfa2effc8d74e Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStoragePoolVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DisconnectStoragePoolVDSCommandParameters.java 2 files changed, 36 insertions(+), 28 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01f0b389508b7b9b30169ba9a1fdfa2effc8d74e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix test for UpdateQuotaCommand (#848389)
by gchaplik＠redhat.com 10 Sep '12

10 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix test for UpdateQuotaCommand (#848389) ...................................................................... core: Fix test for UpdateQuotaCommand (#848389) https://bugzilla.redhat.com/848289 Fix test for UpdateQuotaCommand Change-Id: Ie1dd3afb0a9e1915b9f6b8217d80110092c7cb20 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateQuotaCommandTest.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1dd3afb0a9e1915b9f6b8217d80110092c7cb20 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: MTU config should be disabled and blocked for 3.0 ...
by alkaplan＠redhat.com 10 Sep '12

10 Sep '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: MTU config should be disabled and blocked for 3.0 DC (#854496) ...................................................................... webadmin: MTU config should be disabled and blocked for 3.0 DC (#854496) https://bugzilla.redhat.com/854496 A pervious commit fixed the bz, but there was a little problem. The "MTUOverrideSupported" config value request is async and in some cases can be retrieved after the dialog and its ok and cancel buttons are loaded. In this case the user can change the mtu before the field is disabled. Change-Id: I33d7c24b40ff5acd3ee1249387a93f48f632b3c4 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java 2 files changed, 155 insertions(+), 139 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33d7c24b40ff5acd3ee1249387a93f48f632b3c4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix NPE in QuotaManager (#855647)
by dfediuck＠redhat.com 10 Sep '12

10 Sep '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix NPE in QuotaManager (#855647) ...................................................................... core: Fix NPE in QuotaManager (#855647) https://bugzilla.redhat.com/855647 This patch adds handling null storage pool passed to QuotaManager methods. In case of null storage pool, the storage pool will be extracted from the quota (passed to the method). Change-Id: I640f936fccf7973f80cabb61d41733e8b63fc699 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved ofri masad: Verified -- To view, visit http://gerrit.ovirt.org/7906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I640f936fccf7973f80cabb61d41733e8b63fc699 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add notification to quota resize (#848289)
by dfediuck＠redhat.com 10 Sep '12

10 Sep '12

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: Add notification to quota resize (#848289) ...................................................................... webadmin: Add notification to quota resize (#848289) https://bugzilla.redhat.com/848289 This patch continues the previous backend change. An alert icon will appear next to the quota utilization status in the edit-quota dialog next to any exceeded storage quota. Change-Id: I784da6102463158f5c30a821a00fce78210767ec Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaUtilizationStatusColumn.java 3 files changed, 60 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved ofri masad: Verified -- To view, visit http://gerrit.ovirt.org/7858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I784da6102463158f5c30a821a00fce78210767ec Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add notification to quota resize (#848289)
by dfediuck＠redhat.com 10 Sep '12

10 Sep '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Add notification to quota resize (#848289) ...................................................................... core: Add notification to quota resize (#848289) https://bugzilla.redhat.com/848289 When a user would edit a storage quota to be smaller than the current utilization he would get a message in the log notifying him about this situation. Change-Id: I5ef7f831120cafa10aa55e51db0270915b221c9f Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 54 insertions(+), 2 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved ofri masad: Verified -- To view, visit http://gerrit.ovirt.org/7824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ef7f831120cafa10aa55e51db0270915b221c9f Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added lock to VM when hot plugging/unplugging disks (#...
by tnisan＠redhat.com 10 Sep '12

10 Sep '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Added lock to VM when hot plugging/unplugging disks (#844440) ...................................................................... core: Added lock to VM when hot plugging/unplugging disks (#844440) https://bugzilla.redhat.com/844440 Added a lock to a VM when hot plugging/unplugging disks, this avoids the possibility of taking a snapshot of a VM in the middle of a hot plug/unplug of a disk Change-Id: Ic6ec6996b265851c7c691e1a4e68cba246df322a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommand.java 3 files changed, 17 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6ec6996b265851c7c691e1a4e68cba246df322a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: reformat /connect error
by mpastern＠redhat.com 10 Sep '12

10 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: reformat /connect error ...................................................................... cli: reformat /connect error Change-Id: Id5c5397fbdee9bed7844d3851e926d6bf696626b Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/connect.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5c5397fbdee9bed7844d3851e926d6bf696626b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0