- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: RunVmOnceCommand: don't override compensate (#856540)
by gchaplik＠redhat.com 12 Sep '12

12 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: RunVmOnceCommand: don't override compensate (#856540) ...................................................................... core: RunVmOnceCommand: don't override compensate (#856540) https://bugzilla.redhat.com/856540 This command overrides compensate() in order to call rollbackQuota() which prevents this command from compensating. Moreover, compensate() calls rollbackQuota() anyway, so this overriding seems redundant in any event. Change-Id: I0f26c4e56e4b74094ef918ab66e8722e8b8faaa1 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f26c4e56e4b74094ef918ab66e8722e8b8faaa1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Fix -Xmx JVM option (#856564)
by juan.hernandez＠redhat.com 12 Sep '12

12 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Fix -Xmx JVM option (#856564) ...................................................................... packaging: Fix -Xmx JVM option (#856564) https://bugzilla.redhat.com/856564 We currently give the "-Xms" option twice instead of giving "-Xms" and "-Xmx", this is a typo that needs to be fixed. Change-Id: Ieccdf67f6cb66b7e00c5c2492565f559dece65c3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieccdf67f6cb66b7e00c5c2492565f559dece65c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: updating report to VdsBroker log (#853883)
by oourfali＠redhat.com 12 Sep '12

12 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: updating report to VdsBroker log (#853883) ...................................................................... core: updating report to VdsBroker log (#853883) https://bugzilla.redhat.com/show_bug.cgi?id=853883 1.changing vdsName print to HostName. 2.Adding default method to getAdditionalInformation. Change-Id: I05680581ff14ac916e4d9d559476dfb4683ed233 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VdsIdVDSCommandParametersBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/IsVmDuringInitiatingVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsIdVDSCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 6 files changed, 15 insertions(+), 15 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05680581ff14ac916e4d9d559476dfb4683ed233 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove redundant events for vlans (#856108)
by masayag＠redhat.com 11 Sep '12

11 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove redundant events for vlans (#856108) ...................................................................... engine: Remove redundant events for vlans (#856108) https://bugzilla.redhat.com/856108 The patch removes audit logs about vlans since they are already reported by other events. Change-Id: Icc7ddba57644f7133107e4a09884d659fa6eb20f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 2 insertions(+), 28 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc7ddba57644f7133107e4a09884d659fa6eb20f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix of job messages that uses SnapshotName object (#84...
by mlipchuk＠redhat.com 11 Sep '12

11 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: fix of job messages that uses SnapshotName object (#844283) ...................................................................... core: fix of job messages that uses SnapshotName object (#844283) https://bugzilla.redhat.com/844283 SnapshotName object was used in various snapshot related job messages while it was never initialized and declared as a vdc object type, this patch fixes this issue which makes the job messages informative with the correct snapshot name. Change-Id: I43e1de508e53eaf624fd7fb3de455a80003c5cd6 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 7 files changed, 72 insertions(+), 8 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43e1de508e53eaf624fd7fb3de455a80003c5cd6 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: when no tasks available dont show empty string (#8...
by shavivi＠redhat.com 11 Sep '12

11 Sep '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: when no tasks available dont show empty string (#854169) ...................................................................... webadmin: when no tasks available dont show empty string (#854169) https://bugzilla.redhat.com/854169 Change-Id: Ia1d48ff3bff032f31f3fb5e70637dd11e401153d Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TaskFirstRowModelProvider.java 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1d48ff3bff032f31f3fb5e70637dd11e401153d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: NPE in runVmOnce (#854977)
by gchaplik＠redhat.com 11 Sep '12

11 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: NPE in runVmOnce (#854977) ...................................................................... core: NPE in runVmOnce (#854977) https://bugzilla.redhat.com/854977 because stateless parameter is Boolean, and we don't initialize it (to false), we get a NPE, because we try to test if it equals to false. Change-Id: I03a4823e7bed1a076a5c1f7d9580e8e28ceaa0f1 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03a4823e7bed1a076a5c1f7d9580e8e28ceaa0f1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : create template from VM with no snappable disks (#841...
by mlipchuk＠redhat.com 11 Sep '12

11 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core : create template from VM with no snappable disks (#841534) ...................................................................... core : create template from VM with no snappable disks (#841534) https://bugzilla.redhat.com/show_bug.cgi?id=841534 this patch enables the creation of template from VM's with no snappable/image disks and diskless VM's. Change-Id: Ie825ea39fee6d6d5c86f9c82f3008fa314392ed2 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 8 files changed, 100 insertions(+), 84 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie825ea39fee6d6d5c86f9c82f3008fa314392ed2 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add validation for create/edit pool (#849426)
by tjelinek＠redhat.com 11 Sep '12

11 Sep '12

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Add validation for create/edit pool (#849426) ...................................................................... webadmin: Add validation for create/edit pool (#849426) https://bugzilla.redhat.com/849426 Leftover from already merged http://gerrit.ovirt.org/#/c/7649/ The NumOfDesktops can be String and also Integer, which caused class cast exception. This patch fixes it. Change-Id: Ieb1055ca17df9a5add167a3a6228a930a04b87f4 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb1055ca17df9a5add167a3a6228a930a04b87f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: checking right permission on adding external disk (#85...
by oourfali＠redhat.com 11 Sep '12

11 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: checking right permission on adding external disk (#855779) ...................................................................... core: checking right permission on adding external disk (#855779) https://bugzilla.redhat.com/855779 When adding an external disk, we test for incorrect permissions. This patch fixes that behavior. Change-Id: If0044f46fb6fb319a64b4df4192180dcb98cbc41 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0044f46fb6fb319a64b4df4192180dcb98cbc41 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0