- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: createRequestToken should use getHashName (#8507...
by derez＠redhat.com 03 Sep '12

03 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: userportal: createRequestToken should use getHashName (#850749) ...................................................................... userportal: createRequestToken should use getHashName (#850749) https://bugzilla.redhat.com/850749 * AbstractSideTabWithDetailsPresenter -> createRequestToken: subTabName should be composed of the HashName and not the Title (i.e. as in the WebAdmin). Getting the tab's name by its title: - is wrong due to translation issues (HashName is not translated). - caused a problem in Templates-Disks sub-tab revealing after changing 'Virtual Disks' to 'Disks'. * Renaming HashName from 'virtual_disks' to 'disks' just to keep on consistency. Change-Id: I769538944b014ddd69a37ed4c151b607d6266ca1 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmMonitorModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/place/ApplicationPlaces.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AbstractSideTabWithDetailsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java 7 files changed, 9 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I769538944b014ddd69a37ed4c151b607d6266ca1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging, tools: Use JVM selected during setup (#834436)
by juan.hernandez＠redhat.com 02 Sep '12

02 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging, tools: Use JVM selected during setup (#834436) ...................................................................... packaging, tools: Use JVM selected during setup (#834436) https://bugzilla.redhat.com/834436 This patch moves the scripts of the tools and the notifier to the /usr/share/ovirt-engine/bin directory and adds there a prolog that is included by all these scripts. This prolog contains the functions that load the configuration generated by the setup tool so that the scripts will use the JVM selected during installation. Change-Id: I501e5e5cca615f5bfffef225d9ebb3204f16b7c5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/conf/kerberos/engine-manage-domains M backend/manager/modules/utils/src/main/resources/engine-manage-domains.conf M backend/manager/tools/engine-config/src/main/resources/engine-config M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/engine-notifierd M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.sh A backend/manager/tools/engine-tools-common/src/main/shell/engine-prolog.sh M packaging/fedora/setup/basedefs.py M packaging/fedora/spec/ovirt-engine.spec.in 9 files changed, 66 insertions(+), 53 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I501e5e5cca615f5bfffef225d9ebb3204f16b7c5 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Find and check JVM during setup (#834436)
by juan.hernandez＠redhat.com 02 Sep '12

02 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Find and check JVM during setup (#834436) ...................................................................... packaging: Find and check JVM during setup (#834436) https://bugzilla.redhat.com/834436 We used to have a hardcoded setting in the engine.conf.defaults file for the location of the Java virtual machine. This patch changes the engine-setup tool so that it will try to find a suitable JVM (suitable means OpenJDK 1.7 at the moment) automatically. The location of the JVM will then be written to the JAVA_HOME configuration parameter in the /etc/sysconfig/ovirt-engine file. Change-Id: Ib279ea8111825ec35a25f9ba6ee37b481ed4354f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/output_messages.py 4 files changed, 133 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib279ea8111825ec35a25f9ba6ee37b481ed4354f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: updating recovery steps for failed db restore
by juan.hernandez＠redhat.com 02 Sep '12

02 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: updating recovery steps for failed db restore ...................................................................... packaging: updating recovery steps for failed db restore Change-Id: I8ee0521b384f33d5c45d095cb6120d26ce1215b3 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 12 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ee0521b384f33d5c45d095cb6120d26ce1215b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [setupNetworks] Unsync net params can be changed (...
by alkaplan＠redhat.com 02 Sep '12

02 Sep '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: [setupNetworks] Unsync net params can be changed (#848354) ...................................................................... webadmin: [setupNetworks] Unsync net params can be changed (#848354) https://bugzilla.redhat.com/848354 The bug was fixed in a previous commit, but the fix worked just in case the "is to sync" was checked an unchecked without closing the dialog. If the edit network dialog is colsed and then opened again and the "is to sync" is changed back to false. The original "before sync" values should be reverted- this didn't work in the prevoius commit. Change-Id: Ia00641b123f109d443d98e2c99e727099c2a9d16 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java 4 files changed, 30 insertions(+), 25 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia00641b123f109d443d98e2c99e727099c2a9d16 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [SetupNetworks] Add padding to edit pencil(#853075...
by alkaplan＠redhat.com 02 Sep '12

02 Sep '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: [SetupNetworks] Add padding to edit pencil(#853075) ...................................................................... webadmin: [SetupNetworks] Add padding to edit pencil(#853075) https://bugzilla.redhat.com/853075 The "click sensitive" area around the edit pencil should be bigger. Change-Id: I06214a164275f14f0343d013e3d9863a43d7ae2e Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06214a164275f14f0343d013e3d9863a43d7ae2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: PlugUnplug to ActivateDeactivate (#850854)
by mkolesni＠redhat.com 02 Sep '12

02 Sep '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: PlugUnplug to ActivateDeactivate (#850854) ...................................................................... core: PlugUnplug to ActivateDeactivate (#850854) https://bugzilla.redhat.com/850854 This patch changes the name of PlugUnplugVmNicCommand to ActivateDeactivateVmNicCommand, since this is what the command does. Change-Id: I9a879dca5c0303c0e25c76a2bc4bf1046578679a Signed-off-by: Muli Salem <msalem(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 13 files changed, 45 insertions(+), 45 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a879dca5c0303c0e25c76a2bc4bf1046578679a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Block non-exclusive network configurations (#851134)
by mkolesni＠redhat.com 02 Sep '12

02 Sep '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Block non-exclusive network configurations (#851134) ...................................................................... engine: Block non-exclusive network configurations (#851134) https://bugzilla.redhat.com/851134 As explained in previous commit: On a Host's NIC only one of two configurations is possible: 1. A single VM network. 2. An optional single non-VM network + Any number of VLAN networks. Blocked configurations that don't match this constraint from Setup Networks. Change-Id: I2712b6e6948de0881c56d519bbf82f7ecc7f6157 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java 2 files changed, 167 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2712b6e6948de0881c56d519bbf82f7ecc7f6157 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add message for network exclusivity (#851134)
by mkolesni＠redhat.com 02 Sep '12

02 Sep '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add message for network exclusivity (#851134) ...................................................................... engine: Add message for network exclusivity (#851134) https://bugzilla.redhat.com/851134 On a Host's NIC only one of two configurations is possible: 1. A single VM network. 2. An optional single non-VM network + Any number of VLAN networks. This message represents this fact, and will be used to enforce that this constraint is kept. Change-Id: I893ccf86e3436e0fdf6903d4d5e0428facd924c2 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 7 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I893ccf86e3436e0fdf6903d4d5e0428facd924c2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove IP validation check from repetitive con (#85207...
by masayag＠redhat.com 02 Sep '12

02 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove IP validation check from repetitive con (#852076) ...................................................................... core: Remove IP validation check from repetitive con (#852076) https://bugzilla.redhat.com/852076 The IP Address is being validate explicitly therefore no need to refer to it with repetitive IP constraint. Change-Id: Iadc8e065d36c57f1a7c71fc373ce00748ff26b41 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraint.java 1 file changed, 2 insertions(+), 14 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadc8e065d36c57f1a7c71fc373ce00748ff26b41 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0