- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Add nic via guideme sets the wrong nic name (#8469...
by alkaplan＠redhat.com 22 Aug '12

22 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add nic via guideme sets the wrong nic name (#846997) ...................................................................... webadmin: Add nic via guideme sets the wrong nic name (#846997) https://bugzilla.redhat.com/846997 Sometimes, when adding nic via guide me, the nic is created with the default parameters and not with the parameters the user specified in the add nic dialog. The reason - In guide me model- when adding a nic there are async queries for nics and networks. When the nics and networks arrives from the backend (nic!=null && networks!=null) the adding procedure should continue and open the add-nic dialog. In case the networks query is ready before the nics query- the adding procedure continue (because nics were already initialized before) and opens the dialog. Then when the nics query is done the adding procedure resets the windowModel and tries to open a dialog (it doesn't succeed because there is already an open one). But when the user clicks ok on the add-nic dialog the GuideMe model uses the new window model (with default values) set after the nic query was done and not the model with which the dialog was originally opened. The solution is to reset nics and networks before the starting the queries. Change-Id: I0445c014831967524f23ae5847b388354b0e7555 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0445c014831967524f23ae5847b388354b0e7555 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Host Intrfaces menu doesn't change by DC version (...
by alkaplan＠redhat.com 22 Aug '12

22 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Host Intrfaces menu doesn't change by DC version (#838491) ...................................................................... webadmin: Host Intrfaces menu doesn't change by DC version (#838491) https://bugzilla.redhat.com/838491 The setEntity in HostIntefaceListModel was overriden and did nothing if the entityId didn't change. That's why the HostInterfaceModel remained with old dc/cluster data and the actions weren't updated correctly. Change-Id: I4ab206aa7272ebc87d0df66ab402347a118c545e Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ab206aa7272ebc87d0df66ab402347a118c545e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: can set port mirroring on Edit vnic also for 3.0 (...
by alkaplan＠redhat.com 22 Aug '12

22 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: can set port mirroring on Edit vnic also for 3.0 (#846025) ...................................................................... webadmin: can set port mirroring on Edit vnic also for 3.0 (#846025) https://bugzilla.redhat.com/846025 Port mirroring should be disabled in Edit vnic dialog if the cluster version is 3.0 or beneath. Change-Id: Icc5c83ce89f03108f6476fd1b8fcdd780543384c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc5c83ce89f03108f6476fd1b8fcdd780543384c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: [SetupNetwork] redundant line break in bottom chec...
by alkaplan＠redhat.com 22 Aug '12

22 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: [SetupNetwork] redundant line break in bottom checkboxes(#849099) ...................................................................... webadmin: [SetupNetwork] redundant line break in bottom checkboxes(#849099) https://bugzilla.redhat.com/849099 redundant line break in Verify connectivity between Host and Engine. Should use "%" instead of "px". Change-Id: I4ca0953f74bf77b0c0536347c474facc34598f12 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml 3 files changed, 22 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ca0953f74bf77b0c0536347c474facc34598f12 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:Add comma instead of dot (related to BZ848094)
by tnisan＠redhat.com 22 Aug '12

22 Aug '12

Tal Nisan has submitted this change and it was merged. Change subject: core:Add comma instead of dot (related to BZ848094) ...................................................................... core:Add comma instead of dot (related to BZ848094) Use comma instead of dot. Change-Id: Id185bb1aeb095a5cddc5fe75c2b45ba1c91d699e Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id185bb1aeb095a5cddc5fe75c2b45ba1c91d699e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove deprecated StringHelper in AddSANStorageDomainC...
by yzaslavs＠redhat.com 22 Aug '12

22 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Remove deprecated StringHelper in AddSANStorageDomainCommand. ...................................................................... core: Remove deprecated StringHelper in AddSANStorageDomainCommand. Replaced StringHelper with StringUtils Change-Id: I8e7b8d6e28a72bcfa98ddfa1b5e27b35e98b0a17 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e7b8d6e28a72bcfa98ddfa1b5e27b35e98b0a17 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: build: support files with spaces in tarball
by juan.hernandez＠redhat.com 22 Aug '12

22 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: build: support files with spaces in tarball ...................................................................... build: support files with spaces in tarball Change-Id: I39bbe4f5fa76c4b494ded9586d54fdc0cf6f2156 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39bbe4f5fa76c4b494ded9586d54fdc0cf6f2156 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:Change audit message for illegal disks (BZ848094)
by mlipchuk＠redhat.com 22 Aug '12

22 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Change audit message for illegal disks (BZ848094) ...................................................................... core:Change audit message for illegal disks (BZ848094) Change audit message when remove VM failed to remove several disks of the VM. Change-Id: I27ae8f3a4cd653f92760296a64ba14c4ec6c2b81 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27ae8f3a4cd653f92760296a64ba14c4ec6c2b81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: support app. server errors
by mpastern＠redhat.com 22 Aug '12

22 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: support app. server errors ...................................................................... sdk: support app. server errors Change-Id: If08af4b2553f7c98357ae01ef2ff510514f643ff Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/errors.py 1 file changed, 11 insertions(+), 10 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If08af4b2553f7c98357ae01ef2ff510514f643ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: do not write to file i/o during script execution
by mpastern＠redhat.com 22 Aug '12

22 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: do not write to file i/o during script execution ...................................................................... cli: do not write to file i/o during script execution Change-Id: I0b3e4fecfeef96430016f82d4396cab5f37c339b Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/context.py A src/cli/executionmode.py M src/ovirtcli/shell/filecmdshell.py 3 files changed, 40 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b3e4fecfeef96430016f82d4396cab5f37c339b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0