- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webamin: Assign Quota for Disk (#848310)
by gchaplik＠redhat.com 23 Aug '12

23 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webamin: Assign Quota for Disk (#848310) ...................................................................... webamin: Assign Quota for Disk (#848310) https://bugzilla.redhat.com/848310 add 'Assign Quota' dialog in Disks main tab: the dialog will be shown only in quota mode != disabled and when in DC context of the tree. in this dialog you may change the quota of multiple disks Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Change-Id: I1b2abe42ada902e8a247cb4638900f34b4c4e0df --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/quota/ChangeQuotaItemView.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/quota/ChangeQuotaItemView.ui.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/quota/ChangeQuotaView.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/quota/ChangeQuotaView.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/ChangeQuotaItemModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/ChangeQuotaModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/quota/ChangeQuotaPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/ChangeQuotaPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/ChangeQuotaPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 16 files changed, 580 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b2abe42ada902e8a247cb4638900f34b4c4e0df Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Introduce ChangeQuotaCommand - disks (#848310)
by gchaplik＠redhat.com 23 Aug '12

23 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Introduce ChangeQuotaCommand - disks (#848310) ...................................................................... core: Introduce ChangeQuotaCommand - disks (#848310) https://bugzilla.redhat.com/848310 We want the abillity to change quota for disks and vms. added an abstract command (ChangeQuotaCommand), that's resposnible for that. Currently implemented the ChangeQuotaForDisks, which gets the disk and quota and tries to change the disk quota, ChangeQuotaForVms will be added in the near future. Added a test to ImageDao, that checks the image quota actually changes. Change-Id: I0017a18109faecd1acab52897bba5474b6600390 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeQuotaForDiskCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/ChangeQuotaCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeQuotaParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 226 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0017a18109faecd1acab52897bba5474b6600390 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix calculation of specific quota (#838589)
by gchaplik＠redhat.com 23 Aug '12

23 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix calculation of specific quota (#838589) ...................................................................... core: Fix calculation of specific quota (#838589) https://bugzilla.redhat.com/838589 Calculations of Specific-Storage-Quota were fixed. Change-Id: Ic973f4257f8c2289bfa7948aa9f32209f5c83f06 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic973f4257f8c2289bfa7948aa9f32209f5c83f06 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup and text fix (#838589)
by gchaplik＠redhat.com 23 Aug '12

23 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Cleanup and text fix (#838589) ...................................................................... core: Cleanup and text fix (#838589) https://bugzilla.redhat.com/838589 Indentation and format were fixed. Text in AuditLog was shortend and fixed. Change-Id: I258fd187469c823f28009b7769775c182c00bac3 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 42 insertions(+), 43 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I258fd187469c823f28009b7769775c182c00bac3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix calculations of snapshot quota (#848028)
by gchaplik＠redhat.com 23 Aug '12

23 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix calculations of snapshot quota (#848028) ...................................................................... core: Fix calculations of snapshot quota (#848028) https://bugzilla.redhat.com/848028 Fix 1: The sized used for quota calculation of each snapshot was fixed. The former value was the size of the predefined disk, the new value is the actual size the snapshot took in storage. Fix 2: The snapshot-preview did not pass the quota ID to the new active image. After the commit, the active image was linked to a null qouta and so a new snapshot could not be taken. Change-Id: I6cf5d23a9c5c90b64b330cadf4f7c1b67fad45fa Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java 4 files changed, 46 insertions(+), 10 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cf5d23a9c5c90b64b330cadf4f7c1b67fad45fa Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: hourglass in login (#849537)
by gchaplik＠redhat.com 23 Aug '12

23 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin,userportal: hourglass in login (#849537) ...................................................................... webadmin,userportal: hourglass in login (#849537) https://bugzilla.redhat.com/849537 on login, disabled the login button and added wait cursor Change-Id: Ic4a4f4a8b20943e8fcfc37c076d7c8ad71e1d04a Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.ui.xml 8 files changed, 49 insertions(+), 24 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4a4f4a8b20943e8fcfc37c076d7c8ad71e1d04a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove Network Name in Import (#844396)
by mkolesni＠redhat.com 23 Aug '12

23 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Remove Network Name in Import (#844396) ...................................................................... core: Remove Network Name in Import (#844396) https://bugzilla.redhat.com/844396 1. Changes the way VmInterfaceManager validates a network. The purpose is to allow better use of the method from ImportVmCommand and from ImportVmTemplateCommand. 2. Changes the logging of ImportVmCommand and ImportVmTemplateCommand to behave the same. 3. Makes sure the Network name is removed from Nic in case the Network name was found to be invalid. Also, it separates the audit log into two - one for ImportVm and the other for ImportVmTemplate. 4. Changes the wording of the audit log to be more accurate. Signed-off-by: Muli Salem <msalem(a)redhat.com> Change-Id: I1c0e2258d1523c99ef095a3e07947835ff0c5da2 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 8 files changed, 126 insertions(+), 60 deletions(-) Approvals: Muli Salem: Verified Mike Kolesnik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c0e2258d1523c99ef095a3e07947835ff0c5da2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Prevent Reporting UNKNOWN Network (#849163)
by msalem＠redhat.com 23 Aug '12

23 Aug '12

Muli Salem has submitted this change and it was merged. Change subject: core: Prevent Reporting UNKNOWN Network (#849163) ...................................................................... core: Prevent Reporting UNKNOWN Network (#849163) https://bugzilla.redhat.com/849163 This patch makes sure the Network name is only removed from the list of bad Networks, if the Bond status is true, meaning we do not need the Network name to be printed out to the Audit log. Change-Id: I0a8349b23c3b578d33118113ff618740f1d9ab8e Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Mike Kolesnik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a8349b23c3b578d33118113ff618740f1d9ab8e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Time zones not ordered well (#850696)
by tjelinek＠redhat.com 23 Aug '12

23 Aug '12

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Time zones not ordered well (#850696) ...................................................................... engine: Time zones not ordered well (#850696) https://bugzilla.redhat.com/850696 WebAdmin -> Virtual Machines tab -> new server/desktop -> Initial Run -> Time Zone The content of this check box is not ordered well if the selected VM operating system is windows. The problem was in GetTimeZonesQuery which had the TimeZoneTimeExtractComperator not correctly implemented: The compare method returned only 0 and 1, but never -1, even when the second arg was smaller than the first one. This worked in JDK6, but the JDK7's Collections.sort() checks if the comparator is implemented correctly, and if not, it does not sort the list at all. Fixed by fixing the compare method to work according to the contract. Change-Id: Iecae3f868d6b3bc6663459367d1bd424b920a3fb Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTimeZonesQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecae3f868d6b3bc6663459367d1bd424b920a3fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: StorageFormatType cleanup
by yzaslavs＠redhat.com 23 Aug '12

23 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: StorageFormatType cleanup ...................................................................... core: StorageFormatType cleanup - import java.util instead of fqn - intValue renamed to value (since it is actually a String, not an int) Change-Id: I7e09124c888e113e1473adf8eb7f6a9f93104917 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageFormatType.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/StorageFormatTypeTest.java 2 files changed, 21 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e09124c888e113e1473adf8eb7f6a9f93104917 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0