- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Propagate correlation id in maintenance commmand (#846...
by yzaslavs＠redhat.com 23 Aug '12

23 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Propagate correlation id in maintenance commmand (#846227) ...................................................................... core: Propagate correlation id in maintenance commmand (#846227) https://bugzilla.redhat.com/846227 The MaintananceNumberOfVdss command has to propagate the correlation id to the MaintananceVds commands that it runs internally. Change-Id: If87f2436adaf52c2633e888864c708c877b19b97 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceNumberOfVdssCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If87f2436adaf52c2633e888864c708c877b19b97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: fixed axis colors in webadmin dashboards (#846311)
by ydary＠redhat.com 23 Aug '12

23 Aug '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed axis colors in webadmin dashboards (#846311) ...................................................................... reports: fixed axis colors in webadmin dashboards (#846311) now all the axis colors match across the dashboard. https://bugzilla.redhat.com/846311 Change-Id: I5ac46e31a736610ef021d4982e917ae0eec96c09 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_top_five_busiest_hosts_dr23_files/cluster_top_five_busiest_hosts_dr23_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/top_five_ha_virtual_servers_downtime_dr20_files/top_five_ha_virtual_servers_downtime_dr20_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/top_five_hosts_downtime_dr18_files/top_five_hosts_downtime_dr18_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/datacenter_top_five_busiest_clusters_dr21_files/datacenter_top_five_busiest_clusters_dr21_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_top_five_busiest_hosts_dr23_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/top_five_ha_virtual_servers_downtime_dr20_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/top_five_hosts_downtime_dr18_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/datacenter_top_five_busiest_clusters_dr21_jrxml.data 8 files changed, 16 insertions(+), 16 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ac46e31a736610ef021d4982e917ae0eec96c09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: BZ#850727 bootstrap: acquire time for host immediately befor...
by dfediuck＠redhat.com 23 Aug '12

23 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: BZ#850727 bootstrap: acquire time for host immediately before send ...................................................................... BZ#850727 bootstrap: acquire time for host immediately before send Engine uses its own clock to send current time to host during bootstrap. This change moves the point in which clock is sampled immediately before bootstrap command is sent, as result we have smaller clock delta. Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Change-Id: I37a6f961eecb392e0e31eeab459fbd9229e42df6 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37a6f961eecb392e0e31eeab459fbd9229e42df6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: filter V3 SDs for 3.0 DCs (#845067)
by derez＠redhat.com 23 Aug '12

23 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: filter V3 SDs for 3.0 DCs (#845067) ...................................................................... webadmin: filter V3 SDs for 3.0 DCs (#845067) https://bugzilla.redhat.com/845067 Attach storage dialog - filter V3 storage domains for 3.0 Data-Centers. Change-Id: If985fe6534777e1406fc0e633f73ef729bf15b61 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If985fe6534777e1406fc0e633f73ef729bf15b61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: allow unattached V1 block SD (#840558)
by derez＠redhat.com 23 Aug '12

23 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: allow unattached V1 block SD (#840558) ...................................................................... webadmin: allow unattached V1 block SD (#840558) https://bugzilla.redhat.com/840558 Allow creation of unattached V1 block storage domains. Change-Id: Ib0dd0dd838b3a56b50fa7f9f93925a5002793e07 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0dd0dd838b3a56b50fa7f9f93925a5002793e07 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk (#850795)
by mlipchuk＠redhat.com 23 Aug '12

23 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix potential NPE when adding LUN disk (#850795) ...................................................................... core: Fix potential NPE when adding LUN disk (#850795) https://bugzilla.redhat.com/show_bug.cgi?id=850795 Since LUN disk is not part of a storage pool, validation for shareable disk should be only on image disk. The proposed fix, move the validation of supported DC version to image disk. Change-Id: I6c55b95dac6f70435f7d1ac02a6a2a7cdd3f1e91 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c55b95dac6f70435f7d1ac02a6a2a7cdd3f1e91 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Support undoing diskless previews (#848298)
by mlipchuk＠redhat.com 23 Aug '12

23 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support undoing diskless previews (#848298) ...................................................................... core: Support undoing diskless previews (#848298) https://bugzilla.redhat.com/848298 This patch fixes the broken "Undo Preview" for a snapshot that contains no disks. It removes some restrictions in the canDoAction and explicitly invokes endActionOnVmConfiguration() if there are no tasks (which prevents it from being invoked in the normal async task flow). Change-Id: Ic62eee3cfb03abd21905ad6aa132c8cc10dbfb70 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 48 insertions(+), 44 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic62eee3cfb03abd21905ad6aa132c8cc10dbfb70 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: add filter parameter to proxy ctr.
by mpastern＠redhat.com 23 Aug '12

23 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: add filter parameter to proxy ctr. ...................................................................... sdk: add filter parameter to proxy ctr. api resource /api has few queries (such as GetSystemStatistics, etc.) which require admin permissions, raising /filter flag will signal to turn on permission based filtering and not call this queries what will allow non-admin users to use sdk. Change-Id: Ia6707a165fd32519f0778fae0c75f302ae4c9d26 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/entrypoint/entrypoint.py M src/ovirtsdk/api.py M src/ovirtsdk/web/connection.py 3 files changed, 66 insertions(+), 19 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6707a165fd32519f0778fae0c75f302ae4c9d26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: User login filter problem #848767
by mpastern＠redhat.com 23 Aug '12

23 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: User login filter problem #848767 ...................................................................... restapi: User login filter problem #848767 $ curl -X GET -H "Filter: true" -u user@domain:pass http://url/api <fault> <reason>Operation Failed</reason> <detail>Entity not found: VdcVersion</detail> </fault> https://bugzilla.redhat.com/show_bug.cgi?id=848767 Change-Id: Ib7e8188f37f215b364a241cb446734af7522a590 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java 2 files changed, 18 insertions(+), 17 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7e8188f37f215b364a241cb446734af7522a590 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: filter sharable disk in space check
by mkublin＠redhat.com 23 Aug '12

23 Aug '12

Michael Kublin has submitted this change and it was merged. Change subject: core: filter sharable disk in space check ...................................................................... core: filter sharable disk in space check in AddVmTemplate command, when checking for enough disk space we should filter out sharable disks, when performing the test Change-Id: I7322979d371df478f2d1d13eeceea898f35ea6b4 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Kublin: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/7432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7322979d371df478f2d1d13eeceea898f35ea6b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0