- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix AddDisk permission check
by oourfali＠redhat.com 14 Aug '12

14 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix AddDisk permission check ...................................................................... core: fix AddDisk permission check When someone adds a floating from the webadmin UI, the vm id is EMPTY_GUID. However, in the permissions check, we check for null. This patch checks for null, and if the vm id isn't null, it checks if it is an empty guid. Change-Id: Ibf0220700a9675d17f553df2b96f2e1da3b621b1 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf0220700a9675d17f553df2b96f2e1da3b621b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration
by dfediuck＠redhat.com 13 Aug '12

13 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: bootstrap: move node id creation command to configuration ...................................................................... bootstrap: move node id creation command to configuration This will enable to modify the command on demand. Change-Id: I3a575e2bf391ca6b1cf7e8baa2d8c5813e10c97f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstallHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 3 files changed, 18 insertions(+), 6 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a575e2bf391ca6b1cf7e8baa2d8c5813e10c97f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: ssh public key entry should contain new line
by dfediuck＠redhat.com 13 Aug '12

13 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: utils: ssh public key entry should contain new line ...................................................................... utils: ssh public key entry should contain new line A complete entry is a single line. Change-Id: Ifd202048b8efb8f081b10651c302b9da0718035c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/OpenSSHUtils.java M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/StoreUtils.java M backend/manager/modules/engineencryptutils/src/test/java/org/ovirt/engine/core/engineencryptutils/OpenSSHUtilsTest.java 3 files changed, 13 insertions(+), 12 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd202048b8efb8f081b10651c302b9da0718035c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix users quota check
by gchaplik＠redhat.com 13 Aug '12

13 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: fix users quota check ...................................................................... core: fix users quota check quota check will be invoked in IsUserAutorizedToRunAction Change-Id: Icc1298cabe3cc5e8895d31f473a76bb9ff7efdef Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc1298cabe3cc5e8895d31f473a76bb9ff7efdef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: allow to set quota in UP
by gchaplik＠redhat.com 13 Aug '12

13 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: allow to set quota in UP ...................................................................... userportal: allow to set quota in UP quota wasn't set in UP for create vm & template, now when selecting quota in the dialog it will be passed to the server. Change-Id: Ia3673adc00f3251a26f27926121935487d3874a5 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/7134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3673adc00f3251a26f27926121935487d3874a5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fixing vlan capitalization (#821456)
by dfediuck＠redhat.com 13 Aug '12

13 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: Fixing vlan capitalization (#821456) ...................................................................... webadmin: Fixing vlan capitalization (#821456) https://bugzilla.redhat.com/821456 - The Word VLAN was used in diffrent capitalization across the ui - changed the capitalisation to be consistent Change-Id: I67f6d44dc3ed8e5b8a165c9ab3db1d0fec99a1cd Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67f6d44dc3ed8e5b8a165c9ab3db1d0fec99a1cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[master]: UI: set focus in username field at user-portal (#847064)
by shavivi＠redhat.com 13 Aug '12

13 Aug '12

Shahar Havivi has submitted this change and it was merged. Change subject: UI: set focus in username field at user-portal (#847064) ...................................................................... UI: set focus in username field at user-portal (#847064) https://bugzilla.redhat.com/show_bug.cgi?id=847064 Change-Id: I40121d4e8cf3d4debf3336445925a0792ac4757e Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40121d4e8cf3d4debf3336445925a0792ac4757e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add Reconnect to VM action group under configure r...
by ecohen＠redhat.com 13 Aug '12

13 Aug '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Add Reconnect to VM action group under configure roles dialog ...................................................................... webadmin: Add Reconnect to VM action group under configure roles dialog Added RECONNECT_TO_VM Action Group to the roles configuration dialog Change-Id: I792d889bdd2858dcdfbeb57a01af8761c0a15b81 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 13 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I792d889bdd2858dcdfbeb57a01af8761c0a15b81 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: Unable to edit a template from objects tree
by oourfali＠redhat.com 13 Aug '12

13 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: ui: Unable to edit a template from objects tree ...................................................................... ui: Unable to edit a template from objects tree In UnitVmModel, we do not have a treatment for the case the object is a template. This patch fixes that behavior. Change-Id: I3f88a3c79bf79908a1c711d00102f02e65ec991d Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f88a3c79bf79908a1c711d00102f02e65ec991d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Rephrase edit mgmt network error(#845274)
by gchaplik＠redhat.com 13 Aug '12

13 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Rephrase edit mgmt network error(#845274) ...................................................................... webadmin: Rephrase edit mgmt network error(#845274) https://bugzilla.redhat.com/845274 Change to- "Cannot edit Management Network when there are Clusters in the Data Center" Change-Id: I2dd989472f9196c7b32c2c08cbc7f9ba11b249d5 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dd989472f9196c7b32c2c08cbc7f9ba11b249d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0