- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: making Volumes tab visible in system level
by alkaplan＠redhat.com 13 Aug '12

13 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: making Volumes tab visible in system level ...................................................................... webadmin: making Volumes tab visible in system level Volumes tab will be visible in system level when the ApplicationMode is ALL. This patch reverts the changes done in http://gerrit.ovirt.org/#/c/6607/ Change-Id: I9dd6e3ca3b190fb3eabe7a44a026012725646c01 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dd6e3ca3b190fb3eabe7a44a026012725646c01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Edit net- error lable is visible even if it should...
by alkaplan＠redhat.com 13 Aug '12

13 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Edit net- error lable is visible even if it shouldn't (#845274) ...................................................................... webadmin: Edit net- error lable is visible even if it shouldn't (#845274) https://bugzilla.redhat.com/845274 1. Rephrase to error msg on Edit Mgmt to- "Cannot edit Management Network when there are one or more Clusters in the Data Center" 2. If a network doesn't attached to any cluster. When opening the edit network dialog the error msg appears even it shouldn't. Change-Id: I09051257df435aea9f889eb7f794c109c4c05f27 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java 6 files changed, 26 insertions(+), 18 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09051257df435aea9f889eb7f794c109c4c05f27 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Use engine_test as a default DB for dao tests.
by mlipchuk＠redhat.com 13 Aug '12

13 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Use engine_test as a default DB for dao tests. ...................................................................... core:Use engine_test as a default DB for dao tests. Change the configuration pgsql file for dao testing to use engine_test as a default data base for testing instead engine. This should prevent running over existing DB engine, which most of developers use as a development DB which JBOSS count on. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ic421ea40e2d54c90a9bea18a85f9ec671aef19a9 --- M backend/manager/modules/dal/src/test/filters/pgsql.properties 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic421ea40e2d54c90a9bea18a85f9ec671aef19a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Change template NICs to read/write (#846950)
by mkolesni＠redhat.com 13 Aug '12

13 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Change template NICs to read/write (#846950) ...................................................................... restapi: Change template NICs to read/write (#846950) https://bugzilla.redhat.com/846950 The template NICs are not read-only, but in fact can be added, updated and deleted. Therefore, the return type of the getNics method was changed to reflect this behavior. Change-Id: Ia9bacfbb4e2d29827b969363fde55701f503268b Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9bacfbb4e2d29827b969363fde55701f503268b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:No need to call super method for job properties(#818295...
by mlipchuk＠redhat.com 13 Aug '12

13 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:No need to call super method for job properties(#818295) ...................................................................... core:No need to call super method for job properties(#818295) https://bugzilla.redhat.com/show_bug.cgi?id=818295 Import vm template already has the appropriate parameters to write a message, so the call for the super method is redundant. Change-Id: Ib92221db99df6d1fc4178cbab8375d6ea4d8a9c2 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib92221db99df6d1fc4178cbab8375d6ea4d8a9c2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Deny removing network which is used by VMs (#824497)
by masayag＠redhat.com 13 Aug '12

13 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Deny removing network which is used by VMs (#824497) ...................................................................... core: Deny removing network which is used by VMs (#824497) https://bugzilla.redhat.com/824497 The patch adds a check for detach network from host nic command: It prevents removing the network if the network is being used by running VMs. Change-Id: I781df6469802e079c6346227e68312b9fbffbd27 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 34 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781df6469802e079c6346227e68312b9fbffbd27 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use StringUtils and getDbFacade (#824497)
by masayag＠redhat.com 13 Aug '12

13 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Use StringUtils and getDbFacade (#824497) ...................................................................... core: Use StringUtils and getDbFacade (#824497) https://bugzilla.redhat.com/824497 The patch replaces StringHelper with StringUtils and replaces the DbFacade.getInstance() with getDbFacade(). The next patch will use both. Change-Id: I4aa0e7119d29809cb7af094a2ea978200c22613f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java 1 file changed, 8 insertions(+), 10 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4aa0e7119d29809cb7af094a2ea978200c22613f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Comment out MonitoringStrategyFactoryTest
by oourfali＠redhat.com 13 Aug '12

13 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Comment out MonitoringStrategyFactoryTest ...................................................................... core: Comment out MonitoringStrategyFactoryTest As per the decision to remove PowerMock dependencies from the project, this is removed. Note that the entire test depends on PowerMock, so it is not possible to remove only parts of it. It's commented out (as opposed to being removed) for future reference. Change-Id: I9eda9ead55d1579daa6c00da180620cac92e3fcb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/MonitoringStrategyFactoryTest.java 1 file changed, 82 insertions(+), 75 deletions(-) Approvals: Allon Mureinik: Verified Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eda9ead55d1579daa6c00da180620cac92e3fcb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: VM/Pool/Template component element IDs
by ecohen＠redhat.com 13 Aug '12

13 Aug '12

Einav Cohen has submitted this change and it was merged. Change subject: userportal: VM/Pool/Template component element IDs ...................................................................... userportal: VM/Pool/Template component element IDs This patch adds IDs to following UserPortal visual components in order to meet GUI functional test requirements (Selenium): 1. Basic View - VMs and Pools in the left panel * Name label * Status label * Run/Shutdown/Suspend buttons 2. Extended View - VM/Pool main table * Status image column * Name text column * Run/Shutdown/Suspend/Stop button column * Open console button column * Edit console button column - Template main table * Name text column Change-Id: Ifaa25bbaddad4c6894abfa3b9e83f205ee9678a1 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementIdUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ColumnWithElementId.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskContainersColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ImageResourceColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationTemplates.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/MainTabBasicListItemActionButton.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/ConsoleButtonCell.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/ImageButtonCell.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/TooltipCell.java 20 files changed, 320 insertions(+), 171 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaa25bbaddad4c6894abfa3b9e83f205ee9678a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix remove-quota test (#844652)
by gchaplik＠redhat.com 12 Aug '12

12 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: fix remove-quota test (#844652) ...................................................................... core: fix remove-quota test (#844652) https://bugzilla.redhat.com/844652 Fix the remove quota test. Change-Id: I1c190bf0dda99fca7034d9ecfc2dbc30f2e338aa Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c190bf0dda99fca7034d9ecfc2dbc30f2e338aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0