- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: backend: Fix 'remove-quota' canDo logic (#844652)
by gchaplik＠redhat.com 12 Aug '12

12 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: backend: Fix 'remove-quota' canDo logic (#844652) ...................................................................... backend: Fix 'remove-quota' canDo logic (#844652) https://bugzilla.redhat.com/844652 The logic of the remove-quota-command was wrong (old logic) It was fixed to support the folowing logic: - If quota is still in use by a VM or Disk Don't allow to delete the quota Change-Id: I0ed5166fc1b8fec94b3f90013ef76474f33b327d Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/dbscripts/quota_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 55 insertions(+), 13 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ed5166fc1b8fec94b3f90013ef76474f33b327d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Bad formatting in dialog (#835404)
by gchaplik＠redhat.com 12 Aug '12

12 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Bad formatting in dialog (#835404) ...................................................................... webadmin: Bad formatting in dialog (#835404) https://bugzilla.redhat.com/835404 When the user trys to "Configure local storage" and go to memory optimization sub tab he gets a corupted message contining missing formating values. i.e.: "Memory Page Sharing Threshold set to %1$s" instead of: "Memory Page Sharing Threshold set to 150%" The formating was not handelled when the item was not changed. So the message was not formated correctly. Change-Id: I36c34ce25b50697de7c1ee0165f13c05616605be Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.java 1 file changed, 20 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36c34ce25b50697de7c1ee0165f13c05616605be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: misleading info in edit quota (#838594)
by gchaplik＠redhat.com 12 Aug '12

12 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: misleading info in edit quota (#838594) ...................................................................... webadmin: misleading info in edit quota (#838594) https://bugzilla.redhat.com/838594 Change-Id: Ib9bc889f308743908dc103991868eb2db2bf34d0 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/EditQuotaClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/EditQuotaStoragePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java 5 files changed, 70 insertions(+), 62 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9bc889f308743908dc103991868eb2db2bf34d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ERROR: managed non pluggable device (#845207)
by yzaslavs＠redhat.com 12 Aug '12

12 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: ERROR: managed non pluggable device (#845207) ...................................................................... core: ERROR: managed non pluggable device (#845207) https://bugzilla.redhat.com/show_bug.cgi?id=845207 ERROR was a result of improper condition. Changing the condition to output the ERROR only when a managed & non pluggable device is removed by libvirt (which should not occur) Change-Id: I004efc973c3282680ef381939ed3c2299a6daac6 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I004efc973c3282680ef381939ed3c2299a6daac6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix removal of lun disk with no vm (#841265)
by derez＠redhat.com 12 Aug '12

12 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: core: fix removal of lun disk with no vm (#841265) ...................................................................... core: fix removal of lun disk with no vm (#841265) https://bugzilla.redhat.com/841265 when trying to delete a lun disk with no vm, NPE was encountered. this patch solves it and is a further fix to patch http://gerrit.ovirt.org/#/c/6505/ Change-Id: Iad5a09962da87d9e3f8d06685daf2f64ed751fd3 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad5a09962da87d9e3f8d06685daf2f64ed751fd3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: added ReconstructMasterDomain execution message (#8415...
by derez＠redhat.com 12 Aug '12

12 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: core: added ReconstructMasterDomain execution message (#841528) ...................................................................... core: added ReconstructMasterDomain execution message (#841528) the ReconstructMasterDomain message was added to bundles/ExecutionMessages https://bugzilla.redhat.com/841528 Change-Id: Ie3544fc7bd227cbe6ced860e6519d68daa5342c7 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3544fc7bd227cbe6ced860e6519d68daa5342c7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : NewTemplateVmModelBehavior - added Override annotatio...
by derez＠redhat.com 12 Aug '12

12 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: core : NewTemplateVmModelBehavior - added Override annotation ...................................................................... core : NewTemplateVmModelBehavior - added Override annotation InitStorageDomains() method was missing the Override annotation Change-Id: I4f7e226ca402a795d9cfc952c1b6dc08dea5f9f6 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f7e226ca402a795d9cfc952c1b6dc08dea5f9f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ImportVmCommand - changed method UpdateVmImSpm() name
by derez＠redhat.com 12 Aug '12

12 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: core: ImportVmCommand - changed method UpdateVmImSpm() name ...................................................................... core: ImportVmCommand - changed method UpdateVmImSpm() name changed the method's name to updateVmInSpm to meet java naming standards Change-Id: Id48b6283fdd06dd2d14046516b91caaf52771155 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id48b6283fdd06dd2d14046516b91caaf52771155 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: reomve redundant upgrade to config entry
by rgolan＠redhat.com 12 Aug '12

12 Aug '12

Roy Golan has submitted this change and it was merged. Change subject: core: reomve redundant upgrade to config entry ...................................................................... core: reomve redundant upgrade to config entry this upgrade is already handled in dbscripts/upgrade/preupgrade/000_config.sql Change-Id: I7b7700b75b2eaa42e8dadd9790b8a39cd0be6700 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- D backend/manager/dbscripts/upgrade/03_01_0820_add_domains_ldap_provider_types 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b7700b75b2eaa42e8dadd9790b8a39cd0be6700 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cannot replace management network nic (#840888)
by masayag＠redhat.com 12 Aug '12

12 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Cannot replace management network nic (#840888) ...................................................................... core: Cannot replace management network nic (#840888) https://bugzilla.redhat.com/840888 The patch allows to replace the underlying interface for the management network. It verifies no previous network is attached to the destination nic and also deny updating the management network to non-management network. Change-Id: Id8504509b0204ef4d16d7519f9bb57f519307614 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 38 insertions(+), 8 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8504509b0204ef4d16d7519f9bb57f519307614 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0