- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: cleanup: vds_installer: make main return boolean
by dfediuck＠redhat.com 04 Aug '12

04 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: cleanup: vds_installer: make main return boolean ...................................................................... cleanup: vds_installer: make main return boolean As discussed at [1], and due to a bug resulted in returning boolean from main instead of process exit value, main is modified to return boolean to reduce future mistakes. [1] http://gerrit.ovirt.org/6721 Change-Id: If90f3afbab7fe381a10d10861e5cac6fe2c89b92 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/conf/vds_installer.py 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If90f3afbab7fe381a10d10861e5cac6fe2c89b92 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>

1 0

Change in ovirt-engine[master]: vds_installer: set proper exit code when success
by dfediuck＠redhat.com 04 Aug '12

04 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: vds_installer: set proper exit code when success ...................................................................... vds_installer: set proper exit code when success return 'True' actually causes process to exit with non-zero code, hence failure. Change-Id: If0f666ab45fb68cb50e1415d4a47df176496a12f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/conf/vds_installer.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0f666ab45fb68cb50e1415d4a47df176496a12f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixed NPE during removal of floating disk (#845046)
by mlipchuk＠redhat.com 02 Aug '12

02 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: fixed NPE during removal of floating disk (#845046) ...................................................................... core: fixed NPE during removal of floating disk (#845046) https://bugzilla.redhat.com/show_bug.cgi?id=845046 when trying to remove a floating disk NPE was encountered beacuse of the use of NGuid.createGuidFromString (who can return null) instead of Guid.createGuidFromString who on DiskImageMapper. The current change provides null check and equality check to Guid.Empty in order to not affect other flows that count on null on that property. Change-Id: I6ffca77cc5a02558847366dd8ccb886ee515d612 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ffca77cc5a02558847366dd8ccb886ee515d612 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: do not send empty headers
by mpastern＠redhat.com 02 Aug '12

02 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: do not send empty headers ...................................................................... sdk: do not send empty headers Change-Id: Iae3cb4b352687e52ceaa1c59fa5deae67e4a6209 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/web/connection.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae3cb4b352687e52ceaa1c59fa5deae67e4a6209 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: codegen: implement http header support
by mpastern＠redhat.com 02 Aug '12

02 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: implement http header support ...................................................................... codegen: implement http header support Change-Id: I95b792f1e874625ffd9f043040a26a918b2676ad Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/collection/collection.py M src/codegen/collection/resource.py M src/codegen/doc/documentation.py M src/codegen/subcollection/subcollection.py M src/codegen/subcollection/subresource.py A src/codegen/utils/headerutils.py M src/ovirtsdk/infrastructure/brokers.py 7 files changed, 862 insertions(+), 424 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95b792f1e874625ffd9f043040a26a918b2676ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: refactor url params documentation
by mpastern＠redhat.com 02 Aug '12

02 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: refactor url params documentation ...................................................................... sdk: refactor url params documentation Change-Id: I4646639af9aa29c435bbe28f49cc84de14fefa96 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/utils/paramutils.py M src/ovirtsdk/infrastructure/brokers.py 2 files changed, 112 insertions(+), 108 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4646639af9aa29c435bbe28f49cc84de14fefa96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: rebase to latest api
by mpastern＠redhat.com 02 Aug '12

02 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latest api ...................................................................... sdk: rebase to latest api - removed disk.allow_snapshot param documentation - to network.update() added [@param network.name: string] - fixed vm/template os.boot documentation Change-Id: I86d2b7e23bdce46aa417b54e0c2919b8d1dd22f8 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 59 insertions(+), 54 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86d2b7e23bdce46aa417b54e0c2919b8d1dd22f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: change location of engine-manage-domains.log
by yzaslavs＠redhat.com 02 Aug '12

02 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: change location of engine-manage-domains.log ...................................................................... tools: change location of engine-manage-domains.log move engine-manage-domains.log to /var/log/ovirt-engine/ directory, so that the log collector will collect those logs. Change-Id: If4681557593662744f23f0ee32b67ca6d9ec6fda Signed-off-by: Yaniv Bronheim <ybronhei(a)redhat.com> --- M backend/manager/modules/utils/src/main/resources/engine-manage-domains/log4j.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4681557593662744f23f0ee32b67ca6d9ec6fda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Engine sets hosts to NonOperational based on cached in...
by mkublin＠redhat.com 02 Aug '12

02 Aug '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Engine sets hosts to NonOperational based on cached information (#844291) ...................................................................... core: Engine sets hosts to NonOperational based on cached information (#844291) https://bugzilla.redhat.com/844291 The following bug was caused because of the following flow: During process domain recovery engine can move host to Non Operation state ,at such case was cleaned only cache of storage domain, the cache of storage domains which were reported by that host as problematic was not cleaned Change-Id: I4fcfc9cf68131e80a481d8d1962f3afc1c30ae7c Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Kublin: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fcfc9cf68131e80a481d8d1962f3afc1c30ae7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Use DiskDAO instead DiskImageDAO (#844169)
by mlipchuk＠redhat.com 02 Aug '12

02 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Use DiskDAO instead DiskImageDAO (#844169) ...................................................................... engine: Use DiskDAO instead DiskImageDAO (#844169) https://bugzilla.redhat.com/844169 The following patch fix a bug where user cannot preview a snapshot when VM contains lun disk, same for remove a snapshot. This is because the fetch from the DAO is based on disk image instead of base disk since there can be lun disks in the VM. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ie87bf06a9156ffc36177d8ac7218541d8148811a --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie87bf06a9156ffc36177d8ac7218541d8148811a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0