- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: not vm networks appear in vnic edit dialog
by mkolesni＠redhat.com 02 Aug '12

02 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: not vm networks appear in vnic edit dialog ...................................................................... webadmin: not vm networks appear in vnic edit dialog https://bugzilla.redhat.com/842249 It is possible to configure Non VM Network on VM when editing the VNIC through edit dialog. Change-Id: Id15ca02adc86f7040c4dbeeda05c78a11f409a33 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/6820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id15ca02adc86f7040c4dbeeda05c78a11f409a33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: parameters in error mesaages
by mkolesni＠redhat.com 02 Aug '12

02 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: parameters in error mesaages ...................................................................... core: parameters in error mesaages https://bugzilla.redhat.com/840795 https://bugzilla.redhat.com/842295 Error message contained ${paramName} instead of the real value because the canDoActionErro didn't contain the real values. Change-Id: I6554b1498f09f8ff835b5f1d242557180cd4840d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkToVdsGroupCommand.java 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/6817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6554b1498f09f8ff835b5f1d242557180cd4840d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added Enable / Disable CIFS option feature
by ofrenkel＠redhat.com 02 Aug '12

02 Aug '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Added Enable / Disable CIFS option feature ...................................................................... engine: Added Enable / Disable CIFS option feature - Added the new cifs configuration constant 'trusted.cifs.disable'. - Enable / Disable the cifs using the constant key Change-Id: I761a43e99a67d59b42e58d4bcc8b3db536fa7a41 Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java 3 files changed, 9 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/6397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I761a43e99a67d59b42e58d4bcc8b3db536fa7a41 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: implement mandatory/optional header def in RSDL
by mpastern＠redhat.com 02 Aug '12

02 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: implement mandatory/optional header def in RSDL ...................................................................... restapi: implement mandatory/optional header def in RSDL Change-Id: I34ba91f2faf11e51ea8e8954ff5c6fb74e6cf4e8 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/ParamData.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/Request.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java 5 files changed, 284 insertions(+), 131 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34ba91f2faf11e51ea8e8954ff5c6fb74e6cf4e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: http header should start with capital letter
by mpastern＠redhat.com 02 Aug '12

02 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: http header should start with capital letter ...................................................................... restapi: http header should start with capital letter Change-Id: I01eba956c0cc9f377cab31a715d2d3f1c5d04e2f Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java 5 files changed, 22 insertions(+), 19 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01eba956c0cc9f377cab31a715d2d3f1c5d04e2f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.1]: core: vms with shared disk will pause ...(#834893)
by emesika＠redhat.com 01 Aug '12

01 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core: vms with shared disk will pause ...(#834893) ...................................................................... core: vms with shared disk will pause ...(#834893) https://bugzilla.redhat.com/show_bug.cgi?id=834893 vdsm: vms with shared disk will pause due to I/O errors on double use of PCI Address The main fix to this bug is on the vdsm (separate patch will be sent ), this patch simplifies the vdsm patch code since we assume that disk, floppy and CD will set the shared flag. Change-Id: Ic3f5b74544aec23c8953726b40d6cf4bbcff5019 Signed-off-by: Eli Mesika <emesika(a)redhat.com> (cherry picked from commit e548c72ee1d9275d363c025ae8d61f4990a8445b) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3f5b74544aec23c8953726b40d6cf4bbcff5019 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixup Juno-Maven integration
by derez＠redhat.com 01 Aug '12

01 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Fixup Juno-Maven integration ...................................................................... core: Fixup Juno-Maven integration Fixup for the frontend's Juno support which was lost in a rebase. Change-Id: I23f53de4bfb9ba5818ec1fd53a79b2dba8ef539d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/pom.xml M frontend/webadmin/modules/frontend/pom.xml 2 files changed, 1 insertion(+), 11 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/6834 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23f53de4bfb9ba5818ec1fd53a79b2dba8ef539d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: import block storage domains - fix refresh
by derez＠redhat.com 01 Aug '12

01 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: import block storage domains - fix refresh ...................................................................... webadmin: import block storage domains - fix refresh https://bugzilla.redhat.com/842147 https://bugzilla.redhat.com/843057 Import block Storage Domain: fixing refresh for 'GetExistingStorageDomainList' and 'DiscoverSendTargets' queries. Change-Id: I720d2bb6f2d3a7f7dd228c5337f908b6deab0bb0 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportSanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 4 files changed, 32 insertions(+), 45 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I720d2bb6f2d3a7f7dd228c5337f908b6deab0bb0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Prevent migrating paused VM
by rgolan＠redhat.com 01 Aug '12

01 Aug '12

Roy Golan has submitted this change and it was merged. Change subject: core: Prevent migrating paused VM ...................................................................... core: Prevent migrating paused VM Migrating a paused VM is currently not supported. Added: canDoAction on migration of a paused VM Tested: Running a VM in paused mode and failing to migrate it Have a host with a VM in paused mode, try to Maintenance it, see that its "Preparing For Maintenance" and pending this VM to be stopped/continued. Change-Id: Ib13179ca22f3e00fc73ad91fd6ade1cab83b82d4 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 16 insertions(+), 7 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib13179ca22f3e00fc73ad91fd6ade1cab83b82d4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: VDSM reports iface for network devices
by masayag＠redhat.com 01 Aug '12

01 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: VDSM reports iface for network devices ...................................................................... core: VDSM reports iface for network devices The patch adds support for 3.2 cluster level agents which reports the 'iface' attribute for network devices. Change-Id: Ic8fe367a044122ef62cafe55b13eb34ef7829bab Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 3 files changed, 4 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8fe367a044122ef62cafe55b13eb34ef7829bab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0