- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-service - Fix non-standard port redirectio...
by oschreib＠redhat.com 01 Aug '12

01 Aug '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service - Fix non-standard port redirection (BZ#844386) ...................................................................... packaging: engine-service - Fix non-standard port redirection (BZ#844386) Fix HTTP to HTTPS redirection when the engine uses non-standard ports by setting the "port-redirect" attribure the the service configuration file. Change-Id: I868f638b7681b88af33c6bf10b740ab5ce3bdcab Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/fedora/engine-service.xml.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I868f638b7681b88af33c6bf10b740ab5ce3bdcab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fix matching of empty list
by mkolesni＠redhat.com 01 Aug '12

01 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Fix matching of empty list ...................................................................... restapi: Fix matching of empty list If empty list is expected in test, then the matcher would fail because it contains no elements and the default return value is initialized to 'false'. Changed default initialization of the return value to 'true' so that it will be changed to false in the objects are found inequal. No other change is necessary in this regard, since the method already handles it. Change-Id: If9144c448881d9373c22c69bd7d222ab88b59f2a Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/test/util/TestHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9144c448881d9373c22c69bd7d222ab88b59f2a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add sync networks to Setup Networks (#838300)
by mkolesni＠redhat.com 01 Aug '12

01 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add sync networks to Setup Networks (#838300) ...................................................................... engine: Add sync networks to Setup Networks (#838300) https://bugzilla.redhat.com/838300 Added list of networks that need to be synced to SetupNetworks parameters. The list allows to specify which networks should be synched. Setup Networks will now sync the network if it needs to be synched (i.e. specified on the list), but if network is unsynched then it's not allowed to be edited until it's synched. Change-Id: I433e684f09b104c8eda82b21129bba3e019c58d6 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java 3 files changed, 256 insertions(+), 11 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I433e684f09b104c8eda82b21129bba3e019c58d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add error message for network not in sync (#838300)
by mkolesni＠redhat.com 01 Aug '12

01 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add error message for network not in sync (#838300) ...................................................................... core: Add error message for network not in sync (#838300) https://bugzilla.redhat.com/838300 Network that is not in sync cannot be edited, so added an error message that will be returned when this situation is encountered. Change-Id: Ie9cd53730328723aa7f712adb72a4c5ed1f74440 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 7 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9cd53730328723aa7f712adb72a4c5ed1f74440 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add create from network to tests
by mkolesni＠redhat.com 01 Aug '12

01 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add create from network to tests ...................................................................... engine: Add create from network to tests This method is needed to create initially a NIC that is synchronized to the network which is on it. Change-Id: I511d6cce0d906f1482d9c975e7037341d9cb8d69 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java 1 file changed, 35 insertions(+), 13 deletions(-) Approvals: Mike Kolesnik: Verified Livnat Peer: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I511d6cce0d906f1482d9c975e7037341d9cb8d69 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fill network details of host NICs query (#838300)
by mkolesni＠redhat.com 01 Aug '12

01 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Fill network details of host NICs query (#838300) ...................................................................... engine: Fill network details of host NICs query (#838300) https://bugzilla.redhat.com/838300 Added filling of the details in the query. Change-Id: Ie6f3948a39a424364a2a796fbbb57d881ae341f3 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsInterfacesByVdsIdQuery.java 1 file changed, 21 insertions(+), 9 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6f3948a39a424364a2a796fbbb57d881ae341f3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Change query to iterate using foreach
by mkolesni＠redhat.com 01 Aug '12

01 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Change query to iterate using foreach ...................................................................... engine: Change query to iterate using foreach Changed GetVdsInterfacesByVdsIdQuery to iterate over interfaces using foreach, so that network details can be filled per interface. Change-Id: I79ec5babb9cb0a2166cc18b5617f1ce944fdd722 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsInterfacesByVdsIdQuery.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79ec5babb9cb0a2166cc18b5617f1ce944fdd722 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: filtering rsdl according to ApplicationMode
by mpastern＠redhat.com 01 Aug '12

01 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: filtering rsdl according to ApplicationMode ...................................................................... restapi: filtering rsdl according to ApplicationMode The rsdl response will be filtered according to the Application Mode. In Gluster Only mode http://hostname/api?rsdl will return only gluster related links and common links(host,cluster,etc). Change-Id: I63a244c5b751d0d77113a5bbdb254bae20f5457e Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/6194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63a244c5b751d0d77113a5bbdb254bae20f5457e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Update Storage-Domain - handle type
by oliel＠redhat.com 01 Aug '12

01 Aug '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Update Storage-Domain - handle type ...................................................................... restapi: Update Storage-Domain - handle type restapi does not have 'Master' data type. A storage-domain of type master is simply displayed as data. When user updates a storage-domain, he might send back <type>data</type>. Backend would fail this, because it looks like the user is updating the type field, which is forbidden (because the old value is 'master', and user gave 'data'). This patch intercepts the update and replaces 'master' back to 'data' if needed, so that the backend won't fail on ilegal update Change-Id: Iabaaa2d262a55e073d4aebe32ac76bbc9ab92d0d Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabaaa2d262a55e073d4aebe32ac76bbc9ab92d0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Replacing StringHelper with StringUtils.
by masayag＠redhat.com 01 Aug '12

01 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Replacing StringHelper with StringUtils. ...................................................................... core: Replacing StringHelper with StringUtils. StringHelper is deprecated. Change-Id: Ie96f2fca903ef919f617981feef023dfb23ce850 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingNFSStorageDomainCommand.java 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie96f2fca903ef919f617981feef023dfb23ce850 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0