- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: Fix ownership of lock directory
by oourfali＠redhat.com 06 Jun '12

06 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: Fix ownership of lock directory ...................................................................... packaging: Fix ownership of lock directory The directory /var/lock/ovirt-engine should be owned by the ovirt user and group, and it is created that way during the installation of the package, but changed later during systemctl startup as specified in the /etc/tmpfiles.d/ovirt-engine.conf file. This patch changes that file so that the directory is owned by ovirt and not jboss-as. Change-Id: I6841dfd987ca7c02c699fcce283a2fcc7e957b88 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/resources/ovirt-tmpfilesd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6841dfd987ca7c02c699fcce283a2fcc7e957b88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Rename ITDSDSGroupAttributes.java to ITDSGroupAttrib...
by oourfali＠redhat.com 06 Jun '12

06 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Rename ITDSDSGroupAttributes.java to ITDSGroupAttributes.java ...................................................................... engine: Rename ITDSDSGroupAttributes.java to ITDSGroupAttributes.java There was a typo in this class name in the original post which added support for IBM Tivoli Directory Server. This patch fixes the typo. Change-Id: If423c1b39773f2822b5eef54610f42bb65e13987 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSGroupAttributes.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSGroupContextMapper.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sharad Mishra: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If423c1b39773f2822b5eef54610f42bb65e13987 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: rest: fix NicMappterTest build error
by oliel＠redhat.com 06 Jun '12

06 Jun '12

Ori Liel has submitted this change and it was merged. Change subject: rest: fix NicMappterTest build error ...................................................................... rest: fix NicMappterTest build error Change-Id: I618c1242d75ebdfa07f378f62f1d77ee84c32fca Signed-off-by: Shahar Havivi<shavivi(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NicMapperTest.java 1 file changed, 23 insertions(+), 23 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/5103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I618c1242d75ebdfa07f378f62f1d77ee84c32fca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: removed tabs and trailing white spaces
by ydary＠redhat.com 06 Jun '12

06 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: removed tabs and trailing white spaces ...................................................................... reports: removed tabs and trailing white spaces Change-Id: I20df74f3af6fbbe4a478ecef5402f9890d9c49e7 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/Reports.xml M reports/repository_files/resources/Reports/Executive/active_vms_by_os_br18_files/active_vms_by_os_br18_jrxml.data M reports/repository_files/resources/Reports/Executive/cluster_capactity_vs_usage_br19_files/cluster_capactity_vs_usage_br19_jrxml.data M reports/repository_files/resources/Reports/Executive/host_os_break_down_BR22_files/host_os_break_down_BR22_jrxml.data M reports/repository_files/resources/Reports/Executive/summary_of_host_usage_resources_br17_files/summary_of_host_usage_resources_br17_jrxml.data M reports/repository_files/resources/Reports/Inventory/Storage_Domain_Report_BR21_files/Storage_Domain_Report_BR21_jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/br7_table.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/cluster_uptime_br7_jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/single_host_uptime_br8_files/single_host_uptime_br8_jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/top_10_downtime_hosts_br7b_jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/cluster_quality_of_service_vms_br13_files/cluster_quality_of_service_vms_br13_jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/br14_table.jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/virtual_servers_uptime_br14_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/five_least_utilized_hosts_br5_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/multiple_hosts_resource_usage_br3_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_br2a_files/single_host_resource_br2a_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/single_host_resource_usage_dow_br2b.data M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/single_host_resource_usage_hour_of_day_br2c_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/five_least_utilized_vms_Over_Time_BR12_files/five_least_utilized_vms_Over_Time_BR12_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/five_most_utilized_vms_over_time_br11_files/five_most_utilized_vms_over_time_br11_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/multiple_vms_resource_usage_over_time_br16_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_days_week_BR10B_files/single_vm_resources_days_week_BR10B_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_hour_of_day_BR10c_files/single_vm_resources_hour_of_day_BR10c_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/single_vm_resources_over_time_BR10A_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/Host_OS_Break_Down_BR22B_for_inventory_files/Host_OS_Break_Down_BR22B_for_inventory_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/active_entities_by_os_BR18A_files/active_entities_by_os_BR18A_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/storage_domain_by_Datacenter_BR23_files/storage_domain_by_Datacenter_BR23_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/System_Overview_Dashboard/summary_of_host_usage_resources_br17_files/summary_of_host_usage_resources_br17_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Trends_Dashboard/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Trends_Dashboard/five_most_utilized_vms_over_time_br11_files/five_most_utilized_vms_over_time_br11_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/cluster_uptime_by_datacenter_br7a_files/cluster_uptime_by_datacenter_br7a_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/virtual_servers_uptime_by_cluster_br14a_files/virtual_servers_uptime_by_cluster_br14a_jrxml.data 33 files changed, 1,460 insertions(+), 1,460 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20df74f3af6fbbe4a478ecef5402f9890d9c49e7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: NPE when there is no Blank template
by gchaplik＠redhat.com 06 Jun '12

06 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: NPE when there is no Blank template ...................................................................... userportal: NPE when there is no Blank template The problem was, that the it was expected, that there has to be always a blank template. If there was not, an empty instance of VmTemplate has been added to the list of templates which could cause NPEs. Solved by adding the blank template to the beginning of the list only if it is defined (in AsyncDataProvider and UserPortalNewVmModelBehavior). The corresponding method from DataProvider has been deleted as it was never used (and is synchronous which has no meaning in GWT world) Change-Id: Ib7ae99cfb3bd663b6fdce373501bed98152b8b6d Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java 3 files changed, 30 insertions(+), 98 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7ae99cfb3bd663b6fdce373501bed98152b8b6d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: updated embedded reports.
by ydary＠redhat.com 06 Jun '12

06 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: updated embedded reports. ...................................................................... reports: updated embedded reports. embedded reports now use period affected input controls. Change-Id: Ib002195ce81aac8fb43f53eb5c29475527f0d237 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/embedded_reports/.folder.xml D reports/repository_files/resources/reports_resources/embedded_reports/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data D reports/repository_files/resources/reports_resources/embedded_reports/Host_OS_Break_Down_BR22B_for_inventory_files/Host_OS_Break_Down_BR22B_for_inventory_jrxml.data A reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/.folder.xml R reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/Host_OS_Break_Down_BR22B_for_inventory.xml A reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/Host_OS_Break_Down_BR22B_for_inventory_files/Host_OS_Break_Down_BR22B_for_inventory_jrxml.data R reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/active_entities_by_os_BR18A.xml A reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/active_entities_by_os_BR18A_files/active_entities_by_os_BR18A_jrxml.data R reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/storage_domain_by_Datacenter_BR23.xml A reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/storage_domain_by_Datacenter_BR23_files/storage_domain_by_Datacenter_BR23_jrxml.data A reports/repository_files/resources/reports_resources/embedded_reports/System_Overview_Dashboard/.folder.xml R reports/repository_files/resources/reports_resources/embedded_reports/System_Overview_Dashboard/datacenter_quality_of_service_hosts_br6b.xml R reports/repository_files/resources/reports_resources/embedded_reports/System_Overview_Dashboard/datacenter_quality_of_service_hosts_br6b_files/datacenter_quality_of_service_hosts_br6b_jrxml.data R reports/repository_files/resources/reports_resources/embedded_reports/System_Overview_Dashboard/summary_of_host_usage_resources_br17.xml A reports/repository_files/resources/reports_resources/embedded_reports/System_Overview_Dashboard/summary_of_host_usage_resources_br17_files/summary_of_host_usage_resources_br17_jrxml.data A reports/repository_files/resources/reports_resources/embedded_reports/Trends_Dashboard/.folder.xml R reports/repository_files/resources/reports_resources/embedded_reports/Trends_Dashboard/Five_most_utilized_hosts_over_time.xml A reports/repository_files/resources/reports_resources/embedded_reports/Trends_Dashboard/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data R reports/repository_files/resources/reports_resources/embedded_reports/Trends_Dashboard/five_most_utilized_vms_over_time_br11.xml A reports/repository_files/resources/reports_resources/embedded_reports/Trends_Dashboard/five_most_utilized_vms_over_time_br11_files/five_most_utilized_vms_over_time_br11_jrxml.data A reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/.folder.xml R reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/cluster_uptime_by_datacenter_br7a.xml R reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/cluster_uptime_by_datacenter_br7a_files/cluster_uptime_by_datacenter_br7a_jrxml.data R reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/cluster_uptime_by_datacenter_br7a_files/report5.jrxml.data R reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/virtual_servers_uptime_by_cluster_br14a.xml R reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/virtual_servers_uptime_by_cluster_br14a_files/report5.jrxml.data R reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/virtual_servers_uptime_by_cluster_br14a_files/virtual_servers_uptime_by_cluster_br14a_jrxml.data D reports/repository_files/resources/reports_resources/embedded_reports/active_entities_by_os_BR18A_files/active_entities_by_os_BR18A_jrxml.data D reports/repository_files/resources/reports_resources/embedded_reports/five_most_utilized_vms_over_time_br11_files/five_most_utilized_vms_over_time_br11_jrxml.data D reports/repository_files/resources/reports_resources/embedded_reports/storage_domain_by_Datacenter_BR23_files/storage_domain_by_Datacenter_BR23_jrxml.data D reports/repository_files/resources/reports_resources/embedded_reports/summary_of_host_usage_resources_br17_files/summary_of_host_usage_resources_br17_jrxml.data 31 files changed, 1,468 insertions(+), 1,457 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib002195ce81aac8fb43f53eb5c29475527f0d237 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: report: changed datasource defaults
by ydary＠redhat.com 06 Jun '12

06 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: report: changed datasource defaults ...................................................................... report: changed datasource defaults Change-Id: I0f3b0be29d3c21580091f5042eee27b82355881d Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/JDBC/data_sources/ovirt.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f3b0be29d3c21580091f5042eee27b82355881d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: changed input controls problemtic value
by ydary＠redhat.com 06 Jun '12

06 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: changed input controls problemtic value ...................................................................... reports: changed input controls problemtic value JRS has a problem with the expression '**', since it's used for delimiting in input control. This changes value to '--' and resolve this issue. Change-Id: I80ce6fbe96a9a7975590454d07de9986fab34420 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/is_deleted.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Hosts/active_hosts_select.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Storage/active_storage.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_VMs/Active_VMs.xml 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80ce6fbe96a9a7975590454d07de9986fab34420 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: removed vm disk internal drive mapping
by ydary＠redhat.com 06 Jun '12

06 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: history: removed vm disk internal drive mapping ...................................................................... history: removed vm disk internal drive mapping Change-Id: I977871555c592d1531a0f8687a758f0abb272df9 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/configurationsync_3_0/ConfigurationSync.java M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.0.item M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.0.properties M data-warehouse/history_etl/tos_project/talend.project M data-warehouse/historydbscripts_postgres/create_views.sql 5 files changed, 561 insertions(+), 729 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I977871555c592d1531a0f8687a758f0abb272df9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Failed to activate host on 3.0 cluster (#828970)
by masayag＠redhat.com 06 Jun '12

06 Jun '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Failed to activate host on 3.0 cluster (#828970) ...................................................................... core: Failed to activate host on 3.0 cluster (#828970) https://bugzilla.redhat.com/828970 Bridge-less feature assumes that of the "bridged" property wasn't provided or provided as null, the network should be bridge-less. This assumption causes older VDSM version reported networks to be wrongfully declared as bridge-less. The patch sets the network to be bridged, if no property was specified from vdsm. Change-Id: I5dd846340ea15454e582be44e6249f4eda888843 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/5081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dd846340ea15454e582be44e6249f4eda888843 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0