- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: cleanup AddVmCommand
by dfediuck＠redhat.com 06 Jun '12

06 Jun '12

Doron Fediuck has submitted this change and it was merged. Change subject: cleanup AddVmCommand ...................................................................... cleanup AddVmCommand A minor cleanup in AddVmCommand Change-Id: If5244f873117eae5df1eaa5ca3c8164e6bdd5c45 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 3 files changed, 6 insertions(+), 5 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5244f873117eae5df1eaa5ca3c8164e6bdd5c45 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : fix IsBalloonEnabledQueryTest
by emesika＠redhat.com 06 Jun '12

06 Jun '12

Eli Mesika has submitted this change and it was merged. Change subject: core : fix IsBalloonEnabledQueryTest ...................................................................... core : fix IsBalloonEnabledQueryTest Change the IsBalloonEnabledQueryTest class to inherit from the right class. (was implemented by mistake as a user query) Change-Id: I1b4f44024a622f34290f37e6a2c1c4b21ad3b316 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/IsBalloonEnabledQueryTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b4f44024a622f34290f37e6a2c1c4b21ad3b316 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing connections psql functions
by yzaslavs＠redhat.com 06 Jun '12

06 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing connections psql functions ...................................................................... core: Fixing connections psql functions Fixing relevant insert and update pgsql functions, to reflect introduction of version,retrans and timeo Change-Id: I4e2fc0bdee7be85765d380ed0e6c998c030f95e3 Acked-By: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/storages_san_sp.sql 1 file changed, 13 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e2fc0bdee7be85765d380ed0e6c998c030f95e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Update only cluster id in addParents
by mpastern＠redhat.com 06 Jun '12

06 Jun '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Update only cluster id in addParents ...................................................................... restapi: Update only cluster id in addParents Modified BackendGlusterVolumesResource#addParents to update only cluster id instead of whole object, so that it appears as link to parent cluster instead of whole element in the REST xml output. Change-Id: I2e5b5dcdf1109b60fbb492299029624a0835199c Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResource.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Shireesh Anjal: Verified -- To view, visit http://gerrit.ovirt.org/5016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e5b5dcdf1109b60fbb492299029624a0835199c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix restore from snapshot
by oourfali＠redhat.com 06 Jun '12

06 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix restore from snapshot ...................................................................... core: fix restore from snapshot A previous commit (cd3dedff2755753a77da01ecf86332c4576a9acc) removed the code that removes all devices, and added code that only removes disks that are allowed to be in a snapshot. This caused the devices to be duplicated on every snapshot restore. This patch fixes this, and removes all devices besides disks that are not on snapshots. Change-Id: I7866d0c55153b65023e18075bb57bd7fdfbe78f4 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7866d0c55153b65023e18075bb57bd7fdfbe78f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup in VmInfoBuilderBase
by lhornyak＠redhat.com 06 Jun '12

06 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup in VmInfoBuilderBase ...................................................................... core: cleanup in VmInfoBuilderBase Replaced !StringUtils.isEmpty with a more readable StringUtils.isNotEmpty. Change-Id: Ia9e49a6aa3fe6f04e24f0298f347067aa42a9f9c Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9e49a6aa3fe6f04e24f0298f347067aa42a9f9c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add memory balloon device support
by dfediuck＠redhat.com 06 Jun '12

06 Jun '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: add memory balloon device support ...................................................................... core: add memory balloon device support This is the core patch that add support of a Memory Balloon device as a managed device that is added by default to each new VM. (REST API & Web Admin patches should follow) REST API & Web Admin should set the VM isBalloonEnabled property using the IsBalloonEnabled Query Please see more details about this feature at http://www.ovirt.org/wiki/Features/Design/memory-balloon Change-Id: Idc2fed44feb3718b72f163755271ddc07b201265 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/vm_device_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsBalloonEnabledQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/IsBalloonEnabledQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java 19 files changed, 249 insertions(+), 46 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc2fed44feb3718b72f163755271ddc07b201265 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Missing gateway field when creating bond (#815415)
by masayag＠redhat.com 06 Jun '12

06 Jun '12

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Missing gateway field when creating bond (#815415) ...................................................................... webadmin: Missing gateway field when creating bond (#815415) https://bugzilla.redhat.com/815415 Bond button for "rhevm" network with vlan tagging does not provide default gateway field. Problem is originated due to wrong resolution of the management network when it is on top of a VLAN. This causes the gateway field not to appear. With this patch, the gateway field appears and the default values for the Static IP protocol are the same as were for the management network interface, those fields are editable. Change-Id: I42547ef630feda19f520b0eda99bf58d31db4a24 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42547ef630feda19f520b0eda99bf58d31db4a24 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add support for IBM Tivoli Directory Server.
by rgolan＠redhat.com 05 Jun '12

05 Jun '12

Roy Golan has submitted this change and it was merged. Change subject: engine: Add support for IBM Tivoli Directory Server. ...................................................................... engine: Add support for IBM Tivoli Directory Server. This patch adds support for an LDAP server from IBM. Change-Id: Iffe980022787936fc79370104bb7f5c1129f0ce5 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSDSGroupAttributes.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSGroupContextMapper.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSLdapGuidEncoder.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSRootDSE.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSRootDSEAttributes.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSRootDSEContextMapper.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSUserAttributes.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSUserContextMapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapVendorNameEnum.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RootDSEFactory.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapProviderType.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapVendorNameEnum.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ipa/ITDSUserContextMapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ipa/SimpleAuthenticationCheck.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 17 files changed, 505 insertions(+), 35 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffe980022787936fc79370104bb7f5c1129f0ce5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Fixing diskId at MoveOrCopyDiskCommand
by mkublin＠redhat.com 05 Jun '12

05 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core : Fixing diskId at MoveOrCopyDiskCommand ...................................................................... core : Fixing diskId at MoveOrCopyDiskCommand We should use a diskId in order to get lock on disk object and not imageId Change-Id: Ib7876270edd3b1447f03da6549b898986889ab1f Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7876270edd3b1447f03da6549b898986889ab1f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0