- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove redundant initializer
by mlipchuk＠redhat.com 31 Oct '16

31 Oct '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove redundant initializer ...................................................................... core: Remove redundant initializer Change-Id: I88e5a23a0c7718be1320bd590cc56460d36e8b40 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/65868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88e5a23a0c7718be1320bd590cc56460d36e8b40 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Add POSIX domain creation to Data Center "Guide Me"
by tnisan＠redhat.com 31 Oct '16

31 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add POSIX domain creation to Data Center "Guide Me" ...................................................................... webadmin: Add POSIX domain creation to Data Center "Guide Me" Bug-Ur: https://bugzilla.redhat.com/1359943 Change-Id: I17b26369caea5471af29febd2afecd4b371d5d0c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 127 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17b26369caea5471af29febd2afecd4b371d5d0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: service: Disable stdout capture in systemd
by msivak＠redhat.com 31 Oct '16

31 Oct '16

Martin Sivák has submitted this change and it was merged. Change subject: service: Disable stdout capture in systemd ...................................................................... service: Disable stdout capture in systemd Standard output for agent and broker system services disabled to prevent log duplications and keep logging only to the custom log files (agent and broker logs) Change-Id: I65b49fad3a2a915019231341e64d161aad9d4660 Bug-Url: https://bugzilla.redhat.com/1376559 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M initscripts/ovirt-ha-agent.service.in M initscripts/ovirt-ha-broker.service.in 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/65800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65b49fad3a2a915019231341e64d161aad9d4660 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: fix custom compatibility version field setting
by tjelinek＠redhat.com 31 Oct '16

31 Oct '16

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: fix custom compatibility version field setting ...................................................................... frontend: fix custom compatibility version field setting Fix the UI behaviour of both webadmin and userportal for setting the VM->System tab->Custom compatibility version (CCV) drop down menu to avoid refreshing and reseting the value after manually changing it by the user. Changing the CCV field value for a VM/pool/template (choosing a different value from pool down menu), causes few VM fields values to be reseted and refreshed back to template defaults. this fix avoid from the CCV field itself to be reseted as well. This change influence the template field and CCV field behaviour for the following use cases: New VM New VM from Template New pool Edit pool Change-Id: I4e20cdb868740241338d007686adf9f8d780bb61 Bug-Url: https://bugzilla.redhat.com/1367405 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmFromTemplateModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 8 files changed, 65 insertions(+), 15 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/65809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e20cdb868740241338d007686adf9f8d780bb61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant space from comment.
by mlipchuk＠redhat.com 31 Oct '16

31 Oct '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove redundant space from comment. ...................................................................... core: Remove redundant space from comment. Change-Id: I7efb92df42ef223513fe00a275d9ddb0e780646f Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Amit Aviram: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7efb92df42ef223513fe00a275d9ddb0e780646f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: upload: drop persist call after scheduling a disk creation.
by amureini＠redhat.com 31 Oct '16

31 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: upload: drop persist call after scheduling a disk creation. ...................................................................... upload: drop persist call after scheduling a disk creation. When executing an image upload without supplying a disk, A disk creation is called using CoCo, which automatically causing the command to be persisted. This patch drops the redundant "persistCommand" call after the disk creation call. Change-Id: Ic735cd9114032eeeef7ddf26acc39db5a3050048 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Amit Aviram: Verified Allon Mureinik: Looks good to me, but someone else must approve; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic735cd9114032eeeef7ddf26acc39db5a3050048 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: upload: Indent switch case blocks
by amureini＠redhat.com 31 Oct '16

31 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: upload: Indent switch case blocks ...................................................................... upload: Indent switch case blocks Indent them! Change-Id: I5174990b806ceac51e1337a6e6d832313fab932c Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java 1 file changed, 43 insertions(+), 43 deletions(-) Approvals: Amit Aviram: Verified Allon Mureinik: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5174990b806ceac51e1337a6e6d832313fab932c Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add a multi argument constructor in DiskImagesValidator.
by amureini＠redhat.com 31 Oct '16

31 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Add a multi argument constructor in DiskImagesValidator. ...................................................................... core: Add a multi argument constructor in DiskImagesValidator. Currently many clients of DiskImagesValidator use it for a single DiskImage, manipulating the disk image sent to a List in order to use it. Add a multi argument constructor to DiskImagesValidator, so it can be used for a small amount of disk images, or a single one. Change-Id: Id8562b7a00386c5180cb8b4499de0f7e33c72de9 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskAlignmentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ExportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java 5 files changed, 10 insertions(+), 6 deletions(-) Approvals: Amit Aviram: Verified Allon Mureinik: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8562b7a00386c5180cb8b4499de0f7e33c72de9 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add image transfer support.
by amureini＠redhat.com 31 Oct '16

31 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Add image transfer support. ...................................................................... restapi: Add image transfer support. Add image transfer support. Change-Id: I5ebc6dbbf7d869f5a853a1c0822c775a2b5d4369 Bug-Url: https://bugzilla.redhat.com/1337077 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/ImageTransfer.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransferResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransfersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ApiOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ImageTransferMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ImageTransferMapperTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskUploadImageProgressColumn.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties 18 files changed, 285 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved; Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/63257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ebc6dbbf7d869f5a853a1c0822c775a2b5d4369 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: upload: Add queries for image transfer entity
by amureini＠redhat.com 31 Oct '16

31 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: upload: Add queries for image transfer entity ...................................................................... upload: Add queries for image transfer entity Add: * GetImageTransferByIdQuery * GetAllImageTransfersQuery Change-Id: I96752e1b6caa19d45a40561c2455dd90a4010f07 Bug-Url: https://bugzilla.redhat.com/1337077 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetAllImageTransfersQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetImageTransferByIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/ImageTransfer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/SearchType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDaoImpl.java 8 files changed, 68 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96752e1b6caa19d45a40561c2455dd90a4010f07 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0