- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: upload: Support supplied image for an image transfer.
by amureini＠redhat.com 31 Oct '16

31 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: upload: Support supplied image for an image transfer. ...................................................................... upload: Support supplied image for an image transfer. For REST API support, we want to be able to execute the upload command with a supplied image. Currently when executing the command, the image is created. This patch will create the image only if no image was supplied, otherwise, set needed parameters for the command according to the supplied image. Add tests for the upload command, verifying this change. Change-Id: I41066d1b8d2d7b18e4ceb12e1754b99189b3b258 Bug-Url: https://bugzilla.redhat.com/1337077 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UploadImageParameters.java 5 files changed, 383 insertions(+), 22 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41066d1b8d2d7b18e4ceb12e1754b99189b3b258 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: image upload: don't expose resource ID to entity updates.
by amureini＠redhat.com 31 Oct '16

31 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: image upload: don't expose resource ID to entity updates. ...................................................................... image upload: don't expose resource ID to entity updates. Resource ID is used for identifying the upload tickets. once the ability of clearing it is exposed for the frontend/REST, it can potentially cause loss of a transfer session, opening up security risks. Remove this member from the image transfer updates entity, and set it as a parameter for the backend ImageTransferUpdater class. Change-Id: Iee39b43faea82a4737919de0c39acba4b2b60b26 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImageTransferUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UploadImageStatusParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/ImageTransferUpdates.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 7 files changed, 24 insertions(+), 79 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee39b43faea82a4737919de0c39acba4b2b60b26 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Introduce DiskValidatior#isAttachedToAnyVM
by amureini＠redhat.com 31 Oct '16

31 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Introduce DiskValidatior#isAttachedToAnyVM ...................................................................... core: Introduce DiskValidatior#isAttachedToAnyVM Add a validation to check if a disk is connected to any VM. Change-Id: I50fdba592b56db01e7be2b2b1d6086e941d43808 Bug-Url: https://bugzilla.redhat.com/1337077 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 45 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63253 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50fdba592b56db01e7be2b2b1d6086e941d43808 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup unnecessary modifiers in IOvfBuilder
by rgolan＠redhat.com 31 Oct '16

31 Oct '16

Roy Golan has submitted this change and it was merged. Change subject: core: cleanup unnecessary modifiers in IOvfBuilder ...................................................................... core: cleanup unnecessary modifiers in IOvfBuilder Change-Id: I02b494e3220e49704bab184f241a8acb63cacef5 Bug-Url: https://bugzilla.redhat.com/1358383 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02b494e3220e49704bab184f241a8acb63cacef5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move OvfManager to bll
by rgolan＠redhat.com 31 Oct '16

31 Oct '16

Roy Golan has submitted this change and it was merged. Change subject: core: Move OvfManager to bll ...................................................................... core: Move OvfManager to bll OvfManager is a tool used by the bll layer and adds abstraction and exposes an API to export VM and Templates. Moving it to bll will allow extending and enriching the information added to the OVF without constantly expending the structures and arguments. The following patch is adding a specialized OVF writer for hosted engine and will use the OvfManager access to the DAL layer. Change-Id: I4d82408f10de3e6172e8cce4044d5a8b58f36afc Bug-Url: https://bugzilla.redhat.com/1358383 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d82408f10de3e6172e8cce4044d5a8b58f36afc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: utils: Encapsulte OVF build algo into OvfBuilder
by rgolan＠redhat.com 31 Oct '16

31 Oct '16

Roy Golan has submitted this change and it was merged. Change subject: utils: Encapsulte OVF build algo into OvfBuilder ...................................................................... utils: Encapsulte OVF build algo into OvfBuilder The steps to build the OVF where called outside by the OvfManager. Its the responsiblity of the Object to build its internal structure and so it is encapsulated into it, making the API safer, easier and cleaner. Change-Id: I427aa4e9ada86c59e4d7cf999dbdb23aaaa44581 Bug-Url: https://bugzilla.redhat.com/1358383 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java 2 files changed, 12 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I427aa4e9ada86c59e4d7cf999dbdb23aaaa44581 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Log exception instead of printStackTrace
by rgolan＠redhat.com 31 Oct '16

31 Oct '16

Roy Golan has submitted this change and it was merged. Change subject: restapi: Log exception instead of printStackTrace ...................................................................... restapi: Log exception instead of printStackTrace Change-Id: I17bfcb92943191860d45af26a08ce366e1839aa0 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSchedulingPolicyResource.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/60314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17bfcb92943191860d45af26a08ce366e1839aa0 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: vdsBroker: Log exception instead of printStackTrace
by rgolan＠redhat.com 31 Oct '16

31 Oct '16

Roy Golan has submitted this change and it was merged. Change subject: core: vdsBroker: Log exception instead of printStackTrace ...................................................................... core: vdsBroker: Log exception instead of printStackTrace Change-Id: I489cdc3473a35219f4fa87a159cb5ed0b6292e3d Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I489cdc3473a35219f4fa87a159cb5ed0b6292e3d Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix is_draft (bool) value
by sbendavi＠redhat.com 31 Oct '16

31 Oct '16

Shlomo Ben David has submitted this change and it was merged. Change subject: Fix is_draft (bool) value ...................................................................... Fix is_draft (bool) value bool(x) function isn't converts 'True' | 'False' strings into bool (True | False) values, it only returns True if the passed value is True, False otherwise. I've replaced it with ast.literal_eval() function that converts and returns the required bool values. Change-Id: I6c17f14465fa9c4cc741f136abc3836ffeaea932 Fixes: OVIRT-797 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/update_tracker 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c17f14465fa9c4cc741f136abc3836ffeaea932 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fixed host displayed cluster
by oourfali＠redhat.com 31 Oct '16

31 Oct '16

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: fixed host displayed cluster ...................................................................... webadmin: fixed host displayed cluster - Due to the order in which the cluster value was updated the list box would think when it was receiving the final value that it was still updating. This caused it to discard the final value and display the wrong value. This patch fixes that issue. Change-Id: I610d5a9adabf1302fe81be15e977c3c517017502 Bug-Url: https://bugzilla.redhat.com/1383020 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GroupedListModelListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 4 files changed, 13 insertions(+), 53 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I610d5a9adabf1302fe81be15e977c3c517017502 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0