- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.5]: engine: Refresh LUN size fails to validate
by tnisan＠redhat.com 30 Oct '16

30 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Refresh LUN size fails to validate ...................................................................... engine: Refresh LUN size fails to validate The RefreshLunsSizeCommand does not verify the LUNs sizes reported by the hosts correctly, failing the command wrongly. See commit: I71d59b9 Change-Id: I0bb02029f33c4ced5c6a1fa890c50dd2e59ad5a9 Bug-Url: https://bugzilla.redhat.com/1389455 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bb02029f33c4ced5c6a1fa890c50dd2e59ad5a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.5 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: Refresh LUN size fails to validate
by tnisan＠redhat.com 30 Oct '16

30 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Refresh LUN size fails to validate ...................................................................... engine: Refresh LUN size fails to validate The RefreshLunsSizeCommand does not verify the LUNs sizes reported by the hosts correctly, failing the command wrongly. See commit: I71d59b9 Change-Id: I0bb02029f33c4ced5c6a1fa890c50dd2e59ad5a9 Bug-Url: https://bugzilla.redhat.com/1389455 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/65855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bb02029f33c4ced5c6a1fa890c50dd2e59ad5a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant test in UpdateVmCommandTest
by tnisan＠redhat.com 30 Oct '16

30 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant test in UpdateVmCommandTest ...................................................................... core: Remove redundant test in UpdateVmCommandTest testMigratoinCanBeSetWhenVMUsesScsiReservation is supposed to test if a VM can be migrated with regrards to whether SCSI reservation is set, however, nothing in UpdateVmCommand test or ever refers in any way to the scsi reservation value thus making this test redundant Change-Id: Ib638643246025eefbbd5d1aef50e435a75f3572a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib638643246025eefbbd5d1aef50e435a75f3572a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Added emails to all test experimental repo jobs
by eedri＠redhat.com 30 Oct '16

30 Oct '16

Eyal Edri has submitted this change and it was merged. Change subject: Added emails to all test experimental repo jobs ...................................................................... Added emails to all test experimental repo jobs As the pipeline plugin has no post build tasks we have only two statuses: FAILURE and SUCCESS Change-Id: Icfa221b109ad2ff5b88e58c5259b2292ee4b8c59 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/groovy-scripts/test-ovirt-repo.groovy 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Nadav Goldin: Looks good to me Eyal Edri: Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfa221b109ad2ff5b88e58c5259b2292ee4b8c59 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove vds_cpu_statistics
by ahadas＠redhat.com 30 Oct '16

30 Oct '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove vds_cpu_statistics ...................................................................... core: remove vds_cpu_statistics Remove the table vds_cpu_statistics that the information stored in it is not queried anymore. This is significant as we identified that this table is being updated much too frequently, leading to serious performance degradation on large scale setups. Change-Id: I047017d2c90d253fdb6d5b0edc34bf5595b89647 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsCpuStatisticsDao.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsCpuStatisticsDaoImpl.java D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsCpuStatisticsDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java A packaging/dbscripts/upgrade/04_01_0370_drop_table_vds_cpu_statistics.sql M packaging/dbscripts/vds_sp.sql 8 files changed, 2 insertions(+), 425 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/65722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I047017d2c90d253fdb6d5b0edc34bf5595b89647 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Adding bond_active_slave to vds_interface_view
by emesika＠redhat.com 30 Oct '16

30 Oct '16

Eli Mesika has submitted this change and it was merged. Change subject: engine: Adding bond_active_slave to vds_interface_view ...................................................................... engine: Adding bond_active_slave to vds_interface_view To prepare exposing the information of the active slave in a "bonded" interface, the information is added to the vds_interface_view. Change-Id: I3a8a4629cc9fd6e5653708938988160200973670 Bug-Url: https://bugzilla.redhat.com/1038550 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Dominik Holler: Verified Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a8a4629cc9fd6e5653708938988160200973670 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Refresh LUN size fails to validate
by amureini＠redhat.com 30 Oct '16

30 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Refresh LUN size fails to validate ...................................................................... engine: Refresh LUN size fails to validate The RefreshLunsSizeCommand does not verify the LUNs sizes reported by the hosts correctly, failing the command wrongly. See commit: I71d59b9 Change-Id: I0bb02029f33c4ced5c6a1fa890c50dd2e59ad5a9 Bug-Url: https://bugzilla.redhat.com/1389455 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bb02029f33c4ced5c6a1fa890c50dd2e59ad5a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Clean up SessionDataContainerTest matchers
by amureini＠redhat.com 30 Oct '16

30 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Clean up SessionDataContainerTest matchers ...................................................................... core: Clean up SessionDataContainerTest matchers Use Mockito's built in matchers for Longs and Sets instead of just using any to make the code a tad more readable. Change-Id: I8b7e09b02f27c8f4aa619f4543b10e1c8e745de5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b7e09b02f27c8f4aa619f4543b10e1c8e745de5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Load all values of ConfigValues
by amureini＠redhat.com 29 Oct '16

29 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Load all values of ConfigValues ...................................................................... core: Load all values of ConfigValues Commit 7bcfe2 introduced a problem to loading the ConfigValues where only a single version of each ConfigValue was loaded from the database. This patch rectifies that problem. Change-Id: I0b7cc146768d077df309e0d6a0004f2cd6c644eb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b7cc146768d077df309e0d6a0004f2cd6c644eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.5]: do not reconnect to policy reset
by piotr.kliczewski＠gmail.com 28 Oct '16

28 Oct '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: do not reconnect to policy reset ...................................................................... do not reconnect to policy reset We do not want to reconnect when policy is reset during setupNetworks. Bug-Url: https://bugzilla.redhat.com/1388778 Change-Id: I932bc95723660874b29c96181bcbbe469f6b0cab Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M ovirt-engine.spec.in M pom.xml 3 files changed, 2 insertions(+), 37 deletions(-) Approvals: Piotr Kliczewski: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I932bc95723660874b29c96181bcbbe469f6b0cab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0