- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddDiskCommandTest: local variables
by amureini＠redhat.com 05 Oct '16

05 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDiskCommandTest: local variables ...................................................................... core: AddDiskCommandTest: local variables Removed redundant local variables. Change-Id: I477dc2e1eafee8665b06b699ccbfc359058e457a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I477dc2e1eafee8665b06b699ccbfc359058e457a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddDiskCommandTest @Spy annotation
by amureini＠redhat.com 05 Oct '16

05 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDiskCommandTest @Spy annotation ...................................................................... core: AddDiskCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: Ic9443fe686c9943a5cb0210b2054b3ea289c2ebd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java 1 file changed, 74 insertions(+), 104 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9443fe686c9943a5cb0210b2054b3ea289c2ebd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddDiskCommandTest: rm redundant VM mocking
by amureini＠redhat.com 05 Oct '16

05 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDiskCommandTest: rm redundant VM mocking ...................................................................... core: AddDiskCommandTest: rm redundant VM mocking AddDisk deals primarily with adding disks (unsurprisingly), although it has a small overlap with VMs as it allows to add and attach a disk in a single action. Most of the test cases, though, do not relate to VMs, and mocking a VM into them just bloats the code and confuses the reader. This patch reduces the VM mocking to where its actually needed in order to make the test more concise and easier to read. Change-Id: I0984bd695054dd5143cfa3bd7458a3fb26a8ac78 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java 1 file changed, 7 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0984bd695054dd5143cfa3bd7458a3fb26a8ac78 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Prepare for next release
by juan.hernandez＠redhat.com 05 Oct '16

05 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Prepare for next release ...................................................................... cli: Prepare for next release In preparation for the next release this patch increases the version number and sets the RPM release number to 0.1. Change-Id: If3b359ecc36c96f09692fd85ef77882e7cdd578c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3b359ecc36c96f09692fd85ef77882e7cdd578c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Release 3.6.9.1
by juan.hernandez＠redhat.com 05 Oct '16

05 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Release 3.6.9.1 ...................................................................... cli: Release 3.6.9.1 Change-Id: I645149467c5579bfe0fc83a9a8ddb3f68a2b2a63 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65110 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I645149467c5579bfe0fc83a9a8ddb3f68a2b2a63 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: Use alternate PKIResourceServlet to fetch CA certificate
by juan.hernandez＠redhat.com 05 Oct '16

05 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use alternate PKIResourceServlet to fetch CA certificate ...................................................................... Use alternate PKIResourceServlet to fetch CA certificate Since oVirt 4.0 there is no ca.crt located in root of the apache, but there is running servlet to fetch the CA certificate. This patch changes the behaviour so we first try to fetch the CA certificate from the root of the apache and if that don't exists, we try to fetch it from new PKIResourceServlet servlet. Change-Id: I5da25e4be36bee56c5ec9ee0dabead574dedada1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1362222 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 40ecfc7c921dd1e320810d81bb01ba91e2526f1e) --- M src/ovirtcli/platform/posix/spice.py 1 file changed, 12 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5da25e4be36bee56c5ec9ee0dabead574dedada1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[master]: Use alternate PKIResourceServlet to fetch CA certificate
by juan.hernandez＠redhat.com 05 Oct '16

05 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use alternate PKIResourceServlet to fetch CA certificate ...................................................................... Use alternate PKIResourceServlet to fetch CA certificate Since oVirt 4.0 there is no ca.crt located in root of the apache, but there is running servlet to fetch the CA certificate. This patch changes the behaviour so we first try to fetch the CA certificate from the root of the apache and if that don't exists, we try to fetch it from new PKIResourceServlet servlet. Change-Id: I5da25e4be36bee56c5ec9ee0dabead574dedada1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1362222 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M src/ovirtcli/platform/posix/spice.py 1 file changed, 12 insertions(+), 7 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5da25e4be36bee56c5ec9ee0dabead574dedada1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: agent: apply virtual-guest tuning profile on installation
by vfeenstr＠redhat.com 05 Oct '16

05 Oct '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: agent: apply virtual-guest tuning profile on installation ...................................................................... agent: apply virtual-guest tuning profile on installation Change-Id: I51691439193ec6da881459a5e7c9f798aa9f618c Signed-off-by: Gal Hammer <ghammer(a)redhat.com> Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent.spec 1 file changed, 29 insertions(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51691439193ec6da881459a5e7c9f798aa9f618c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: aaa: Consolidate SSO session validation requests
by tnisan＠redhat.com 05 Oct '16

05 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Consolidate SSO session validation requests ...................................................................... aaa: Consolidate SSO session validation requests Engine makes multiple queries to SSO to validate each exisitng session. This could cause performance issue when there are thousands of sessions. Combining all requests into one request to fetch all the statuses in one request can resolve the performance issue. When SSO clears an engine session associated with a token by invoking TerminateSessionsForToken SSO_ACCESS_TOKEN_PARAMETER value in the map is null. This can lead to problems when equality is checked with the contents of the map for the token. Change-Id: Ie63dd4e85ac4e4b25cd2884d07d84483dc8add17 Bug-Url: https://bugzilla.redhat.com/1379805 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/DirectorySearch.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java 5 files changed, 58 insertions(+), 25 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie63dd4e85ac4e4b25cd2884d07d84483dc8add17 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: gluster: fix a typo in packages plugin
by sbonazzo＠redhat.com 05 Oct '16

05 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: gluster: fix a typo in packages plugin ...................................................................... packaging: gluster: fix a typo in packages plugin Fixed gluster-server -> glusterfs-server typo. Change-Id: I2b5f78a8bcea79fa6e4745c42d82c22325dff06b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1377851 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/gr-he-setup/system/packages.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b5f78a8bcea79fa6e4745c42d82c22325dff06b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0