- Engine-commits - oVirt List Archives

Change in gerrit-admin[master]: Recreate check_product hook
by eedri＠redhat.com 29 Sep '16

29 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Recreate check_product hook ...................................................................... Recreate check_product hook - The new hook is replacing the old patchset-created.bz.2.correct_product hook and it based on the bz.py module. - It checks only u/s bugs (oVirt classification) - It checks that the current patch project is the same as the bug product. Example: classification: oVirt patch Project: ovirt-engine bug Product: ovirt-engine - All the previous links are pointing to the new hook. Fixes: OVIRT-533 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> Change-Id: Ie65f55ec432d6c5b4f00627b64a7336ae9d9d337 --- A hooks/custom_hooks/check_product 1 file changed, 336 insertions(+), 0 deletions(-) Approvals: Shlomo Ben David: Verified Eyal Edri: Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie65f55ec432d6c5b4f00627b64a7336ae9d9d337 Gerrit-PatchSet: 6 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix update_tracker hook
by eedri＠redhat.com 29 Sep '16

29 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Fix update_tracker hook ...................................................................... Fix update_tracker hook - Update the get_bug_ids function to run as part of the Bugzilla class - Update the update_external function in bz.py module to include branch (ext_priority) in the external bug tracker. Change-Id: I629d6dca2b22e71811aff92a2d5fe39928918d08 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/update_tracker M hooks/lib/bz.py 2 files changed, 41 insertions(+), 20 deletions(-) Approvals: Shlomo Ben David: Verified; Passed CI tests Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I629d6dca2b22e71811aff92a2d5fe39928918d08 Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetGlusterServerForImportQueryTest ExpectedException
by amureini＠redhat.com 28 Sep '16

28 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetGlusterServerForImportQueryTest ExpectedException ...................................................................... core: GetGlusterServerForImportQueryTest ExpectedException Use the ExpectedException @Rule instead of having to boiler-plate implement the same logic in the class in each method. Change-Id: Idf669a6e7a6ca28470301e7ffc52cede6bdde597 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQueryTest.java 1 file changed, 11 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf669a6e7a6ca28470301e7ffc52cede6bdde597 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GeoRepSessionCommandTest default ctor
by amureini＠redhat.com 28 Sep '16

28 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GeoRepSessionCommandTest default ctor ...................................................................... core: GeoRepSessionCommandTest default ctor Remove the useless default constructor. Java will implicitly generate it for you. Change-Id: Ib747e0dfe140cf064fd996cfd929944e27eedcf9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64604 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib747e0dfe140cf064fd996cfd929944e27eedcf9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateGlusterVolumeCommandTest constants
by amureini＠redhat.com 28 Sep '16

28 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: CreateGlusterVolumeCommandTest constants ...................................................................... core: CreateGlusterVolumeCommandTest constants Make constants private static final as per Java's best practices. Change-Id: Ib8a414e63a04cb18ae7a3de7f5ce952461b3b333 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8a414e63a04cb18ae7a3de7f5ce952461b3b333 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddBricksToGlusterVolumeCommandTest#getHCCulster
by amureini＠redhat.com 28 Sep '16

28 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddBricksToGlusterVolumeCommandTest#getHCCulster ...................................................................... core: AddBricksToGlusterVolumeCommandTest#getHCCulster Remove unused method. Change-Id: I861cb66f6e79a36a5e1c95970a05463bcb33cd7b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I861cb66f6e79a36a5e1c95970a05463bcb33cd7b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StartRemoveGlusterVolumeBricksCommandTest#createTestCo...
by amureini＠redhat.com 28 Sep '16

28 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StartRemoveGlusterVolumeBricksCommandTest#createTestCommand ...................................................................... core: StartRemoveGlusterVolumeBricksCommandTest#createTestCommand Removed the useless replicaCount parameter, as it was always 0. Change-Id: I4edf759c0db2160fc0aee22e647fc1fc76bfc99f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRemoveGlusterVolumeBricksCommandTest.java 1 file changed, 8 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4edf759c0db2160fc0aee22e647fc1fc76bfc99f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RefreshGlusterVolumeDetailsCommandTest syncJob
by amureini＠redhat.com 28 Sep '16

28 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RefreshGlusterVolumeDetailsCommandTest syncJob ...................................................................... core: RefreshGlusterVolumeDetailsCommandTest syncJob The member syncJob is mocked and then spied, overriding the mocking. This patch removes the useless spying (and the injection of the AuditLogDirector required because of it), as this test is for RefreshGlusterVolumeDetailsCommand, not the GlusterSyncJob. Change-Id: Icb08c703ff78f383d10f9a0b2539da3858a2af44 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommandTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb08c703ff78f383d10f9a0b2539da3858a2af44 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterVolumeRemoveBricksCommandTest#createTestCommand
by amureini＠redhat.com 28 Sep '16

28 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterVolumeRemoveBricksCommandTest#createTestCommand ...................................................................... core: GlusterVolumeRemoveBricksCommandTest#createTestCommand Removed the useless replicaCount parameter, as it was always 0. Change-Id: Ic4da28e3090492a272fd9062fdf010e42875e26f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommandTest.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4da28e3090492a272fd9062fdf010e42875e26f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ResetGlusterVolumeOptionsCommandTest DAO mocking
by amureini＠redhat.com 28 Sep '16

28 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ResetGlusterVolumeOptionsCommandTest DAO mocking ...................................................................... core: ResetGlusterVolumeOptionsCommandTest DAO mocking Removed unneeded DAO mocking. Change-Id: Ib4edbe09d74ca0b8a501905a5b56270486dcf331 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommandTest.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4edbe09d74ca0b8a501905a5b56270486dcf331 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0