- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: UpdateClusterCommandTest collections
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateClusterCommandTest collections ...................................................................... core: UpdateClusterCommandTest collections Use basic collections instead of anonymously extending HashSet and HashMap. Change-Id: I9edc1d8c6b2f276daa500c0b51a225a94a49cfab Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 1 file changed, 7 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9edc1d8c6b2f276daa500c0b51a225a94a49cfab Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateClusterCommandTest initUser
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateClusterCommandTest initUser ...................................................................... core: UpdateClusterCommandTest initUser Stop unnecessarily stubbing initUser(). Change-Id: I8e825ae0907b385c7fca591355fdc0fc4e26df47 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e825ae0907b385c7fca591355fdc0fc4e26df47 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateClusterCommandTest params ctor
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateClusterCommandTest params ctor ...................................................................... core: UpdateClusterCommandTest params ctor Stop explicitly checking if the managementNetworkId variable is null - the two argument constructor already takes care of it. Change-Id: I1850724cc055b4c079a2589df8b86de04ec6ca87 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1850724cc055b4c079a2589df8b86de04ec6ca87 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateClusterCommandTest#createCommandWithOlderVersion
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateClusterCommandTest#createCommandWithOlderVersion ...................................................................... core: UpdateClusterCommandTest#createCommandWithOlderVersion Remove unused parameters. Change-Id: Ieb823923011b81561cba66eab45073d1a3b83b4d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb823923011b81561cba66eab45073d1a3b83b4d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateGlusterHostPubKeyToSlaveInternalCommandTest daos
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateGlusterHostPubKeyToSlaveInternalCommandTest daos ...................................................................... core: UpdateGlusterHostPubKeyToSlaveInternalCommandTest daos Remove the useless GlusterVolumeDao mock. Change-Id: Ib93d18d0ac48309bae18bb743e179ec27cd6f04f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHostPubKeyToSlaveInternalCommandTest.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib93d18d0ac48309bae18bb743e179ec27cd6f04f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: spec: require newer ovirt-setup-lib
by sbonazzo＠redhat.com 30 Sep '16

30 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: require newer ovirt-setup-lib ...................................................................... packaging: spec: require newer ovirt-setup-lib Require newer ovirt-setup-lib for addressing BZ#1366270 Change-Id: I32568ee572191ffd367a776b75851924dc5ed88d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32568ee572191ffd367a776b75851924dc5ed88d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add example of create new role
by omachace＠redhat.com 30 Sep '16

30 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add example of create new role ...................................................................... Add example of create new role This patch adds example of create new role. Change-Id: Ia3702f83a8c60adcc7a7077be515fae48af84d2a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/examples/add_role.py 1 file changed, 59 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3702f83a8c60adcc7a7077be515fae48af84d2a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add example of assigning permission
by omachace＠redhat.com 30 Sep '16

30 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add example of assigning permission ...................................................................... Add example of assigning permission This patch adds example of assigning GlusterAdmin role to user on network. Change-Id: If10778ff21bf5cfb0f3b576f721ba6b73ce0a3f0 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/examples/assign_permission.py 1 file changed, 64 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64436 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If10778ff21bf5cfb0f3b576f721ba6b73ce0a3f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-setup-lib: branched 4.0
by sbonazzo＠redhat.com 30 Sep '16

30 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-setup-lib: branched 4.0 ...................................................................... ovirt-setup-lib: branched 4.0 Change-Id: If00f8ad54340530994f4d7166c2bb1b88cb98ac0 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-setup-lib/ovirt-setup-lib_build-artifacts.yaml 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If00f8ad54340530994f4d7166c2bb1b88cb98ac0 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: CommandBase-isExecutedAsChildCommand
by amureini＠redhat.com 29 Sep '16

29 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: CommandBase-isExecutedAsChildCommand ...................................................................... engine: CommandBase-isExecutedAsChildCommand Enhance use of CommandBase isExecutedAsChildCommand method. Change-Id: Iac1c6ecceed39b475abc96f257647f8a2750d132 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/StopVdsCommand.java 4 files changed, 7 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve; Passed CI tests Freddy Rolland: Verified Moti Asayag: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac1c6ecceed39b475abc96f257647f8a2750d132 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0