- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: remove TaskHandlerCommand interface
by amureini＠redhat.com 29 Sep '16

29 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: remove TaskHandlerCommand interface ...................................................................... engine: remove TaskHandlerCommand interface As part of removing SEAT framework, the TaskHandlerCommand interface is not needed. Change-Id: Idc7555a26fbfb9f3efa3ee9afe16cc8ad755edc0 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskHandlerCommand.java 6 files changed, 10 insertions(+), 176 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc7555a26fbfb9f3efa3ee9afe16cc8ad755edc0 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove task handlers implementation
by amureini＠redhat.com 29 Sep '16

29 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove task handlers implementation ...................................................................... core: Remove task handlers implementation Removing task handlers implementation from CommandBase. Change-Id: I103330314b80775fd0674009cb2774a4018b3037 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTaskHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializerTest.java 8 files changed, 10 insertions(+), 246 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I103330314b80775fd0674009cb2774a4018b3037 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Removed mistaken el6
by gshinar＠redhat.com 29 Sep '16

29 Sep '16

Gil Shinar has submitted this change and it was merged. Change subject: Removed mistaken el6 ...................................................................... Removed mistaken el6 I have added el6 just to test something and forgot to remove it from the yaml Change-Id: Id32bde746d24d5d0fec27bd4dde3172119d6def9 --- M jobs/confs/projects/jenkins/jenkins_standard.yaml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Gil Shinar: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id32bde746d24d5d0fec27bd4dde3172119d6def9 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in mom[master]: Add caching for vm IO tune policies
by msivak＠redhat.com 29 Sep '16

29 Sep '16

Martin Sivák has submitted this change and it was merged. Change subject: Add caching for vm IO tune policies ...................................................................... Add caching for vm IO tune policies Instead of querying vdsm for each vm's IO tune policy seperatly this allows MOM to query vdsm once for all the needed info and cache the result for all the available vms. Change-Id: Ief6a0ee56e30c6e973321893da30f0b954cb3cfc Bug-Url: https://bugzilla.redhat.com/1366556 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/63971 Continuous-Integration: Jenkins CI Reviewed-by: Martin Sivák <msivak(a)redhat.com> --- A mom/HypervisorInterfaces/vdsmjsonrpcbulkInterface.py A mom/HypervisorInterfaces/vdsmxmlrpcbulkInterface.py 2 files changed, 108 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/63971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief6a0ee56e30c6e973321893da30f0b954cb3cfc Gerrit-PatchSet: 7 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix incorrect VM status icon in NUMA menu
by awels＠redhat.com 29 Sep '16

29 Sep '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix incorrect VM status icon in NUMA menu ...................................................................... webadmin: Fix incorrect VM status icon in NUMA menu This patch fixes an error wherein the status icon of a VM could be out of sync with the actual status of the VM in the NUMA pinning menu. Cause: The instance of the VM model pulled from the database was being discarded and the version currently stored in memory was being used to back the VmNumaSupportModel instead. Fix: Use the model instance being returned from the database to back the VmNumaSupportModel instead of the current model stored in memory. Change-Id: Idd5ed3807d90dbd0ed6b76a31d6a1673e52eb988 Bug-Url: https://bugzilla.redhat.com/1147858 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VmNumaSupportModel.java 1 file changed, 1 insertion(+), 10 deletions(-) Approvals: Roman Mohr: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/64042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd5ed3807d90dbd0ed6b76a31d6a1673e52eb988 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateGlusterVolumeCommand.getVolume()
by amureini＠redhat.com 29 Sep '16

29 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: CreateGlusterVolumeCommand.getVolume() ...................................................................... core: CreateGlusterVolumeCommand.getVolume() Add a utility method getVolume() to return the volume from the parameters instead of saving it as a data member. This achieves two things: First, from a design perspective, it saves the need to keep the same object in two places. Second, it allows for more flexibility, and lends ease to testing the class in the following patches of the series. Change-Id: If8c30fc9ea0822e3832b132ef3f13070a9f7f4f8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java 1 file changed, 23 insertions(+), 23 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8c30fc9ea0822e3832b132ef3f13070a9f7f4f8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove GlusterHookCommandTest ctor
by amureini＠redhat.com 29 Sep '16

29 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove GlusterHookCommandTest ctor ...................................................................... core: remove GlusterHookCommandTest ctor Remove the useless default constructor that does nothing more than the constructor Java would generate for us. Change-Id: I189a65b09adc6b829e3b8da60bd74b2077193448 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I189a65b09adc6b829e3b8da60bd74b2077193448 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused GlusterHookCommandTest#HOOK_ID2
by amureini＠redhat.com 29 Sep '16

29 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused GlusterHookCommandTest#HOOK_ID2 ...................................................................... core: Remove unused GlusterHookCommandTest#HOOK_ID2 Change-Id: I44a991d87349b2575e75a54bf225984955444f5d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44a991d87349b2575e75a54bf225984955444f5d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Spy gluster georep session commands
by amureini＠redhat.com 29 Sep '16

29 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: @Spy gluster georep session commands ...................................................................... core: @Spy gluster georep session commands Cleaned up the gluster geo rep commands tests to use the @Spy annotation in preparation for injecting the DAOs. This patch includes: - Moving the definition of the command to the base class GepRepSessionCommandTest and @Spying it there. - Thus, there is only only command object per test, so all the methods receiving commands as parameters were redone to use the member. - Wherever possible, these now argument-less methods were annotated with @Before to avoid having to call them explicitly in each test. Change-Id: Icaea6b86e36784d53fbe98ab3ef202c202f03b79 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGeoRepSessionCommandTest.java 6 files changed, 75 insertions(+), 105 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaea6b86e36784d53fbe98ab3ef202c202f03b79 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Spy gluster volume commands
by amureini＠redhat.com 29 Sep '16

29 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: @Spy gluster volume commands ...................................................................... core: @Spy gluster volume commands Cleaned up the gluster volume commands tests to use the @Spy annotation in preparation for injecting the DAOs. This patch includes: - Changing the command being tested to be initialized once and annotated with @Spy and @InjectMocks. - Thus, there is only only command object per test, so all the methods receiving commands as parameters were redone to use the member. - Wherever possible, these now argument-less methods were annotated with @Before to avoid having to call them explicitly in each test. - Since now the command under test injects its mocks, redundant InjectorRule calls were removed in order to avoid duplication. Change-Id: I7c5f3a928c5837e275d8fdf06af3f200909183c4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeProfileCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRemoveGlusterVolumeBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeProfileCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommandTest.java 15 files changed, 309 insertions(+), 370 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64611 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c5f3a928c5837e275d8fdf06af3f200909183c4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0