- Engine-commits - oVirt List Archives

Change in otopi[master]: automation: common.sh: Zero dnf.conf
by didi＠redhat.com 27 Sep '16

27 Sep '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: automation: common.sh: Zero dnf.conf ...................................................................... automation: common.sh: Zero dnf.conf This is a hack, needed until jenkins properly supports fedora24/python3/dnf. Change-Id: I6eae84cd81a400769531060cb21af29c193d2e31 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M automation/common.sh 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64000 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6eae84cd81a400769531060cb21af29c193d2e31 Gerrit-PatchSet: 11 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: core: Use python3 on fedora >= 23
by didi＠redhat.com 27 Sep '16

27 Sep '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: core: Use python3 on fedora >= 23 ...................................................................... core: Use python3 on fedora >= 23 Change-Id: If70f3cfda60d42a85f6ce8de1f4464ca940468e9 Bug-Url: https://bugzilla.redhat.com/1316950 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M automation/build-artifacts.packages M automation/build-artifacts.sh D automation/check-merged.packages A automation/check-merged.packages M automation/check-merged.sh D automation/check-patch.packages A automation/check-patch.packages M automation/check-patch.sh A automation/common.sh R automation/coverage.rc.in M otopi.spec.in M src/bin/otopi 12 files changed, 92 insertions(+), 96 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yedidyah Bar David: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/59831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If70f3cfda60d42a85f6ce8de1f4464ca940468e9 Gerrit-PatchSet: 28 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: packagers: minidnf: Install correct libselinux python package
by didi＠redhat.com 27 Sep '16

27 Sep '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: packagers: minidnf: Install correct libselinux python package ...................................................................... packagers: minidnf: Install correct libselinux python package For python3, install libselinux-python3 if selinux can't be imported. Also, reexec only if package was installed. Change-Id: I0538e12c3b55e8570dd678f8689c9bc9129737c1 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/minidnf.py 1 file changed, 26 insertions(+), 14 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0538e12c3b55e8570dd678f8689c9bc9129737c1 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gluster: handle new exceptions in create brick
by masayag＠redhat.com 26 Sep '16

26 Sep '16

Moti Asayag has submitted this change and it was merged. Change subject: gluster: handle new exceptions in create brick ...................................................................... gluster: handle new exceptions in create brick https://gerrit.ovirt.org/#/c/62773/3 introduced two new exceptions related to setting selinux labels on the gluster bricks. Adding the newly introduced exceptions to engine. Change-Id: I49de4ee60a3f4c499dcd50f5327c2c961b50d463 Bug-Url: https://bugzilla.redhat.com/1368474 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 7 files changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/62841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49de4ee60a3f4c499dcd50f5327c2c961b50d463 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove an unused argument from updateDiskImageProfiles...
by tnisan＠redhat.com 26 Sep '16

26 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: remove an unused argument from updateDiskImageProfilesList. ...................................................................... core: remove an unused argument from updateDiskImageProfilesList. The argument "user" is unused and therefor shouldn't be in updateDiskImageProfilesList's signature. Change-Id: I809b02cb313532609b83a768c4916884095a800b Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/64382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I809b02cb313532609b83a768c4916884095a800b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Make CommandHelper.canDoAction accept CommandContext
by tnisan＠redhat.com 26 Sep '16

26 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Make CommandHelper.canDoAction accept CommandContext ...................................................................... core: Make CommandHelper.canDoAction accept CommandContext Currently, the CommandHelper gets ExecutionContext, which lacks the session ID of the caller command. Building the command without a session ID, resulting in having the command without a user in its context. This can cause an unexpected behaviour in some cases, where command validations rely on the currnt user. When developers uses CommandHelper.canDoAction, they don't need to worry about that- they should just clone the command's context and run CommandHelper.canDoAction. This patch changes the signature of CommandHelper.canDoAction, to get a CommandContext. Change-Id: I48e213de4a15480047952a7911de93b4076c040b Related-To: https://bugzilla.redhat.com/64378 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandHelper.java 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Amit Aviram: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48e213de4a15480047952a7911de93b4076c040b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Improve error logging in HostMonitoring
by tnisan＠redhat.com 26 Sep '16

26 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Improve error logging in HostMonitoring ...................................................................... core: Improve error logging in HostMonitoring 1. Moves stacktrace logging into DEBUG log level 2. Replaces 'Vds' with 'host' 3. Adds host name into log message Change-Id: I6b429c27db5c886acb415802ba2287796b558fdd Bug-Url: https://bugzilla.redhat.com/1377310 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java 1 file changed, 10 insertions(+), 9 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b429c27db5c886acb415802ba2287796b558fdd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: README: removing "(optional)" from mandatory prerequisite
by sbonazzo＠redhat.com 26 Sep '16

26 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: README: removing "(optional)" from mandatory prerequisite ...................................................................... README: removing "(optional)" from mandatory prerequisite Change-Id: Id3bfd4f960125c8a599ab7c3de6bef53deac94d3 Bug-Url: https://bugzilla.redhat.com/1379354 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M README.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Ido Rosenzwig: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3bfd4f960125c8a599ab7c3de6bef53deac94d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: added link to moVirt to the welcome page
by tjelinek＠redhat.com 26 Sep '16

26 Sep '16

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: added link to moVirt to the welcome page ...................................................................... engine: added link to moVirt to the welcome page moVirt is quite stable and has couple of hundred of community users already. The community feedback is great (4.7 stars out of 5 on play store). It is time to expose it even more by providing a link on welcome page. Change-Id: If9fb0c42db582ee9fe9ef8bec9728ed1fccd172a Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M packaging/branding/ovirt.brand/messages.properties M packaging/branding/ovirt.brand/welcome_page.template 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9fb0c42db582ee9fe9ef8bec9728ed1fccd172a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: simplify hibernate vm flow
by ahadas＠redhat.com 26 Sep '16

26 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: simplify hibernate vm flow ...................................................................... core: simplify hibernate vm flow Remove redundant transaction when updating the status of the VM. It is not needed since HibernateVDSCommand extends ManagingVmCommand that locks the VM, thus prevents other updates at the same time. Change-Id: Ia0e0351a8b43413a6e06f89fee0b8d9d13ba364d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HibernateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java 2 files changed, 23 insertions(+), 22 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0e0351a8b43413a6e06f89fee0b8d9d13ba364d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0