- Engine-commits - oVirt List Archives

Change in gerrit-admin[master]: Fix bz.py module and added more functionality
by eedri＠redhat.com 25 Sep '16

25 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Fix bz.py module and added more functionality ...................................................................... Fix bz.py module and added more functionality The following functionality has been added: class: Bug class that includes constructor for setting bug structure The bug structure will include: 1. product 2. status 3. title 4. flags 5. target_rel 6. milestone 7. component 8. classification. functions: extract_bug_info(bug_id) function that will return bug data (default info, flags and external tracker info) from the passed bug_id extract_flags(list_of_flags_dicts) function that will return dict of flags with only flag name (key) and flag status (value) get_bug_urls(commit) function that will return list of bug urls from the passed commit message get_bug_ids(bug_urls) function that will return set of unique bug ids from the passed list of bug urls. Change-Id: I39f52bb9d2332cdc1ddb84ab4d412fd94ff75bbc Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/lib/bz.py 1 file changed, 136 insertions(+), 50 deletions(-) Approvals: Shlomo Ben David: Verified Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39f52bb9d2332cdc1ddb84ab4d412fd94ff75bbc Gerrit-PatchSet: 4 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in detection of paused vm
by ahadas＠redhat.com 25 Sep '16

25 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in detection of paused vm ...................................................................... core: cleanup in detection of paused vm Minor cleanup in the part that handles a detection of VM that switches to Paused status in VmAnalyzer. Note that switch from MigratingFrom to Paused is expected to be handled soon as part of post-copy migration. Change-Id: Ie055bfc716195e88e4889a57627dc53eb38a27f7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie055bfc716195e88e4889a57627dc53eb38a27f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in detection of suspended vm
by ahadas＠redhat.com 25 Sep '16

25 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in detection of suspended vm ...................................................................... core: cleanup in detection of suspended vm Change-Id: Ie921c5894a44e0aeb9144554338bbcc6b3d8e938 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie921c5894a44e0aeb9144554338bbcc6b3d8e938 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in detection of migration failure
by ahadas＠redhat.com 25 Sep '16

25 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in detection of migration failure ...................................................................... core: cleanup in detection of migration failure Inline VmAnalyzer#afterMigrationFrom. Change-Id: I7acc7fd57d3dc5af6805050888b93729e83dfb14 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 11 insertions(+), 16 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7acc7fd57d3dc5af6805050888b93729e83dfb14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[refs/meta/config]: Update permissions for ovirt-engine project
by sbendavi＠redhat.com 25 Sep '16

25 Sep '16

Shlomo Ben David has submitted this change and it was merged. Change subject: Update permissions for ovirt-engine project ...................................................................... Update permissions for ovirt-engine project I've updated refs/* to include only owner. All the standard permissions are inherited from All-Project Example: Code-Review = -1..+1 group Registered Users (inherited from All-Project) Verified = -1..+1 group Registered Users (inherited from All-Project) This specific project is customized with permission per branch. Example: Code-Review = -2..+2 group ovirt-engine-stable-maintainers Continuous-Integration = -1..+1 group ovirt-engine-master-maintainers Change-Id: Ic505ff9fbbb884bff012a065dfa4a2e2e3478c96 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M groups M project.config 2 files changed, 15 insertions(+), 59 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic505ff9fbbb884bff012a065dfa4a2e2e3478c96 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: refs/meta/config Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: prevent NPE when referencing inexisting network
by masayag＠redhat.com 25 Sep '16

25 Sep '16

Moti Asayag has submitted this change and it was merged. Change subject: core: prevent NPE when referencing inexisting network ...................................................................... core: prevent NPE when referencing inexisting network Change-Id: I9d0d6a140c2b180a6422a866b6d439ecbbb2089a Bug-Url: https://bugzilla.redhat.com/1349912 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkIdNetworkNameCompleter.java 1 file changed, 16 insertions(+), 10 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59838 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d0d6a140c2b180a6422a866b6d439ecbbb2089a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: set display and management network
by tnisan＠redhat.com 25 Sep '16

25 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: set display and management network ...................................................................... core: set display and management network If a display network is not set by any network except the management one , set it to the management network If a migration network is not set by any network except the management one , set it to the management network Change-Id: Ia6c8435f87b48fea8afc0707920a9e100e4bd02b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1379122 Signed-off-by: emesika <emesika(a)redhat.com> Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_2170_set_display_migration_cluster_network.sql 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/64273 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6c8435f87b48fea8afc0707920a9e100e4bd02b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: vmconsole: fix pep8 issues
by tnisan＠redhat.com 25 Sep '16

25 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: vmconsole: fix pep8 issues ...................................................................... packaging: vmconsole: fix pep8 issues Fix pep8 issues detected by pep8 1.6.2 Change-Id: Ic3c4e1028b3b87a3e29b21927fcd05c62df36c72 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1379122 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/64284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3c4e1028b3b87a3e29b21927fcd05c62df36c72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: set ovirtmgmt net as display and migration
by tnisan＠redhat.com 25 Sep '16

25 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: set ovirtmgmt net as display and migration ...................................................................... engine: set ovirtmgmt net as display and migration Set ovirtmgmt network as display and migration in the initailly created default cluster. Change-Id: I278fec6e6ef0540b6487a70216f8b01006fa8b1e Bug-Url: https://bugzilla.redhat.com/1379122 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M packaging/dbscripts/data/01000_insert_network_cluster.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/64274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I278fec6e6ef0540b6487a70216f8b01006fa8b1e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: diskless VMs don't restore its state after running
by shavivi＠redhat.com 25 Sep '16

25 Sep '16

Shahar Havivi has submitted this change and it was merged. Change subject: core: diskless VMs don't restore its state after running ...................................................................... core: diskless VMs don't restore its state after running Previous assumption that there is no diskless VM in stateless mode is incorrect. Stateless snapshot contains vm configuration and (optionally) memory that one may want to be the same in each run. Change-Id: Icc2221e27fd3793f18c2f010bba2f14519767994 Bug-Url: https://bugzilla.redhat.com/1320879 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 3 files changed, 5 insertions(+), 14 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc2221e27fd3793f18c2f010bba2f14519767994 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0