- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Null check before model cleanup
by tnisan＠redhat.com 26 Sep '16

26 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Null check before model cleanup ...................................................................... webadmin: Null check before model cleanup Patch gerrit.ovirt.org/63708 introduced improved model cleanup yet in cases where the model is already null due to a missing null check a UI exception will be thrown (for instance when closing a dialog with ESC) Bug-Url: https://bugzilla.redhat.com/1379312 Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64458 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Diff file added to jenkins check patch
by eedri＠redhat.com 26 Sep '16

26 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Diff file added to jenkins check patch ...................................................................... Diff file added to jenkins check patch On top of the above I have already reset the color in the differences.html file Change-Id: I4fa89e25cdc1bf67b9cd17b196deec10ddc4ced9 --- M jobs/confs/shell-scripts/htmldiff.sh M jobs/confs/yaml/publishers/exported-artifacts.yaml M jobs/confs/yaml/templates/standard-stage.yaml 3 files changed, 11 insertions(+), 11 deletions(-) Approvals: Eyal Edri: Looks good to me; Ready for merge Gil Shinar: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fa89e25cdc1bf67b9cd17b196deec10ddc4ced9 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: remove builds for cli on master branch
by eedri＠redhat.com 26 Sep '16

26 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: remove builds for cli on master branch ...................................................................... remove builds for cli on master branch ovirt-engine-cli development has stopped at 3.6 and there is no new code for 4.0 or master. Change-Id: Ia2dbd0ac9b7b0cd6ec5fc31c923450527953b2cc Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-cli/ovirt-engine-cli_build-artifacts.yaml 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Looks good to me Eyal Edri: Verified; Looks good to me; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2dbd0ac9b7b0cd6ec5fc31c923450527953b2cc Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in create vm
by ahadas＠redhat.com 26 Sep '16

26 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in create vm ...................................................................... core: cleanup in create vm 1. Replace usages of DBFacade with injections 2. Standardize log message on error 3. Minor layout issues Change-Id: I4b29b135b0be2d1353b7e06e9c76946287b21f98 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 1 file changed, 36 insertions(+), 34 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b29b135b0be2d1353b7e06e9c76946287b21f98 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: improve log message on failure to initiate migrate vm
by ahadas＠redhat.com 26 Sep '16

26 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: improve log message on failure to initiate migrate vm ...................................................................... core: improve log message on failure to initiate migrate vm Print the IDs of the VM and the host and the error message as done in other VM related commands. Change-Id: I1a02131682ee0aae82278c6de6ed1e9dde755fe7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a02131682ee0aae82278c6de6ed1e9dde755fe7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: disallow boot protocol to be null
by tnisan＠redhat.com 26 Sep '16

26 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: disallow boot protocol to be null ...................................................................... core: disallow boot protocol to be null in response to bug 1371119 we should not allow null values in boot protocol columns any more. Change-Id: I535b0945b00b5462cd8a7158f22d63b94f531cd2 Bug-Url: https://bugzilla.redhat.com/1371119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/04_00_0930_disallow_boot_protocol_to_be_null.sql 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I535b0945b00b5462cd8a7158f22d63b94f531cd2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: ovirt-live-4.0.4 GA
by sbonazzo＠redhat.com 26 Sep '16

26 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-4.0.4 GA ...................................................................... build: ovirt-live-4.0.4 GA Change-Id: If4fbc8b1a2b18fe06f7159bfc9ccf6d1634835ed Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4fbc8b1a2b18fe06f7159bfc9ccf6d1634835ed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix LockingInvocationHandler so that it does not throw...
by masayag＠redhat.com 26 Sep '16

26 Sep '16

Moti Asayag has submitted this change and it was merged. Change subject: core: fix LockingInvocationHandler so that it does not throw UndeclaredThrowableException ...................................................................... core: fix LockingInvocationHandler so that it does not throw UndeclaredThrowableException when using java.reflect.Proxy, proxied instance might fail with runtime exception. In that case, if InvocationHandler contains simple: return method.invoke(instance, args); such runtime exception will be 'upgraded' to controlled InvocationTargetException. If caller is not aware of proxy being used (which is kinda a point in using them), and he will not declare it in throws clause (which he shouldn't do anyways) then this controlled exception will be wrapped inside of UndeclaredThrowableException runtime exception. This is totally not desirable. Change-Id: I92e226147710666559781a42e3c25fc619dd727e Bug-Url: https://bugzilla.redhat.com/1378045 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/LockedObjectFactory.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/lock/LockedObjectFactoryTest.java 2 files changed, 28 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Martin Mucha: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92e226147710666559781a42e3c25fc619dd727e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: README: Fix spelling issue
by sbonazzo＠redhat.com 26 Sep '16

26 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: README: Fix spelling issue ...................................................................... README: Fix spelling issue Change-Id: I91e2f7b44f2981eeb6669ae61b5ef42dc2d19fda Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M README.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Looks good to me, but someone else must approve Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91e2f7b44f2981eeb6669ae61b5ef42dc2d19fda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Improve error logging in HostMonitoring
by mperina＠redhat.com 26 Sep '16

26 Sep '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Improve error logging in HostMonitoring ...................................................................... core: Improve error logging in HostMonitoring 1. Moves stacktrace logging into DEBUG log level 2. Replaces 'Vds' with 'host' 3. Adds host name into log message Change-Id: I6b429c27db5c886acb415802ba2287796b558fdd Bug-Url: https://bugzilla.redhat.com/1377310 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java 1 file changed, 10 insertions(+), 9 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Martin Peřina: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b429c27db5c886acb415802ba2287796b558fdd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0