- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Remove Gemfile.lock from the repo
by juan.hernandez＠redhat.com 23 Sep '16

23 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Remove Gemfile.lock from the repo ...................................................................... Remove Gemfile.lock from the repo According to the more Ruby knowledgeable people of the oVirt team it isn't good practice to have the Gemfile.lock file in the source code repository. Change-Id: I2a625927f6877bc90ecc35a9dbc79578dca96274 Signed-off-by: Boris Odnopozov <bodnopoz(a)redhat.com> --- M .gitignore D sdk/Gemfile.lock 2 files changed, 1 insertion(+), 40 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a625927f6877bc90ecc35a9dbc79578dca96274 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.1.13 and metamodel 1.1.5
by juan.hernandez＠redhat.com 23 Sep '16

23 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.13 and metamodel 1.1.5 ...................................................................... restapi: Update to model 4.1.13 and metamodel 1.1.5 The more relevant changes in the new version of the model are the following: * Add the `sparsify` method to `DiskService`. * Add the `discardMaxSize` and `discardZeroesData` to the `LogicalUnit` type. * Fix the type of the `ticket` parameter of the `VmService.ticket` method. * Fix the type of the `authentication_method` attribute of the `Ssh` type. * Rename the `AuthenticationMethod` enum type to `SshAuthenticationMethod`. * Fix the name of the `exclusive` parameter o the `TemplateService.export` method. * Add the missing `cluster` parameter to the `OpenstackImageService.import` method. The more relevant change in the new version of the metamodel is that it supports custom attributes in the generated AsciiDoc, and we actually use the "product-name" and "engine-name" attributes to support branding of the documentation. That means that we need to add "product.name" and "engine.name" properties to the maven build, so that we will be able to produce an engine with branded documentation using those properties. For example, Red Hat could use this mechanism to use "RHV" instead of "oVirt" and "RHV Manager" instead of "oVirt Engine": $ mvn clean install \ -Dproduct.name='RHV' \ -Dengine.name='RHV Manager' Change-Id: I13f46b544f8127438746ca4314e6d6fbf45a103a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SSHInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SshOutAdapter.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M pom.xml 7 files changed, 27 insertions(+), 18 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13f46b544f8127438746ca4314e6d6fbf45a103a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.5]: hosted-engine: set local maintenance to false when installin...
by sbonazzo＠redhat.com 23 Sep '16

23 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: hosted-engine: set local maintenance to false when installing host ...................................................................... hosted-engine: set local maintenance to false when installing host When installing hosted engine host that was installed and then removed from the engine its local maintenance would remain set to true. This patch sets the local maintenance to false when installing the host. Change-Id: I94edee9245728776af15099a3abd707bac19b11a Bug-Url: https://bugzilla.redhat.com/1353600 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit f77af14) --- M src/plugins/ovirt-host-common/hosted-engine/configureha.py 1 file changed, 56 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/64213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94edee9245728776af15099a3abd707bac19b11a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.5 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Empty list is not written to XML
by omachace＠redhat.com 22 Sep '16

22 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Empty list is not written to XML ...................................................................... Empty list is not written to XML When the user wants to send an empty list to the server, it is not currently possible. For example when the user wants to create non VM network he has to send an empty usages element. But if he sets the "Network.usages" attribute to empty list, the empty usages element isn't sent. This patch fixes that. Change-Id: I66bc71cf5c4757fff57b3143218488315dc218b8 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 19a123cbf8d3daa70f99432f9c469eae90a6beb2) --- M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java A sdk/tests/test_network_writer.py 2 files changed, 127 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66bc71cf5c4757fff57b3143218488315dc218b8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: rename fields in vm-dynamic
by ahadas＠redhat.com 22 Sep '16

22 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: rename fields in vm-dynamic ...................................................................... core: rename fields in vm-dynamic By default, fields in VmDynamic refer to VM properties. Thus, there is no need in the 'vm' prefix for its ip, fqdn and pid fields. This patch does not change vmHost on purpose. Change-Id: Ib3f4be8b9b02fc865f65deb9b01db7f453d4a59f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDaoTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateVmView.java 23 files changed, 91 insertions(+), 91 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3f4be8b9b02fc865f65deb9b01db7f453d4a59f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Empty list is not written to XML
by omachace＠redhat.com 22 Sep '16

22 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Empty list is not written to XML ...................................................................... Empty list is not written to XML When the user wants to send an empty list to the server, it is not currently possible. For example when the user wants to create non VM network he has to send an empty usages element. But if he sets the "Network.usages" attribute to empty list, the empty usages element isn't sent. This patch fixes that. Change-Id: I66bc71cf5c4757fff57b3143218488315dc218b8 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java A sdk/tests/test_network_writer.py 2 files changed, 127 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66bc71cf5c4757fff57b3143218488315dc218b8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Empty list is not written to XML
by juan.hernandez＠redhat.com 22 Sep '16

22 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Empty list is not written to XML ...................................................................... Empty list is not written to XML When the user wants to send an empty list to the server, it is not currently possible. For example when the user wants to create non VM network he has to send an empty usages element. But if he sets the "Network.usages" attribute to empty list, the empty usages element isn't sent. This patch fixes that. Change-Id: Iab4f0af3701b4b812800adc7cc527c4506b1a4ea Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit a55cff7bac99e27e90d612c8ed6f266afcce9dd4) --- M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java A sdk/spec/network_writer_spec.rb 2 files changed, 84 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab4f0af3701b4b812800adc7cc527c4506b1a4ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Empty list is not written to XML
by juan.hernandez＠redhat.com 22 Sep '16

22 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Empty list is not written to XML ...................................................................... Empty list is not written to XML When the user wants to send an empty list to the server, it is not currently possible. For example when the user wants to create non VM network he has to send an empty usages element. But if he sets the "Network.usages" attribute to empty list, the empty usages element isn't sent. This patch fixes that. Change-Id: Iab4f0af3701b4b812800adc7cc527c4506b1a4ea Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java A sdk/spec/network_writer_spec.rb 2 files changed, 84 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab4f0af3701b4b812800adc7cc527c4506b1a4ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: aaa: Internal server error once automatically logged out
by tnisan＠redhat.com 22 Sep '16

22 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Internal server error once automatically logged out ...................................................................... aaa: Internal server error once automatically logged out Session expiration on webadmin or userportal after redirecting to sso causes the session attributes to be lost resulting in a NPE. Passing app_url to sso and receiving it back from sso instead of saving app_url in session resolves the issue of session expiration. Change-Id: I44e423d52b5058add54d4ee69e09e1c54f363712 Bug-Url: https://bugzilla.redhat.com/1376003 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit d64cb375f3c09827e39e3861401ba355e407280b) --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLoginServlet.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp 7 files changed, 35 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44e423d52b5058add54d4ee69e09e1c54f363712 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix creation of template from VM with Cinder disks
by tnisan＠redhat.com 22 Sep '16

22 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix creation of template from VM with Cinder disks ...................................................................... core: Fix creation of template from VM with Cinder disks Change-Id: I8275dcbe4e3295fda4797870aaa7b455a87b0a1a Bug-Url: https://bugzilla.redhat.com/1378402 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64292 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8275dcbe4e3295fda4797870aaa7b455a87b0a1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0