- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: use only vm dynamic data on set to unknown
by ahadas＠redhat.com 05 Sep '16

05 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: use only vm dynamic data on set to unknown ...................................................................... core: use only vm dynamic data on set to unknown No need in the whole VM data so we can use a cheaper query based on vm_dynamic rather than on 'vms' view. Change-Id: Ib64c65f94f55e848f53e26ebc6aef32c98c4e2ce Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 13 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62311 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib64c65f94f55e848f53e26ebc6aef32c98c4e2ce Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Avoid of reading fault response in case response body is empty
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Avoid of reading fault response in case response body is empty ...................................................................... Avoid of reading fault response in case response body is empty In case there is 404 returned from API, we try to parse response body, but in this case it's useless and returned exception previously, this patch changes it, so we don't parse response in case it's empty. Change-Id: Ibc43f547a2dc51b2defbc68b81b23a2bc56cd7a1 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit ca058c1123a0d17df01b8b8d5e06c686e6bd39a6) --- M sdk/src/main/java/org/ovirt/engine/sdk4/internal/services/ServiceImpl.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63292 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc43f547a2dc51b2defbc68b81b23a2bc56cd7a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Avoid of reading fault response in case response body is empty
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Avoid of reading fault response in case response body is empty ...................................................................... Avoid of reading fault response in case response body is empty In case there is 404 returned from API, we try to parse response body, but in this case it's useless and returned exception previously, this patch changes it, so we don't parse response in case it's empty. Change-Id: Ibc43f547a2dc51b2defbc68b81b23a2bc56cd7a1 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/src/main/java/org/ovirt/engine/sdk4/internal/services/ServiceImpl.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc43f547a2dc51b2defbc68b81b23a2bc56cd7a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: Revert "engine: add finish report on multi-host network comm...
by tnisan＠redhat.com 05 Sep '16

05 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: Revert "engine: add finish report on multi-host network commands" ...................................................................... Revert "engine: add finish report on multi-host network commands" reverted upon request, due to bug (1372950) and also other bugs(?). This reverts commit 5b10193af007b64259542e10798e18f2122db51e. Bug-Url: https://bugzilla.redhat.com/1372950 Change-Id: If20f6787e947943c191d756c06aa034e7276ab9d Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunction.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/ReportFailedChildHostOperationsUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManageNetworkClustersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunctionTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ManageNetworkClustersParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 11 files changed, 7 insertions(+), 279 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If20f6787e947943c191d756c06aa034e7276ab9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup in move to maintenance
by ahadas＠redhat.com 05 Sep '16

05 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in move to maintenance ...................................................................... core: cleanup in move to maintenance Cleanup VM-related code in moving host to maintenance. Change-Id: I3108a6811a4fa16d939b97b04a0cbd85feaaed8d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java 1 file changed, 9 insertions(+), 16 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3108a6811a4fa16d939b97b04a0cbd85feaaed8d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandBase - CommandStep/FINALIZING step
by laravot＠redhat.com 05 Sep '16

05 Sep '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - CommandStep/FINALIZING step ...................................................................... core: CommandBase - CommandStep/FINALIZING step This patch prevents adding a finalizing step to steps added by overriding getCommandStep(). The finalizing step is currently used for steps and not for jobs only in very specific cases in which also validation and execution steps are added to a step/sub step. When command is adding a step by overriding getCommandStep() its intended to add a "simple" step as replacement to the async tasks added steps when jobs are used instead of tasks therefore there's no need to add a finalizing step when the step was added by getCommandStep(). Change-Id: I9c6d7a5aebfbfa176fca5e8d90b6127ee7cc7a5f Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c6d7a5aebfbfa176fca5e8d90b6127ee7cc7a5f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: storage: Log exception instead of printStackTrace
by rgolan＠redhat.com 05 Sep '16

05 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: core: storage: Log exception instead of printStackTrace ...................................................................... core: storage: Log exception instead of printStackTrace Change-Id: I51805c744da90dca6fcbc43e0a44dda3ccce0c76 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveAllVmCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreAllCinderSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreFromCinderSnapshotCommand.java 3 files changed, 5 insertions(+), 8 deletions(-) Approvals: Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/60313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51805c744da90dca6fcbc43e0a44dda3ccce0c76 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: cleanup: Fix static member accessed via instance wa...
by mbetak＠redhat.com 05 Sep '16

05 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: backend: cleanup: Fix static member accessed via instance warning ...................................................................... backend: cleanup: Fix static member accessed via instance warning Fixed IDE warning caused by accessing static method via instance of ExecutionHandler. Change-Id: Ib7df9de96fdf10216300c7e544b3ba6cd49c0ac7 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7df9de96fdf10216300c7e544b3ba6cd49c0ac7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: mock_runner.sh: Fix yum.conf location
by eedri＠redhat.com 05 Sep '16

05 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: mock_runner.sh: Fix yum.conf location ...................................................................... mock_runner.sh: Fix yum.conf location Change-Id: I44b01cb32350d0bc2fbf9ececcdf700186f7921c Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Looks good to me; Passed CI tests; Ready for merge Barak Korren: Looks good to me; Ready for review Yedidyah Bar David: Verified Evgheni Dereveanchin: Looks good to me -- To view, visit https://gerrit.ovirt.org/63249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44b01cb32350d0bc2fbf9ececcdf700186f7921c Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix virtual size after live merge
by laravot＠redhat.com 04 Sep '16

04 Sep '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Fix virtual size after live merge ...................................................................... core: Fix virtual size after live merge In commit ed2a249c (core: Move logic from RemoveSnapshotSingleDiskLiveCommand), we refactored live merge logic. In that refactor, setting image size after live merge was mistakenly dropped hence, actual size wasn't calculated correctly, mainly if the disk was extended before live merge. This patch fixes that issue by sitting that image size again. Change-Id: Ib7d40270f1330408628d6a551ad24d5f1a4bce61 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7d40270f1330408628d6a551ad24d5f1a4bce61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0