- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: scheduling: Java 8 cleanup in PolicyUnitImpl
by rgolan＠redhat.com 05 Sep '16

05 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Java 8 cleanup in PolicyUnitImpl ...................................................................... scheduling: Java 8 cleanup in PolicyUnitImpl Change-Id: Ia025a7b5415625b9008a11f3691c81ec06fd5816 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Verified Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia025a7b5415625b9008a11f3691c81ec06fd5816 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Use Optional instead of nulls for balancer results
by rgolan＠redhat.com 05 Sep '16

05 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Use Optional instead of nulls for balancer results ...................................................................... scheduling: Use Optional instead of nulls for balancer results This patch converts most of the balancing return values from nullable Pair<...> to Optional<BalancingResult> with the goal of achieving better type safety. Change-Id: Id0f54389a72aad870b61d4b9f58ccac1efdda488 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/BalanceResult.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBroker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerObjectBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HaReservationBalancePolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NoneBalancePolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnitTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnitTest.java 13 files changed, 135 insertions(+), 101 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0f54389a72aad870b61d4b9f58ccac1efdda488 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Fix NPE in ImportVmFromExternalSourceModel
by mbetak＠redhat.com 05 Sep '16

05 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: frontend: Fix NPE in ImportVmFromExternalSourceModel ...................................................................... frontend: Fix NPE in ImportVmFromExternalSourceModel Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373103 Change-Id: If400d25ac485d2ab94d670543773c41ff41c7f26 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalSourceModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/63307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If400d25ac485d2ab94d670543773c41ff41c7f26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Don't return null from send method in case of failure
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Don't return null from send method in case of failure ...................................................................... Don't return null from send method in case of failure In case API returns that request is incorrect, don't return null from send method, so user's code don't fail on NullPointerExceptions. Instead return Reponse implementation and set the apporiate object to null. Change-Id: I8d564ee8636cbba5ae4ce7b8b7b558c86dec2fbe Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 9a35453e842b1c21f33d6b916804103f920f241c) --- M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d564ee8636cbba5ae4ce7b8b7b558c86dec2fbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Don't return null from send method in case of failure
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Don't return null from send method in case of failure ...................................................................... Don't return null from send method in case of failure In case API returns that request is incorrect, don't return null from send method, so user's code don't fail on NullPointerExceptions. Instead return Reponse implementation and set the apporiate object to null. Change-Id: I8d564ee8636cbba5ae4ce7b8b7b558c86dec2fbe Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d564ee8636cbba5ae4ce7b8b7b558c86dec2fbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in mom[master]: Adding build-artifacts-manual.sh script
by msivak＠redhat.com 05 Sep '16

05 Sep '16

Martin Sivák has submitted this change and it was merged. Change subject: Adding build-artifacts-manual.sh script ...................................................................... Adding build-artifacts-manual.sh script Adding build-artifacts-manual.sh script and related packages and repos files. build-artifacts-manual.sh is used for creating rpms from an existing tarball. It assumes that the tarball already exists in the projects directory and builds srpms and rpms, and moves the files to exported_artifacts directory. Change-Id: If82fd014b5e3167846bf96e85e67b642b10b1a75 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/63285 Reviewed-by: Martin Sivák <msivak(a)redhat.com> Continuous-Integration: Jenkins CI --- A automation/build-artifacts-manual.packages A automation/build-artifacts-manual.repos A automation/build-artifacts-manual.repos.fc23 A automation/build-artifacts-manual.sh 4 files changed, 22 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Sharon Naftaly: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If82fd014b5e3167846bf96e85e67b642b10b1a75 Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in mom[master]: Add the standard CI automation configuration
by msivak＠redhat.com 05 Sep '16

05 Sep '16

Martin Sivák has submitted this change and it was merged. Change subject: Add the standard CI automation configuration ...................................................................... Add the standard CI automation configuration Change-Id: I1f4f0d8c20608a1160f7ea49bcf34927a37909bc Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/62835 Continuous-Integration: Jenkins CI --- M .gitignore A automation/build-artifacts.packages A automation/build-artifacts.repos A automation/build-artifacts.repos.fc23 A automation/build-artifacts.sh A automation/check-patch.packages A automation/check-patch.repos A automation/check-patch.repos.fc23 A automation/check-patch.sh 9 files changed, 39 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f4f0d8c20608a1160f7ea49bcf34927a37909bc Gerrit-PatchSet: 6 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "engine: add finish report on multi-host network comm...
by masayag＠redhat.com 05 Sep '16

05 Sep '16

Moti Asayag has submitted this change and it was merged. Change subject: Revert "engine: add finish report on multi-host network commands" ...................................................................... Revert "engine: add finish report on multi-host network commands" reverted upon request, due to bug (1372950) and also other bugs(?). This reverts commit 0ccb3ff4bf84108d4675b434067e2f6e05f6f2f3. Bug-Url: https://bugzilla.redhat.com/1372950 Change-Id: I009153130da4bb2b54231456f4258265030213ab Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunction.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/ReportFailedChildHostOperationsUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManageNetworkClustersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunctionTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ManageNetworkClustersParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 11 files changed, 7 insertions(+), 283 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I009153130da4bb2b54231456f4258265030213ab Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Add packages for el7 for build-artifacts job
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add packages for el7 for build-artifacts job ...................................................................... Add packages for el7 for build-artifacts job Change-Id: Iea1e61ea161e1f2980330569926d3948cb24019e Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 698893fa821689eb4f2729debc73ff06a555b7d2) --- A automation/build-artifacts.packages.el7 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea1e61ea161e1f2980330569926d3948cb24019e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add packages for el7 for build-artifacts job
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add packages for el7 for build-artifacts job ...................................................................... Add packages for el7 for build-artifacts job Change-Id: Iea1e61ea161e1f2980330569926d3948cb24019e Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A automation/build-artifacts.packages.el7 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea1e61ea161e1f2980330569926d3948cb24019e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0