- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: fix wrong imports order
by rgolan＠redhat.com 06 Sep '16

06 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: core: fix wrong imports order ...................................................................... core: fix wrong imports order Change-Id: I7b8a3dd7c0d0c7d0b3baa5d1a8188d0ecce7fec9 Bug-Url: https://bugzilla.redhat.com/1356127 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Objections: gerrit-hooks: Fails -- To view, visit https://gerrit.ovirt.org/63378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b8a3dd7c0d0c7d0b3baa5d1a8188d0ecce7fec9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Support migrating the HE VM out of cluster
by rgolan＠redhat.com 06 Sep '16

06 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: core: Support migrating the HE VM out of cluster ...................................................................... core: Support migrating the HE VM out of cluster This would allow migrating the hosted engine VM out of the cluster. This is specifically needed in case where we want to migrate old cluster version to a new cluster, with new version. Change-Id: Ia49024fb7a6d9558e28c0da5465aff2118f7bbe8 Bug-Url: https://bugzilla.redhat.com/1356127 Signed-off-by: Roy Golan <rgolan(a)redhat.com> (cherry picked from commit 40fbe22c1816b24c746402814121772a5a0f6f97) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ChangeVMClusterCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java 3 files changed, 47 insertions(+), 3 deletions(-) -- To view, visit https://gerrit.ovirt.org/62425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia49024fb7a6d9558e28c0da5465aff2118f7bbe8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in CpuFlagsManagerHandler
by ahadas＠redhat.com 06 Sep '16

06 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in CpuFlagsManagerHandler ...................................................................... core: cleanup in CpuFlagsManagerHandler Change-Id: Id88def0777493ad663d2ff8c00da00d4ef455b85 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java 1 file changed, 105 insertions(+), 132 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id88def0777493ad663d2ff8c00da00d4ef455b85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in resource manager
by ahadas＠redhat.com 06 Sep '16

06 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in resource manager ...................................................................... core: cleanup in resource manager Remove unused fields. Change-Id: I53292dfaa93720f3395ce3016b34f13c248fc86c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53292dfaa93720f3395ce3016b34f13c248fc86c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: If6839b96a16ce3f6eb915134b82ce6ad130c4433 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M automation/build-artifacts.sh M generator/pom.xml M pom.xml M sdk/pom.xml 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6839b96a16ce3f6eb915134b82ce6ad130c4433 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Configure standard automation for mom
by eedri＠redhat.com 05 Sep '16

05 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Configure standard automation for mom ...................................................................... Configure standard automation for mom Change-Id: I72af538767cfdef7f755fecccae612c9fa72ece8 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- D jobs/confs/projects/mom/mom_create-rpms.yaml A jobs/confs/projects/mom/mom_standard.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 5 files changed, 40 insertions(+), 72 deletions(-) Approvals: Martin Sivák: Looks good to me Sharon Naftaly: Verified; Looks good to me Eyal Edri: Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72af538767cfdef7f755fecccae612c9fa72ece8 Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add Ruby SDK builds and tests on ppc64le
by eedri＠redhat.com 05 Sep '16

05 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Add Ruby SDK builds and tests on ppc64le ...................................................................... Add Ruby SDK builds and tests on ppc64le Also removed check-merged jobs as they do almost exactly the same thing as the build-artifacts jobs Change-Id: Ia78aaadff89e2e4bff682997337358e389c6ffdf Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- R jobs/confs/projects/ovirt-engine-sdk-ruby/ovirt-engine-sdk-ruby_standard.yaml 1 file changed, 12 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Looks good to me Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia78aaadff89e2e4bff682997337358e389c6ffdf Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Allow null cpu_profile_id in the DB
by tnisan＠redhat.com 05 Sep '16

05 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Allow null cpu_profile_id in the DB ...................................................................... core: Allow null cpu_profile_id in the DB Will not throw NPE if VM has null cpu_profile_id in the DB. Change-Id: Iad6281415ab0e9637bc12ecc0b9a9cfe8529f93e Bug-Url: https://bugzilla.redhat.com/1373090 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java 4 files changed, 30 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/63296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad6281415ab0e9637bc12ecc0b9a9cfe8529f93e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: restapi: Don't add V3 guest IP to links
by tnisan＠redhat.com 05 Sep '16

05 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Don't add V3 guest IP to links ...................................................................... restapi: Don't add V3 guest IP to links Currently the V3 compatibility layer tries to add the guest IP to all the returned objects of type "vm". That is wrong, as links, for example, shouldn't include such information. To solve the problem this patch changes the API so that the population of the guest IP is performed only for objects of type "vm" returned by the "list", "get", and "update" operations of the services that manage virtual machines. Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda Bug-Url: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 371894f4b19605ebe10fe0e5e2cddd0146482c4a) (cherry picked from commit 3593f106ced78cb0daf6591b46c9de02970fcee8) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 4 files changed, 71 insertions(+), 57 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: restapi: Ignore failures fetching additional disk data
by tnisan＠redhat.com 05 Sep '16

05 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Ignore failures fetching additional disk data ...................................................................... restapi: Ignore failures fetching additional disk data When disks are retrieved using version 3 of the API additional data is required, like the disk attachments. If the user doesn't have permission for the additional data then the complete operation fails. This is a problem for users that may not have permission for that additional data. In order to avoid that this patch changes the API so that failures to retrieve the additional data are just ignored. Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87 Bug-Url: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit d4c500b16549b74839220c8a44b35de4ba9da6ee) (cherry picked from commit a4244b201386e1d2e0db4f92a99171bd5e2cd1ee) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java 3 files changed, 60 insertions(+), 15 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0