- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix cpu profile group permissions
by dfediuck＠redhat.com 01 Sep '16

01 Sep '16

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix cpu profile group permissions ...................................................................... core: Fix cpu profile group permissions Use PermissionDao to correctly check cpu profile user and group permissions. Change-Id: I055c67bc9e3cb6024198e7ee021de3950357f0e1 Bug-Url: https://bugzilla.redhat.com/1369046 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/cpu_profiles_sp.sql M packaging/dbscripts/create_views.sql 15 files changed, 65 insertions(+), 106 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Doron Fediuck: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/62822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I055c67bc9e3cb6024198e7ee021de3950357f0e1 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Update jackson dependencies versions to latest version
by omachace＠redhat.com 01 Sep '16

01 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update jackson dependencies versions to latest version ...................................................................... Update jackson dependencies versions to latest version This patch updates version of jackson dependecies to latest released version of this project. Change-Id: I20f74f579b6cff1d94088874af1be5eee2509412 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63140 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20f74f579b6cff1d94088874af1be5eee2509412 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: restapi: Update to model 4.1.11
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.11 ...................................................................... restapi: Update to model 4.1.11 The more relevant changes included in the new version of the model are the following: * Add the `custom_scheduling_policy_properties` attribute to the `Cluster` type. * Add services and types to support transfer of images. * Remove the `add` and `remove` operations of virtual machine CDROMs. * Fix the type of the `usages` attribute of the `Network` type, it should be a list of values of the `NetworkUsage` enum, not a list of strings. Change-Id: I2dd1175dca29c58e519f0f8c47379d5a5154b7db Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dd1175dca29c58e519f0f8c47379d5a5154b7db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add execution permissions to examples
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add execution permissions to examples ...................................................................... Add execution permissions to examples Some of the example scripts added recently don't have execution permissions. This patch adds them. Change-Id: Ic0fd51a048795aa5dd59caf8055660b34a375f21 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit afe6a21a7be5f5674642b6a361ef06784362380d) --- M sdk/examples/add_independent_vm.rb M sdk/examples/import_external_vm.rb 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0fd51a048795aa5dd59caf8055660b34a375f21 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add execution permissions to examples
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add execution permissions to examples ...................................................................... Add execution permissions to examples Some of the example scripts added recently don't have execution permissions. This patch adds them. Change-Id: Ic0fd51a048795aa5dd59caf8055660b34a375f21 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/examples/add_independent_vm.rb M sdk/examples/import_external_vm.rb 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0fd51a048795aa5dd59caf8055660b34a375f21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Accept 'action' and 'fault' from actions
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Accept 'action' and 'fault' from actions ...................................................................... Accept 'action' and 'fault' from actions Currently the SDK expects that the server to return 'action' XML elements when actions succeed, and 'fault' when they fail. But the server may send 'action' with a nested 'fault' when something fails. This patch modifies the SDK so that it also accepts that. Change-Id: I9fd210df7aff836421d5c9c3c13652fbd9f390e1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 65a779295c65065749177a9243d1155191d958ee) --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/lib/ovirtsdk4/service.rb M sdk/spec/service_spec.rb M sdk/spec/vm_service_spec.rb 4 files changed, 82 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fd210df7aff836421d5c9c3c13652fbd9f390e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Accept 'action' and 'fault' from actions
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Accept 'action' and 'fault' from actions ...................................................................... Accept 'action' and 'fault' from actions Currently the SDK expects that the server to return 'action' XML elements when actions succeed, and 'fault' when they fail. But the server may send 'action' with a nested 'fault' when something fails. This patch modifies the SDK so that it also accepts that. Change-Id: I9fd210df7aff836421d5c9c3c13652fbd9f390e1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/lib/ovirtsdk4/service.rb M sdk/spec/service_spec.rb M sdk/spec/vm_service_spec.rb 4 files changed, 82 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fd210df7aff836421d5c9c3c13652fbd9f390e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Fix reading of list of primitive and enum types
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix reading of list of primitive and enum types ...................................................................... Fix reading of list of primitive and enum types This patch fixes reading of list of primitive and enum types, previously we simply skip the reading. Change-Id: I2cd3d4c5d838b6240fe8b11df6f5521e1a79b252 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 5ecd43a6f1dfe5f7c8f8bcf67d880edab955fa60) --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M sdk/ext/ovirtsdk4c/ov_xml_reader.c A sdk/spec/network_reader_spec.rb M sdk/spec/reader_spec.rb M sdk/spec/xml_reader_spec.rb 5 files changed, 151 insertions(+), 23 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cd3d4c5d838b6240fe8b11df6f5521e1a79b252 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use the cached vm-statistics for vm search queries
by ahadas＠redhat.com 01 Sep '16

01 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: use the cached vm-statistics for vm search queries ...................................................................... core: use the cached vm-statistics for vm search queries VM statistics are cached in VmManager instances so they can be retrieved from them instead of parsing them from the query from the database. This patch doesn't delete VM statistics from 'vms' view since we need to be sure it is not used by others first. Change-Id: I24d01411d72fac02b463026a416a98096f89770f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java 3 files changed, 5 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24d01411d72fac02b463026a416a98096f89770f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Fix reading of list of primitive and enum types
by omachace＠redhat.com 01 Sep '16

01 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Fix reading of list of primitive and enum types ...................................................................... Fix reading of list of primitive and enum types This patch fixes reading of list of primitive and enum types, previously we simply skip the reading. Change-Id: I49cc4bbe165ca25c7e5d54ef176591deca4c692a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit b90c5cad7bb1b0ca146db8d900fd4d9be69a6b73) --- M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java M sdk/ext/ov_xml_reader.c A sdk/tests/test_network_reader.py M sdk/tests/test_reader.py M sdk/tests/test_xml_reader.py 5 files changed, 182 insertions(+), 28 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49cc4bbe165ca25c7e5d54ef176591deca4c692a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0