- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Fix reading of list of primitive and enum types
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix reading of list of primitive and enum types ...................................................................... Fix reading of list of primitive and enum types This patch fixes reading of list of primitive and enum types, previously we simply skip the reading. Change-Id: I2cd3d4c5d838b6240fe8b11df6f5521e1a79b252 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M sdk/ext/ovirtsdk4c/ov_xml_reader.c A sdk/spec/network_reader_spec.rb M sdk/spec/reader_spec.rb M sdk/spec/xml_reader_spec.rb 5 files changed, 151 insertions(+), 23 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cd3d4c5d838b6240fe8b11df6f5521e1a79b252 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add .yardocs file to the .gem file
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add .yardocs file to the .gem file ...................................................................... Add .yardocs file to the .gem file This is required in order to make sure that the documentation generated by the 'rubydocs.info' web site uses AsciiDoc, otherwise it doesn't look good. Change-Id: Idd69d90ea16f24859f7ad5aded68b33e68eb21f1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit fc853e13e86d4d1ce359f8ce402b4e7624ec83a4) --- M packaging/spec.el7.in M packaging/spec.fc23.in M packaging/spec.fc24.in M sdk/README.adoc M sdk/ovirt-engine-sdk.gemspec 5 files changed, 5 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd69d90ea16f24859f7ad5aded68b33e68eb21f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add .yardocs file to the .gem file
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add .yardocs file to the .gem file ...................................................................... Add .yardocs file to the .gem file This is required in order to make sure that the documentation generated by the 'rubydocs.info' web site uses AsciiDoc, otherwise it doesn't look good. Change-Id: Idd69d90ea16f24859f7ad5aded68b33e68eb21f1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/spec.el7.in M packaging/spec.fc23.in M packaging/spec.fc24.in M sdk/README.adoc M sdk/ovirt-engine-sdk.gemspec 5 files changed, 5 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/63014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd69d90ea16f24859f7ad5aded68b33e68eb21f1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: update lun's info on any property change
by derez＠redhat.com 01 Sep '16

01 Sep '16

Daniel Erez has submitted this change and it was merged. Change subject: core: update lun's info on any property change ...................................................................... core: update lun's info on any property change When syncing DB LUNs with the information from the storage, if the LUNs' IDs are different we save a new LUN, and if the LUN's size was changed, we update the existing one. This approach ignores other fields that may have changed, so that: * If another field which is not the LUN's size was changed, the LUN will not be updated. * If the LUN's size was changed, the lun will be updated, along with other fields that were changed. This patch takes a new approach - getLunsToUpdateInDb returns the LUNs that require a DB update and updateLunsInDb always updates these LUNs in the DB (or saves new ones if the ID was changed). Therefore, adding more filters to getLunsToUpdateInDb (like LUNId and deviceSize) will possibly cause more LUNs to be updated in the DB. Change-Id: I9cfd28001fe065001669040ba010d2ee54ac876d Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java 2 files changed, 64 insertions(+), 42 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/62749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cfd28001fe065001669040ba010d2ee54ac876d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Fix reading of list of primitive and enum types
by omachace＠redhat.com 01 Sep '16

01 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Fix reading of list of primitive and enum types ...................................................................... Fix reading of list of primitive and enum types This patch fixes reading of list of primitive and enum types, previously we simply skip the reading. Change-Id: I49cc4bbe165ca25c7e5d54ef176591deca4c692a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java M sdk/ext/ov_xml_reader.c A sdk/tests/test_network_reader.py M sdk/tests/test_reader.py M sdk/tests/test_xml_reader.py 5 files changed, 182 insertions(+), 28 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63020 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49cc4bbe165ca25c7e5d54ef176591deca4c692a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Update to model 4.0.33
by omachace＠redhat.com 01 Sep '16

01 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.0.33 ...................................................................... Update to model 4.0.33 The more relevant changes in this new version of the model are the following: * Add the `custom_scheduling_policy_properties` attribute to the `Cluster` type. * Add services and types to support transfer of images. * Remove the `add` and `remove` operations of virtual machine CDROMs. * Fix the type of the `usages` attribute of the `Network` type, it should be a list of values of the `NetworkUsage` enum, not a list of strings. Change-Id: I55f68bf63208bcac35d2c7de86477be905a15819 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63125 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f68bf63208bcac35d2c7de86477be905a15819 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Update hosts when gluster service enabled
by sabose＠redhat.com 01 Sep '16

01 Sep '16

Sahina Bose has submitted this change and it was merged. Change subject: engine: Update hosts when gluster service enabled ...................................................................... engine: Update hosts when gluster service enabled When gluster service is enabled on cluster that has existing hosts, the gluster properties should be checked and updated. Change-Id: I70fd4d43466aeb6712569f9e5180c11c8d113b00 Bug-Url: https://bugzilla.redhat.com/1313497 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitGlusterCommandHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 286 insertions(+), 225 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70fd4d43466aeb6712569f9e5180c11c8d113b00 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: hosted-engine: set local maintenance to false when installin...
by sbonazzo＠redhat.com 01 Sep '16

01 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: hosted-engine: set local maintenance to false when installing host ...................................................................... hosted-engine: set local maintenance to false when installing host When installing hosted engine host that was installed and then removed from the engine its local maintenance would remain set to true. This patch sets the local maintenance to false when installing the host. Change-Id: Id4aeb80f8c2539024e23ea52de311c2c5157037e Bug-Url: https://bugzilla.redhat.com/1353600 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M src/plugins/ovirt-host-common/hosted-engine/configureha.py 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/62237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4aeb80f8c2539024e23ea52de311c2c5157037e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Update to model 4.1.11
by omachace＠redhat.com 01 Sep '16

01 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.1.11 ...................................................................... Update to model 4.1.11 The more relevant changes in this new version of the model are the following: * Add the `custom_scheduling_policy_properties` attribute to the `Cluster` type. * Add services and types to support transfer of images. * Remove the `add` and `remove` operations of virtual machine CDROMs. * Fix the type of the `usages` attribute of the `Network` type, it should be a list of values of the `NetworkUsage` enum, not a list of strings. Change-Id: I55f68bf63208bcac35d2c7de86477be905a15819 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f68bf63208bcac35d2c7de86477be905a15819 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Don't try to format doc text
by omachace＠redhat.com 01 Sep '16

01 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Don't try to format doc text ...................................................................... Don't try to format doc text Since comments of the model can contain some special fomratting characters, we shouldn't try to format them, when generating Python documentation from the model documentation. Change-Id: I5412e678e4ac6b02357e6ee960870c66844d2156 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit c15301c46e948b300de70f4d1c5d2e1abfb0f3e7) --- M generator/src/main/java/org/ovirt/sdk/python/PythonBuffer.java M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63122 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5412e678e4ac6b02357e6ee960870c66844d2156 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0