- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: Don't try to format doc text
by omachace＠redhat.com 01 Sep '16

01 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Don't try to format doc text ...................................................................... Don't try to format doc text Since comments of the model can contain some special fomratting characters, we shouldn't try to format them, when generating Python documentation from the model documentation. Change-Id: I5412e678e4ac6b02357e6ee960870c66844d2156 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/PythonBuffer.java M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5412e678e4ac6b02357e6ee960870c66844d2156 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Adding build-artifacts-manual.sh script
by sbonazzo＠redhat.com 01 Sep '16

01 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Adding build-artifacts-manual.sh script ...................................................................... Adding build-artifacts-manual.sh script Adding build-artifacts-manual.sh script and related packages and repos files. build-artifacts-manual.sh is used for creating rpms from an existing tarball. It assumes that the tarball already exists in the projects directory and builds srpms and rpms, and moves the files to exported_artifacts directory. Change-Id: I6d421276ae23592d72ff6b88b528a49e9cf43cd0 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A automation/build-artifacts-manual.packages A automation/build-artifacts-manual.repos A automation/build-artifacts-manual.repos.el7 A automation/build-artifacts-manual.sh A automation/build-artifacts.repos.el7 5 files changed, 40 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Martin Sivák: Looks good to me, but someone else must approve Sharon Naftaly: Verified -- To view, visit https://gerrit.ovirt.org/62895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d421276ae23592d72ff6b88b528a49e9cf43cd0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: vdsbroker: GetHostJobsVDSCommand - getting the error info
by laravot＠redhat.com 01 Sep '16

01 Sep '16

Liron Aravot has submitted this change and it was merged. Change subject: vdsbroker: GetHostJobsVDSCommand - getting the error info ...................................................................... vdsbroker: GetHostJobsVDSCommand - getting the error info Change-Id: I7ba916f71cfca034a7e04ab5a245bf7fc03dd8bf Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetHostJobsVDSCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/62790 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ba916f71cfca034a7e04ab5a245bf7fc03dd8bf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.1.11
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.11 ...................................................................... restapi: Update to model 4.1.11 The more relevant changes included in the new version of the model are the following: * Add the `custom_scheduling_policy_properties` attribute to the `Cluster` type. * Add services and types to support transfer of images. * Remove the `add` and `remove` operations of virtual machine CDROMs. * Fix the type of the `usages` attribute of the `Network` type, it should be a list of values of the `NetworkUsage` enum, not a list of strings. Change-Id: I934f27cbb78fa73fe06df85b1673a94d2880b896 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmCdromResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmCdromsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3NetworkInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3NetworkOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmCdromServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmCdromsServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java D backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkUsage.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkMapperTest.java M pom.xml 12 files changed, 50 insertions(+), 49 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I934f27cbb78fa73fe06df85b1673a94d2880b896 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Avoid of reading fault response in case response body is empty
by omachace＠redhat.com 31 Aug '16

31 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Avoid of reading fault response in case response body is empty ...................................................................... Avoid of reading fault response in case response body is empty In case there is 404 returned from API, we try to parse response body, but in this case it's useless and returned exception previously, this patch changes it, so we don't parse response in case it's empty. Change-Id: Ia3c6e7bee7a1926cc007db9477640d675487dbe6 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 1be141f8903117ab5e4535d7c7de9cd16a4753ce) --- M sdk/lib/ovirtsdk4/service.py 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3c6e7bee7a1926cc007db9477640d675487dbe6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: core: Fix overwriting originalClusterVersion
by tnisan＠redhat.com 31 Aug '16

31 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix overwriting originalClusterVersion ...................................................................... core: Fix overwriting originalClusterVersion Fix of overwriting originalClusterVersion in SnapshotManager. The VmBase.originalClusterVersion is persisted in OVF as CLUSTER_COMPATIBILITY_VERSION and points to the cluster version the snapshot was taken in. Later on, the value is used in UI to check whether the snapshot with memory can be properly restored. Change-Id: Ib6f93e9ef91f283ed5e7ebaea75b0351bbd0ed85 Bug-Url: https://bugzilla.redhat.com/1356172 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java 3 files changed, 11 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6f93e9ef91f283ed5e7ebaea75b0351bbd0ed85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: webadmin: Mark instance image as changed in new and attach
by tnisan＠redhat.com 31 Aug '16

31 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Mark instance image as changed in new and attach ...................................................................... webadmin: Mark instance image as changed in new and attach Change I998e8c573c8afaf45668729cf15fb0ebe3edbad5 introduced a change where disk update for instance images will be invoked only upon edit, however, this made new and attach disk actions to be skipped as well. This patch adds the indication of a change to create and attach disk as well so the will not be skipped. Change-Id: I093ccc18a4ab70b4f2a5bcd3ef46abeb41cee55c Bug-Url: https://bugzilla.redhat.com/1371164 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I093ccc18a4ab70b4f2a5bcd3ef46abeb41cee55c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Ignore failures fetching additional disk data
by tnisan＠redhat.com 31 Aug '16

31 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Ignore failures fetching additional disk data ...................................................................... restapi: Ignore failures fetching additional disk data When disks are retrieved using version 3 of the API additional data is required, like the disk attachments. If the user doesn't have permission for the additional data then the complete operation fails. This is a problem for users that may not have permission for that additional data. In order to avoid that this patch changes the API so that failures to retrieve the additional data are just ignored. Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87 Bug-Url: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit d4c500b16549b74839220c8a44b35de4ba9da6ee) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java 3 files changed, 60 insertions(+), 15 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Mark instance image as changed in new and attach
by tnisan＠redhat.com 31 Aug '16

31 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Mark instance image as changed in new and attach ...................................................................... webadmin: Mark instance image as changed in new and attach Change I998e8c573c8afaf45668729cf15fb0ebe3edbad5 introduced a change where disk update for instance images will be invoked only upon edit, however, this made new and attach disk actions to be skipped as well. This patch adds the indication of a change to create and attach disk as well so the will not be skipped. Change-Id: I093ccc18a4ab70b4f2a5bcd3ef46abeb41cee55c Bug-Url: https://bugzilla.redhat.com/1371164 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I093ccc18a4ab70b4f2a5bcd3ef46abeb41cee55c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Don't add V3 guest IP to links
by juan.hernandez＠redhat.com 31 Aug '16

31 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't add V3 guest IP to links ...................................................................... restapi: Don't add V3 guest IP to links Currently the V3 compatibility layer tries to add the guest IP to all the returned objects of type "vm". That is wrong, as links, for example, shouldn't include such information. To solve the problem this patch changes the API so that the population of the guest IP is performed only for objects of type "vm" returned by the "list", "get", and "update" operations of the services that manage virtual machines. Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda Related: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 4 files changed, 71 insertions(+), 57 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0