- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddVmPoolCommand type inference
by amureini＠redhat.com 22 Aug '16

22 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmPoolCommand type inference ...................................................................... core: AddVmPoolCommand type inference Change-Id: Ife3a2c90196d3922c62304c6d6fcda39b3febcda Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife3a2c90196d3922c62304c6d6fcda39b3febcda Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Include master branch in hook consideration
by eedri＠redhat.com 21 Aug '16

21 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: Include master branch in hook consideration ...................................................................... Include master branch in hook consideration until now master branch wasn't in the logic of deciding if to move bug to MODIFIED or not. this was because we searched for branch-suffix matching x.y.z, while master will always have empty match for that. this patch should include master in the check and if there are newer branches that match the target milestone, the status change will be skipped Change-Id: I963d5fd32f8bcf757f8608b60b84225ea87d7c08 Signed-off-by: Eyal Edri <eedri(a)redhat.com> Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED 1 file changed, 18 insertions(+), 6 deletions(-) Approvals: Shlomo Ben David: Verified Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I963d5fd32f8bcf757f8608b60b84225ea87d7c08 Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Rephrase Preview Snapshot warning
by tjelinek＠redhat.com 21 Aug '16

21 Aug '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Rephrase Preview Snapshot warning ...................................................................... webadmin: Rephrase Preview Snapshot warning User warning for preview live snapshot originating in different cluster version is rephrased. User needs to explicitely confirm the intention to restore the memory. Change-Id: Ie6f93f0ddea68dc080d2618551d42a45e1f78d96 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/62596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6f93f0ddea68dc080d2618551d42a45e1f78d96 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SuspendedVMClusterEditChecker removed
by ahadas＠redhat.com 21 Aug '16

21 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: SuspendedVMClusterEditChecker removed ...................................................................... core: SuspendedVMClusterEditChecker removed Prior this change, Cluster Edit dialog displayed warning for suspended VMs when changing cluster level. This warning is no more needed, since it's covered by - more general warning in Cluster Edit - adding nextrun config - and setting temporal custom compatibility level on the VM This patch removes the checker and UI warning. Change-Id: Ica5d54f8c127a8ec7b2ccafcede8f9fe3da1fdc8 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SuspendedVMClusterEditChecker.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 0 insertions(+), 44 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica5d54f8c127a8ec7b2ccafcede8f9fe3da1fdc8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: determine the order of guest agent nic updates
by ahadas＠redhat.com 21 Aug '16

21 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: determine the order of guest agent nic updates ...................................................................... core: determine the order of guest agent nic updates Update the guest agent NIC information according to the order of the VM analyzers in VmsMonitoring. Change-Id: I8b3bdd11b97c133d3cfe09fe6f5c332031ae4e1c Bug-Url: https://bugzilla.redhat.com/1366786 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 1 file changed, 17 insertions(+), 20 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b3bdd11b97c133d3cfe09fe6f5c332031ae4e1c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: determine the order of vm statistics updates
by ahadas＠redhat.com 21 Aug '16

21 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: determine the order of vm statistics updates ...................................................................... core: determine the order of vm statistics updates Update VM statistics data according to the order of the VM analyzers in VmsMonitoring. Change-Id: Ie8d8a7f423121e7ee9876099f261a403abc5c016 Bug-Url: https://bugzilla.redhat.com/1366786 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8d8a7f423121e7ee9876099f261a403abc5c016 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: packaging: spec: explicit implicit deps
by didi＠redhat.com 21 Aug '16

21 Aug '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: packaging: spec: explicit implicit deps ...................................................................... packaging: spec: explicit implicit deps Explicited implicit deps on javapackage-tool and sonatype-parent since they won't be pulled in automatically in next version of Fedora Change-Id: I84be603e3291dbefef99f40548a532e2a5e2c9f5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M otopi.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84be603e3291dbefef99f40548a532e2a5e2c9f5 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Look for sound device by general type
by ahadas＠redhat.com 21 Aug '16

21 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: Look for sound device by general type ...................................................................... webadmin: Look for sound device by general type The sound device in the managed device map of a VM must be located by VmDeviceGeneralType.SOUND, not by VmDeviceType.SOUND. The code that was fixed in InstanceTypeManager.postDoUpdateManagedFieldsFrom(VmBase) is called when user edits a VM and NEXT_RUN snapshot exists. After getting the information about NEXT_RUN snapshot, UI controls in the dialog are updated accordingly. The "Sound card" checkbox is always unchecked, because the code looks for a sound device incorrectly and cannot find it. When user clicks "OK" in the dialog, the difference between actual sound device configuration and the checkbox state is detected and confirmation dialog is displayed. Change-Id: I179bb4623815a90b5468e25e3432351e5458e04a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1356568 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I179bb4623815a90b5468e25e3432351e5458e04a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: python: cleanup import lines using isort
by sbonazzo＠redhat.com 20 Aug '16

20 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: python: cleanup import lines using isort ...................................................................... python: cleanup import lines using isort Ran isort on all the python files included in the project with the following configuration. $ cat ~/.isort.cfg [settings] line_length=79 known_standard_library=configparser,Cheetah.Template force_single_line=True default_section=FIRSTPARTY known_otopi=otopi known_host_deploy=ovirt_host_deploy known_ovirt_engine=ovirt_engine known_ovirt_engine_setup=ovirt_engine_setup known_ovirt_setup_lib=ovirt_setup_lib known_vdsm=vdsm known_ovirt_hosted_engine_setup=ovirt_hosted_engine_setup sections=FUTURE,STDLIB,FIRSTPARTY,OTOPI,VDSM,HOST_DEPLOY,OVIRT_ENGINE,OVIRT_ENGINE_SETUP,OVIRT_SETUP_LIB,OVIRT_HOSTED_ENGINE_SETUP,THIRDPARTY,LOCALFOLDER lines_between_types=2 Change-Id: Ia87d9f3bfb690a2af782a1a8986d232d43fe2a64 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-setup-plugin-live/src/ovirt_live/constants.py M ovirt-engine-setup-plugin-live/src/plugins/all-in-one/core.py M ovirt-engine-setup-plugin-live/src/plugins/all-in-one/cpu.py M ovirt-engine-setup-plugin-live/src/plugins/all-in-one/firewall.py M ovirt-engine-setup-plugin-live/src/plugins/all-in-one/sshd.py M ovirt-engine-setup-plugin-live/src/plugins/all-in-one/storage.py M ovirt-engine-setup-plugin-live/src/plugins/all-in-one/vdsmi.py M ovirt-engine-setup-plugin-live/src/plugins/ovirt_live/core.py 8 files changed, 20 insertions(+), 16 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62623 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia87d9f3bfb690a2af782a1a8986d232d43fe2a64 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Don't duplicate Maven exec plugin
by juan.hernandez＠redhat.com 20 Aug '16

20 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't duplicate Maven exec plugin ...................................................................... restapi: Don't duplicate Maven exec plugin Currently we use the Maven exec plugin several times, to generate the RSDL and also to generate the Java code from the model of the API. To do so we specify the plugin twice in the POM files. Newer versions of Maven don't accept that, and the build fails. To avoid that problem this patch replaces the two plugin usages with one single usage with multiple executions. Change-Id: I81a4d8d48cc5dc15e18048f10fae5c82ae4d4d18 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/pom.xml 1 file changed, 20 insertions(+), 25 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81a4d8d48cc5dc15e18048f10fae5c82ae4d4d18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0